ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Denis Magda <dma...@gridgain.com>
Subject Re: IGNITE-1227 patch available
Date Mon, 16 Nov 2015 12:09:04 GMT
Amir, thanks for pointing out on the outdated steps at ignite.apache.org.

Community, how do we update pages on at ignite.apache.org? Who has a right to do modifications?

Regards,
Denis

> On 16 нояб. 2015 г., at 15:02, Amir Akhmedov <amir.akhmedov@gmail.com> wrote:
> 
> Denis, Artem,
> 
> Thank you guys for clarification. Latter I'll provide a pull-request for
> this ticket.
> 
> I think the page [1] should also be updated, cause I followed the steps
> from there.
> 
> [1] https://ignite.apache.org/community/contribute.html#contribute
> 
> 2015-11-16 14:26 GMT+03:00 Artem Shutak <ashutak@gridgain.com>:
> 
>> Denis, Amir,
>> 
>> First of all, need to understand how it works on TC. TC downloads a patch
>> file and applies it by 'git am <patch-file>' to the latest master. That is
>> mentioned on How to Contribute
>> <https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute> -
>> see "2. Create a Patch-file"/"Applying"
>> 
>> As I see in build logs (
>> 
>> http://ci.ignite.apache.org/viewLog.html?buildId=75417&buildTypeId=Ignite_IgniteCacheFullApi&tab=buildLog&state=&expand=none#_state=78&focus=78
>> )
>> the patch-file couldn't be applied.
>> 
>> Step 3/7: Apply patch (if exist) (Gradle)
>> ...
>> :patchapply
>> ...
>> [10:32:08]Trying to apply patch.
>> [10:32:08]Executing command 'git am
>> dev-tools/IGNITE-1227-12772149.patch'...
>> [10:32:08]Command output:
>> [10:32:08]
>> [10:32:08]Return code: 1
>> [10:32:08]Patch was not applied successfully. Aborting patch applying.
>> 
>> I did it locally and got "Patch format detection failed.". According to a
>> head of the content of the file, the patch has been created by IDEA - it's
>> wrong way. To create patch manually you need to use "git format-patch" or I
>> recommend you to use "<ignite_home>/scripts/git-format-patch.sh". See How
>> to Contribute
>> <https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute> -
>> "2.
>> Create a Patch-file".
>> 
>> Also, I want to say +1 for an Denis's advice to use a pull-request way.
>> This way has no minuses and has a lots of pluses by my opinion against
>> patch-way.
>> 
>> Thanks,
>> -- Artem --
>> 
>> On Mon, Nov 16, 2015 at 1:39 PM, Denis Magda <dmagda@gridgain.com> wrote:
>> 
>>> Amir, before making a review I want to be sure that all Ignite test
>> suites
>>> are green.
>>> 
>>> However, seems that the patch based way contribution is broken. When I
>>> open a test run info for any suite I see the following
>>> http://ci.ignite.apache.org/viewLog.html?buildId=75417
>>> 
>>> FAILURE: Build failed with an exception.
>>> 
>>> * What went wrong:
>>> Execution failed for task ':patchapply'.
>>>> Process 'command '/usr/lib/jvm/java-7-oracle/bin/java'' finished with
>>> non-zero exit value 1
>>> 
>>> 
>>> Artem, do we still support the patch based contribution?
>>> 
>>> Amir, until we’re resolving issue with the patches please follow the
>>> pull-request way. This way of contribution is a preferred one and works
>>> fine:
>>> 
>>> 
>> https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-1.CreateGitHubpull-request
>>> <
>>> 
>> https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-1.CreateGitHubpull-request
>>>> 
>>> Before you push your pull request please get to know our coding
>> guidelines
>>> (identations, brackets usage, etc.). You have some issues in your code
>>> related to guidelines. You’ll see them when familiarize yourself with
>> this
>>> doc:
>>> https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines <
>>> https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines>
>>> 
>>> 
>>> Regards,
>>> Denis
>>> 
>>>> On 13 нояб. 2015 г., at 15:32, Denis Magda <dmagda@gridgain.com>
>> wrote:
>>>> 
>>>> Amir, great thanks!
>>>> 
>>>> If you don't mind I'll review your changes in a couple of days.
>>>> 
>>>> 
>>>> However, probably someone else will do this earlier:)
>>>> 
>>>> --
>>>> Denis
>>>> 
>>>> 
>>>> From: Amir Akhmedov <amir.akhmedov@gmail.com <mailto:
>>> amir.akhmedov@gmail.com>>
>>>> Date: Fri, Nov 13, 2015 at 11:28 AM
>>>> Subject: IGNITE-1227 patch available
>>>> To: dev@ignite.apache.org <mailto:dev@ignite.apache.org>
>>>> 
>>>> 
>>>> Hi Igniters,
>>>> 
>>>> I submitted patch for IGNITE-1227
>>>> <https://issues.apache.org/jira/browse/IGNITE-1227 <
>>> https://issues.apache.org/jira/browse/IGNITE-1227>>, could review it
>>>> whenever it is possible.
>>>> 
>>>> Thanks.
>>>> 
>>>> --
>>>> Sincerely Yours Amir Akhmedov
>>>> 
>>>> 
>>> 
>>> 
>> 
> 
> 
> 
> -- 
> Sincerely Yours Amir Akhmedov


Mime
View raw message