ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From 姜 为 <ydswcy...@gmail.com>
Subject Re: Ignite with Spring boot
Date Sat, 14 Nov 2015 11:22:58 GMT
Hi Denis,

	I have fix the issue and push to github https://github.com/apache/ignite/pull/227/files <https://github.com/apache/ignite/pull/227/files>.

	How to “move ticket to PATCH_AVAILABLE state”?




> 在 2015年11月13日,下午8:26,Denis Magda <dmagda@gridgain.com> 写道:
> 
> I was wrong regarding the following, sorry
> /
> //However, I'm afraid that the fix is inapplicable because you changed methods' return
type from IgniteMXBean public API.//
> //This will break source code compatibility between current and released Ignite versions./
> 
> It's OK to change the return type to the classes proposed by you. However when I applied
your patch I got ClassCastException.
> Left all review notes in the ticket. Please address them.
> https://issues.apache.org/jira/browse/IGNITE-1900
> 
> Nick, thanks for sharing this! However, I think it still makes sense to support the configuration
when JMX is enabled. Moreover it seems to cost nothing for us.
> 
> --
> Regards,
> Denis
> 
> On 11/13/2015 3:13 PM, Nick Pavlov wrote:
>> 姜 为
>> , for fix this error disable spring jmx in application properties
>> 
>> spring.jmx.enabled=false
>> 
>> пт, 13 нояб. 2015 г. в 14:30, Denis Magda <dmagda@gridgain.com <mailto:dmagda@gridgain.com>>:
>> 
>>    Hi,
>> 
>>    As I see you've already found out the reason of the issue [1] and,
>>    moreover, have already fixed it [2] :) Perfect.
>> 
>>    However, I'm afraid that the fix is inapplicable because you
>>    changed methods' return type from IgniteMXBean public API.
>>    This will break source code compatibility between current and
>>    released Ignite versions.
>> 
>>    Does anyone from the community have a thought on how to fix the
>>    issue preserving the compatibility?
>> 
>> 
>>    [1] https://issues.apache.org/jira/browse/IGNITE-1900
>>    [2] https://github.com/apache/ignite/pull/227
>> 
>> 
>>    On 11/13/2015 8:22 AM, 姜 为 wrote:
>>>    Hi:
>>> 
>>>    I’m using Ignite 1.4 and Spring boot 1.2.7.
>>> 
>>>    When I create Ignite bean I got exception:
>>> 
>>>    How can I fix this?
>> 
> 


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message