Return-Path: X-Original-To: apmail-ignite-dev-archive@minotaur.apache.org Delivered-To: apmail-ignite-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2532518C39 for ; Wed, 28 Oct 2015 02:49:16 +0000 (UTC) Received: (qmail 13671 invoked by uid 500); 28 Oct 2015 02:49:16 -0000 Delivered-To: apmail-ignite-dev-archive@ignite.apache.org Received: (qmail 13643 invoked by uid 500); 28 Oct 2015 02:49:16 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 13630 invoked by uid 99); 28 Oct 2015 02:49:15 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Oct 2015 02:49:15 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 3E6F7C3C2A for ; Wed, 28 Oct 2015 02:49:15 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gridgain_com.20150623.gappssmtp.com Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 7j3-TUmA4QU5 for ; Wed, 28 Oct 2015 02:49:08 +0000 (UTC) Received: from mail-yk0-f172.google.com (mail-yk0-f172.google.com [209.85.160.172]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with ESMTPS id 9531220F43 for ; Wed, 28 Oct 2015 02:49:08 +0000 (UTC) Received: by ykdr3 with SMTP id r3so239744869ykd.1 for ; Tue, 27 Oct 2015 19:49:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gridgain_com.20150623.gappssmtp.com; s=20150623; h=mime-version:date:message-id:subject:from:to:content-type; bh=im+IxRy/6qg1VKFn3CYMXkkGtfKjYq93NbwNNXHHQfY=; b=S1/o4Tt4zMbcanaIGZsweSkA8cfPN66gd9S0M4PSOhmUcM0kzGxPAQuwcfpq4Sez4U Cwz6dNrPfN5dF9Cohd2MSLwmXZslNWJaEgnHZZl2zdMSgWDrDNG2Lryhft9n2rAtJvzA v0WRuBOVWKFSL8PDbMUJyjXGL7HieYCrjtF85KnmF1wE7Xgva7aOjJGXsM8k1xnNMfqV hoeIUvnzarfPN3J9GjaT75+0HYFz6zbup/dhAkfYGkWwXfXFypzF6UWTNaiazikpuAMm 3Btad5MFilRgLEQkOOhT9p9ugsCDgERyMUOvJKUHlPiprYzREwcADGD3+UJK6JYKsDdK jX5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to :content-type; bh=im+IxRy/6qg1VKFn3CYMXkkGtfKjYq93NbwNNXHHQfY=; b=RygqS0omNrcYhUvVqXQu3Y77jxWz8SnWk2+V8VnbZwZnR3C0Zfm71nYYTeHvHEODm7 VOWZlkDbEEg4vFILK4DRz1HGx7w+guX3WTomgoAUlz/P7K06zTtRXw5hkocHJcnhJmMz znh/dTHcA8BN7iNRC/FxFHnsLqrHGgKko1F4Y3cOxDUzvdpaBjwWTaEj3jp3lZtqWhQO 9mWwZssBwtMBTNY/shbqbxIPFAAPxvSyj7vvVyusbeU9OBXKCIePzsJyGza/3V/LyTUD lcAKHXStwSbM0NZ8mpvGn9zlWMmeuEs7B4MRRlDGU5DVzcOgfqqCsIlkk/Qyku7dIu9u 4x2g== X-Gm-Message-State: ALoCoQlEfa8BDWE5udVNG7aYl2dT2U2U1VjBYPRX67+mNEydqb8rw1rjySgJ43M5ka8t9MWVE+JD MIME-Version: 1.0 X-Received: by 10.13.203.141 with SMTP id n135mr10843807ywd.335.1446000547901; Tue, 27 Oct 2015 19:49:07 -0700 (PDT) Received: by 10.13.223.84 with HTTP; Tue, 27 Oct 2015 19:49:07 -0700 (PDT) Date: Wed, 28 Oct 2015 09:49:07 +0700 Message-ID: Subject: Portables hash code. From: Alexey Kuznetsov To: dev@ignite.apache.org Content-Type: multipart/alternative; boundary=001a114e43e000f0120523213d80 --001a114e43e000f0120523213d80 Content-Type: text/plain; charset=UTF-8 Igniters, I'm working on [1] "IGNITE-1753 Rework CacheJdbcPojoStore to new API." And one of subtasks is to support portable objects with JDBC store. I implemented this and during tests found a huge performance drop when I have PortableObject as key. After some debugging I found that all my portable objects have hashCode = 0. I'm using PortableBuilder to build my portable objects. And I expected that PortableBuilder will calculate proper hash code for me out of the box. I think we should at least describe in PortableBuilder javadocs that by default PortableBuilder will return zero hashcode? Or we should calculate hashcode in PortableBuilder.build() method? Or may be we could add boolean argument PortableBuilder.build(boolean generateHashCode)? Thoughts? P.S. After I added manual hashcode calculation to my CacheJdbcPojoStore performance drop is gone away. [1] https://issues.apache.org/jira/browse/IGNITE-1753 -- Alexey Kuznetsov GridGain Systems www.gridgain.com --001a114e43e000f0120523213d80--