Return-Path: 
 <dev-return-8190-apmail-ignite-dev-archive=ignite.apache.org@ignite.apache.org>
X-Original-To: apmail-ignite-dev-archive@minotaur.apache.org
Delivered-To: apmail-ignite-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 135E2188CE
	for <apmail-ignite-dev-archive@minotaur.apache.org>;
 Thu, 22 Oct 2015 10:52:58 +0000 (UTC)
Received: (qmail 46018 invoked by uid 500); 22 Oct 2015 10:52:57 -0000
Delivered-To: apmail-ignite-dev-archive@ignite.apache.org
Received: (qmail 45970 invoked by uid 500); 22 Oct 2015 10:52:57 -0000
Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@ignite.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@ignite.apache.org>
List-Post: <mailto:dev@ignite.apache.org>
List-Id: <dev.ignite.apache.org>
Reply-To: dev@ignite.apache.org
Delivered-To: mailing list dev@ignite.apache.org
Received: (qmail 45959 invoked by uid 99); 22 Oct 2015 10:52:57 -0000
Received: from mail-relay.apache.org (HELO mail-relay.apache.org)
 (140.211.11.15)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Oct 2015 10:52:57 +0000
Received: from mail-lf0-f49.google.com (mail-lf0-f49.google.com
 [209.85.215.49])
	by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with
 ESMTPSA id 5C9F91A04CA
	for <dev@ignite.apache.org>; Thu, 22 Oct 2015 10:52:57 +0000 (UTC)
Received: by lfbn126 with SMTP id n126so8866512lfb.2
        for <dev@ignite.apache.org>; Thu, 22 Oct 2015 03:52:55 -0700 (PDT)
X-Gm-Message-State: 
 ALoCoQkZYNQDHvMzNNjRbS2l4/cjLUNXwgj0uDxWfrwK4GoiZurX+XKmmontVlDqCJ1+Wr2g5O/r
MIME-Version: 1.0
X-Received: by 10.25.41.79 with SMTP id p76mr5292044lfp.16.1445511175164; Thu,
 22 Oct 2015 03:52:55 -0700 (PDT)
Received: by 10.114.23.66 with HTTP; Thu, 22 Oct 2015 03:52:55 -0700 (PDT)
In-Reply-To: 
 <CAKoNANv9h3OMOHbO_CGyPhar9dSwKyOf5R34FrKHhChiXTOkHQ@mail.gmail.com>
References: 
 <CAKoNANv9h3OMOHbO_CGyPhar9dSwKyOf5R34FrKHhChiXTOkHQ@mail.gmail.com>
Date: Thu, 22 Oct 2015 13:52:55 +0300
Message-ID: 
 <CAGcMBHiNTPf3PXxUjMhDsB0bP0YSekxv-Cdeh7izHHPWiNw+=w@mail.gmail.com>
Subject: Re: MQTT Streamer Code Style and Javadoc fixes (IGNITE-1747)
From: Yakov Zhdanov <yzhdanov@apache.org>
To: dev@ignite.apache.org
Content-Type: multipart/alternative; boundary=001a11410d941d7d4b0522af4cb9

--001a11410d941d7d4b0522af4cb9
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi Raul!

Thank you very much for addressing my comments!

I like the code however there are still a couple of points (I committed
everything to ignite-1747):

1. Please take a look at
https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#Coding=
Guidelines-StringOutput
2. org.apache.ignite.stream.mqtt.MqttStreamer#connected - volatile write
then read of most likely the same value - I changed it to return true
literal.
connected =3D true;
return connected;
3. blockUntilConnected - I would name this property syncConn
4. Abbreviation rules violations - connected - conn, executor - exec,
values - vals, count - cnt, message - msg
5. What is the point of "connected" member? Client has "isConnected()"? Is
it similar to what you want to achieve?
6. Race on stop - 1 thread calls stop and successfully exits the method,
retrier is not stopped (awaitTermination has not been called - should it
be?) and can connect client back - is this the case?
7. I think we use {@code } instead of <tt>...

On more point community should agree on  - imports ordering and grouping. I
will post another email.

--Yakov

2015-10-20 20:39 GMT+03:00 Raul Kripalani <raulk@apache.org>:

> Hi Yakov,
>
> I've had a few free cycles to fix the code style and Javadoc issues you
> reported in the MQTT Streamer and I've pushed my changes to branch
> ignite-1747.
>
> Would you mind having a look to see if it adapts better now?
>
> Thanks,
>
> *Ra=C3=BAl Kripalani*
> PMC & Committer @ Apache Ignite, Apache Camel | Integration, Big Data and
> Messaging Engineer
> http://about.me/raulkripalani | http://www.linkedin.com/in/raulkripalani
> http://blog.raulkr.net | twitter: @raulvk
>

--001a11410d941d7d4b0522af4cb9--