ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ken Cheng <kcheng....@gmail.com>
Subject Re: Please help to do the code review for those newbie PR
Date Tue, 01 Sep 2015 12:29:19 GMT
Hi Alexey,


yes, just as you said, if the node start with client mode

 cfg.setClientMode(true);

Then the case will fail, I have implemented the method as you advised.
please help to review the PR

Thanks,
kcheng

On Tue, Sep 1, 2015 at 9:51 AM, Alexey Goncharuk <alexey.goncharuk@gmail.com
> wrote:

> Ken,
>
> I have also provided some feedback regarding the IGNTIE-1226 ticket (sorry
> it took a long time to respond to your previous email).
>
> 2015-08-31 18:48 GMT-07:00 Valentin Kulichenko <
> valentin.kulichenko@gmail.com>:
>
> > Hi Ken,
> >
> > I was just in process of reviewing them :) Please give me couple more
> hours
> > and I will provide feedback.
> >
> > -Val
> >
> > On Mon, Aug 31, 2015 at 6:47 PM, Ken Cheng <kcheng.mvp@gmail.com> wrote:
> >
> > > Hi Valentin Kulichenko*  &  *Alexey Kuznetsov
> > >
> > > Can you help to do the code review for the newbie bugs
> > >
> > > Jira:
> > > https://issues.apache.org/jira/browse/IGNITE-1226
> > > https://issues.apache.org/jira/browse/IGNITE-1153
> > >
> > > PR:
> > >
> > > https://github.com/apache/ignite/pull/35
> > > https://github.com/apache/ignite/pull/44
> > >
> > >
> > > Thanks,
> > > kcheng
> > >
> > > On Mon, Aug 31, 2015 at 2:11 PM, Ken Cheng <kcheng.mvp@gmail.com>
> wrote:
> > >
> > > > Hi devs,
> > > >
> > > > https://github.com/apache/ignite/pull/35
> > > > https://github.com/apache/ignite/pull/44
> > > >
> > > >
> > > > Thanks,
> > > > kcheng
> > > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message