ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Valentin Kulichenko <valentin.kuliche...@gmail.com>
Subject Re: Please help to do the code review for those newbie PR
Date Tue, 01 Sep 2015 04:29:00 GMT
Ken,

I left a comment in https://github.com/apache/ignite/pull/44/. Please take
a look.

Thanks!

-Val

On Mon, Aug 31, 2015 at 6:51 PM, Alexey Goncharuk <
alexey.goncharuk@gmail.com> wrote:

> Ken,
>
> I have also provided some feedback regarding the IGNTIE-1226 ticket (sorry
> it took a long time to respond to your previous email).
>
> 2015-08-31 18:48 GMT-07:00 Valentin Kulichenko <
> valentin.kulichenko@gmail.com>:
>
> > Hi Ken,
> >
> > I was just in process of reviewing them :) Please give me couple more
> hours
> > and I will provide feedback.
> >
> > -Val
> >
> > On Mon, Aug 31, 2015 at 6:47 PM, Ken Cheng <kcheng.mvp@gmail.com> wrote:
> >
> > > Hi Valentin Kulichenko*  &  *Alexey Kuznetsov
> > >
> > > Can you help to do the code review for the newbie bugs
> > >
> > > Jira:
> > > https://issues.apache.org/jira/browse/IGNITE-1226
> > > https://issues.apache.org/jira/browse/IGNITE-1153
> > >
> > > PR:
> > >
> > > https://github.com/apache/ignite/pull/35
> > > https://github.com/apache/ignite/pull/44
> > >
> > >
> > > Thanks,
> > > kcheng
> > >
> > > On Mon, Aug 31, 2015 at 2:11 PM, Ken Cheng <kcheng.mvp@gmail.com>
> wrote:
> > >
> > > > Hi devs,
> > > >
> > > > https://github.com/apache/ignite/pull/35
> > > > https://github.com/apache/ignite/pull/44
> > > >
> > > >
> > > > Thanks,
> > > > kcheng
> > > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message