Return-Path: X-Original-To: apmail-ignite-dev-archive@minotaur.apache.org Delivered-To: apmail-ignite-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2390318A46 for ; Tue, 11 Aug 2015 22:39:47 +0000 (UTC) Received: (qmail 172 invoked by uid 500); 11 Aug 2015 22:39:47 -0000 Delivered-To: apmail-ignite-dev-archive@ignite.apache.org Received: (qmail 132 invoked by uid 500); 11 Aug 2015 22:39:47 -0000 Mailing-List: contact dev-help@ignite.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.incubator.apache.org Delivered-To: mailing list dev@ignite.incubator.apache.org Received: (qmail 118 invoked by uid 99); 11 Aug 2015 22:39:46 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Aug 2015 22:39:46 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 8FD77DC5FC for ; Tue, 11 Aug 2015 22:39:46 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.758 X-Spam-Level: X-Spam-Status: No, score=0.758 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.222] autolearn=disabled Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id N4-itnKA2Wm4 for ; Tue, 11 Aug 2015 22:39:46 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with SMTP id F343524AC5 for ; Tue, 11 Aug 2015 22:39:45 +0000 (UTC) Received: (qmail 99621 invoked by uid 99); 11 Aug 2015 22:39:45 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Aug 2015 22:39:45 +0000 Date: Tue, 11 Aug 2015 22:39:45 +0000 (UTC) From: =?utf-8?Q?Ra=C3=BAl_Kripalani_=28JIRA=29?= To: dev@ignite.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (IGNITE-1236) Create a checkstyle definition and hook it into the Maven build MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Ra=C3=BAl Kripalani created IGNITE-1236: -------------------------------------- Summary: Create a checkstyle definition and hook it into the M= aven build Key: IGNITE-1236 URL: https://issues.apache.org/jira/browse/IGNITE-1236 Project: Ignite Issue Type: Improvement Components: build Reporter: Ra=C3=BAl Kripalani Assignee: Ra=C3=BAl Kripalani The community has put together a comprehensive set of coding guidelines her= e: https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines. We need a checkstyle definition that we can enforce automatically via the M= aven Checkstyle plugin. We can choose to output violations as warnings, or to fail the build if vio= lations exist. At this point I would prefer the former to avoid "stopping t= he world". With such a large codebase it is likely that checkstyle violatio= ns are already present. This will help contributors adequate their style to the community's standar= d while they are coding, and will reduce frustration otherwise caused by su= bmitting pull requests that do not satisfy guidelines, and having to rectif= y them at a later stage. -- This message was sent by Atlassian JIRA (v6.3.4#6332)