Return-Path: X-Original-To: apmail-ignite-dev-archive@minotaur.apache.org Delivered-To: apmail-ignite-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B31D6181F4 for ; Wed, 26 Aug 2015 18:13:22 +0000 (UTC) Received: (qmail 5628 invoked by uid 500); 26 Aug 2015 18:13:22 -0000 Delivered-To: apmail-ignite-dev-archive@ignite.apache.org Received: (qmail 5587 invoked by uid 500); 26 Aug 2015 18:13:22 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 5574 invoked by uid 99); 26 Aug 2015 18:13:22 -0000 Received: from Unknown (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Aug 2015 18:13:22 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id DBAA7C028F for ; Wed, 26 Aug 2015 18:13:21 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.9 X-Spam-Level: ** X-Spam-Status: No, score=2.9 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 3CEhosqeUILy for ; Wed, 26 Aug 2015 18:13:12 +0000 (UTC) Received: from mail-io0-f179.google.com (mail-io0-f179.google.com [209.85.223.179]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with ESMTPS id 86A11381B3 for ; Wed, 26 Aug 2015 18:08:14 +0000 (UTC) Received: by iodt126 with SMTP id t126so28975006iod.2 for ; Wed, 26 Aug 2015 11:08:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=lbCk2JED3SdvnjQ+906WEgGIIfgYoAYf3+4lnVb2MnY=; b=MfAYDYuZnAyWR5vUZdOAWfA8lEFtWyMEx0NpJL8Dj+NCRH2mdU2UjodBruGNhJRa4V /I+2SpAf6Xn5KJrgG429q5dV9Ou9QuwEWsWJM3xs82nuHLFrCKm5o2AZmddv3bWyWbB2 L+GoNOVIwenl5jmW8aeGNCbN3OaLutBfXZHGKCsYFwT2KFYxFVsryuigox3s3makrfAV y/bhllI642oOcTBCTUv5B7ekyggFgcxf08RlcuvDjCiyZINeDmo0naeZ9V2+A1HkPiBM WWRsAhw0a8jpH/P8uxGA+eJqqjp8iAcA7kY/fxiXB+sRbQ/KPjtJYpXCrSyc/dNEF64s iEOA== MIME-Version: 1.0 X-Received: by 10.107.168.25 with SMTP id r25mr5783044ioe.32.1440612493471; Wed, 26 Aug 2015 11:08:13 -0700 (PDT) Received: by 10.107.12.208 with HTTP; Wed, 26 Aug 2015 11:08:13 -0700 (PDT) In-Reply-To: References: Date: Wed, 26 Aug 2015 11:08:13 -0700 Message-ID: Subject: Re: Deprecate IgniteConfiguration.getGridName From: Valentin Kulichenko To: dev@ignite.apache.org Cc: dev@ignite.incubator.apache.org Content-Type: multipart/alternative; boundary=001a11427bcaeeb744051e3abb98 --001a11427bcaeeb744051e3abb98 Content-Type: text/plain; charset=UTF-8 +1 for 'instanceName'. 'nodeName' looks confusing as well - I would think that it should be unique among all nodes. -Val On Wed, Aug 26, 2015 at 2:25 AM, Raul Kripalani wrote: > Agree. The term grid to refer to a single node is very confusing. > On 19 Aug 2015 08:58, "Semyon Boikov" wrote: > > > In my opinion this propery just should be renamed to 'nodeName'. > > Possibility to set node name is very useful in our tests. As I see > > 'setNodeId' is already deprecated in IgniteConfiguration, how we will > > distinguish nodes in our tests? > > > > On Tue, Aug 18, 2015 at 1:42 PM, Yakov Zhdanov > > wrote: > > > > > Guys, > > > > > > I am thinking of deprecating this property. > > > > > > 1. nodes with different grid names can discover each other and build a > > > single topology. I heard that some of the users expected that there > would > > > be separate topologies > > > 2. Locally started nodes can be accessed via their IDs through Ignition > > > interface. > > > 3. Internally gridName is used in components serialization and > > > deserializaiton, but this is very unreliable and can be broken if > > different > > > names are configured within the same topology - > > > https://issues.apache.org/jira/browse/IGNITE-10 > > > > > > Thoughts? > > > > > > --Yakov > > > > > > --001a11427bcaeeb744051e3abb98--