ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ken Cheng <kcheng....@gmail.com>
Subject Re: Code is ready for bug fix https://issues.apache.org/jira/browse/IGNITE-1226
Date Tue, 25 Aug 2015 10:41:13 GMT
Yeah, that's straight simple, every one can easily understand.

Thanks,
kcheng

On Tue, Aug 25, 2015 at 6:35 PM, Branko ─îibej <brane@apache.org> wrote:

> On 25.08.2015 11:58, Raul Kripalani wrote:
> > The Github repo of Ignite is read only. It's just a mirror of the Apache
> > repo.
> >
> > You need to fork it into your own Github account. Then you clone the fork
> > locally and push the branch to it.
> >
> > Later, you open a Pull Request to the apache/ignite repo, making sure
> that
> > you include the ticket number (IGNITE-nnnn) in the description.
> >
> > The ASF Github bot will pick up the pull request and notify the Dev team
> on
> > the mailing list and on JIRA.
>
>
> And does everyone who's writing these instructions really think this is
> a reasonable process for new contributors? Why not just clone from
> git-wip-us, make the change on a local branch and either send the patch
> to the dev list or attach it to the Jira issue? There's no sane reason
> to involve GitHub at all.
>
> As it is, you're telling him to jump through 4 hoops when he could just
> as easily get the same done by jumping through 2. Meh.
>
> -- Brane
>
>
>
> > On 25 Aug 2015 10:49, "Ken Cheng" <kcheng.mvp@gmail.com> wrote:
> >
> >> [image: Inline image 1]
> >>
> >> Just as the screen shows, I have created a branch with the Jira number,
> >> but when I try to push my fix it promotes me to input
> username/password, I
> >> tried with my github account but got the authentication failure.
> >>
> >> Thanks,
> >> kcheng
> >>
> >> On Tue, Aug 25, 2015 at 5:44 PM, Alexey Kuznetsov <
> akuznetsov@gridgain.com
> >>> wrote:
> >>> Ken,
> >>>
> >>> Please, get familiar with process
> >>> https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute
> >>>
> >>> In short, you should fork apache-ignite on git hub, create branch, push
> >>> you
> >>> fixes and create a pull request.
> >>>
> >>> Someone from committers will review your patch and merge it or give
> you a
> >>> review comments.
> >>>
> >>> Hope this help.
> >>>
> >>> On Tue, Aug 25, 2015 at 4:40 PM, Ken Cheng <kcheng.mvp@gmail.com>
> wrote:
> >>>
> >>>> grant me the write privilege to github, as I need user/password to
> push
> >>> my
> >>>> fix.
> >>>>
> >>>> Thanks,
> >>>> kcheng
> >>>>
> >>>> On Tue, Aug 25, 2015 at 5:36 PM, Ken Cheng <kcheng.mvp@gmail.com>
> >>> wrote:
> >>>>> Hi All,
> >>>>>
> >>>>> My first fix for Ignite
> >>>> https://issues.apache.org/jira/browse/IGNITE-1226
> >>>>> is ready.
> >>>>> Can someone grant the write privilege to github?
> >>>>>
> >>>>>
> >>>>> Thanks,
> >>>>> kcheng
> >>>>>
> >>>
> >>>
> >>> --
> >>> Alexey Kuznetsov
> >>> GridGain Systems
> >>> www.gridgain.com
> >>>
> >>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message