Return-Path: X-Original-To: apmail-ignite-dev-archive@minotaur.apache.org Delivered-To: apmail-ignite-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 490DD101AB for ; Fri, 5 Jun 2015 08:22:32 +0000 (UTC) Received: (qmail 63097 invoked by uid 500); 5 Jun 2015 08:22:32 -0000 Delivered-To: apmail-ignite-dev-archive@ignite.apache.org Received: (qmail 63055 invoked by uid 500); 5 Jun 2015 08:22:32 -0000 Mailing-List: contact dev-help@ignite.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.incubator.apache.org Delivered-To: mailing list dev@ignite.incubator.apache.org Received: (qmail 63043 invoked by uid 99); 5 Jun 2015 08:22:31 -0000 Received: from Unknown (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Jun 2015 08:22:31 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 323C11821FA for ; Fri, 5 Jun 2015 08:22:31 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.505 X-Spam-Level: **** X-Spam-Status: No, score=4.505 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, SUBJ_ALL_CAPS=1.625, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 72RGx0S04I9U for ; Fri, 5 Jun 2015 08:22:24 +0000 (UTC) Received: from mail-yh0-f50.google.com (mail-yh0-f50.google.com [209.85.213.50]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with ESMTPS id 75B93274BB for ; Fri, 5 Jun 2015 08:22:24 +0000 (UTC) Received: by yhid80 with SMTP id d80so7581537yhi.1 for ; Fri, 05 Jun 2015 01:20:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=ybZsNDSSSlLrYGxi9L+0ewG/v1bu9Q1w+E/xskFUWQ4=; b=CqexrTJbHT5JdxjXGXi979eXE1QxzmvhdbcxChR43Fio3StqLOMOB4Q8rki956cA1R Zkg0Z0+Obr/gTUolrzrpiWL/zUkXAQmUtZeOFxPorL3Wr5OVAmtD4nhXGW2OGMT9MfdP w0GpgAvaiCzpa7CWGId7sMp4j35B2aJ6CImzF5qYbRDDzj5cbqPwPLddLly7nVK+V2bb JoaSuiM5pcLb9tbjI7qmv6GVjyb0BMvcBjOfeNeOTExwErjYZcCfybZ/d6vdFK+JdbiA 6e3cqXuHwAqxKv3ZA9eVzp3wVmyLlC9bLT9tfl4t4+JOLJcgHa5OBH7QG+z+Id1xNhM+ h84Q== MIME-Version: 1.0 X-Received: by 10.236.231.171 with SMTP id l41mr2220790yhq.68.1433492453762; Fri, 05 Jun 2015 01:20:53 -0700 (PDT) Received: by 10.129.133.2 with HTTP; Fri, 5 Jun 2015 01:20:53 -0700 (PDT) In-Reply-To: References: Date: Fri, 5 Jun 2015 13:50:53 +0530 Message-ID: Subject: Re: IGNITE 917 From: Atri Sharma To: dev@ignite.incubator.apache.org Content-Type: multipart/alternative; boundary=089e0112ca3e7eac2c0517c0f8dc --089e0112ca3e7eac2c0517c0f8dc Content-Type: text/plain; charset=UTF-8 Artem, Thanks for your comments. I incorporated your comments and sent new patch. Please see and comment. Regards, Atri On Fri, Jun 5, 2015 at 3:22 AM, Artiom Shutak wrote: > Atri, please, see my comments at the Jira ticket. > > -- Artem -- > > On Thu, Jun 4, 2015 at 7:44 PM, Atri Sharma wrote: > > > Thanks. > > > > Sorry for the noise on this one. I am off next week so it's helpful if we > > can close this by this week if possible. I am willing to work in my > > midnight for that if needed :) > > On 4 Jun 2015 01:53, "Dmitriy Setrakyan" wrote: > > > > > Atri, > > > > > > Thanks for providing a patch to Ignite! I am sure someone in the > > community > > > will be looking into it shortly (if not already). > > > > > > Once your patch is accepted, you will be eligible to become a > committer. > > > > > > D. > > > > > > On Tue, Jun 2, 2015 at 7:03 AM, Atri Sharma > wrote: > > > > > > > Patch version 1 is available. Please see and comment. > > > > > > > > On Mon, Jun 1, 2015 at 9:18 PM, Atri Sharma > > wrote: > > > > > > > > > Thanks. > > > > > > > > > > On Mon, Jun 1, 2015 at 9:16 PM, Yakov Zhdanov > > > > > wrote: > > > > > > > > > >> Did you see the comment in the ticket? Andrey Gura has put some > tips > > > > >> there. > > > > >> You can ask further questions in the ticket. > > > > >> > > > > >> Good luck! > > > > >> > > > > >> --Yakov > > > > >> > > > > >> 2015-06-01 18:40 GMT+03:00 Atri Sharma : > > > > >> > > > > >> > Thanks Yakov. > > > > >> > > > > > >> > Can you also please advice at code areas where I should look at > > for > > > > this > > > > >> > please? > > > > >> > > > > > >> > On Mon, Jun 1, 2015 at 9:03 PM, Yakov Zhdanov < > > yzhdanov@apache.org> > > > > >> wrote: > > > > >> > > > > > >> > > Arti you can read about sprint process here > > > > >> > > > > https://cwiki.apache.org/confluence/display/IGNITE/Sprint+Process > > > > >> > > > > > > >> > > This page will be soon updated with information on how to > format > > > and > > > > >> > submit > > > > >> > > patch and check CI tests. > > > > >> > > > > > > >> > > --Yakov > > > > >> > > > > > > >> > > 2015-06-01 12:54 GMT+03:00 Atri Sharma : > > > > >> > > > > > > >> > > > I would like to work on 917, have assigned it to myself. > > > > >> > > > > > > > >> > > > Please advice on the approach and code areas this patch will > > > need > > > > >> > > > modifications in. > > > > >> > > > > > > > >> > > > -- > > > > >> > > > Regards, > > > > >> > > > > > > > >> > > > Atri > > > > >> > > > *l'apprenant* > > > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > > >> > > > > > >> > -- > > > > >> > Regards, > > > > >> > > > > > >> > Atri > > > > >> > *l'apprenant* > > > > >> > > > > > >> > > > > > > > > > > > > > > > > > > > > -- > > > > > Regards, > > > > > > > > > > Atri > > > > > *l'apprenant* > > > > > > > > > > > > > > > > > > > > > -- > > > > Regards, > > > > > > > > Atri > > > > *l'apprenant* > > > > > > > > > > -- Regards, Atri *l'apprenant* --089e0112ca3e7eac2c0517c0f8dc--