ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Artiom Shutak <ashu...@gridgain.com>
Subject Re: IGNITE 917
Date Thu, 11 Jun 2015 09:31:57 GMT
Atri,

I am ok with your patch in general.

I think, someone from commiters will create new branch with your patch, do
all needed fixes and merge it in a couple of days.

Thank you for your conrtibution at Ignite!

-- Artem --

On Wed, Jun 10, 2015 at 4:45 PM, Atri Sharma <atri.jiit@gmail.com> wrote:

> Please let me know your comments and feedback.
> On 9 Jun 2015 23:38, "Artiom Shutak" <ashutak@gridgain.com> wrote:
>
> > Atri, see my comments at jira.
> >
> > I think someone from commiters should do review.
> >
> > -- Artem --
> >
> > On Tue, Jun 9, 2015 at 7:56 PM, Atri Sharma <atri.jiit@gmail.com> wrote:
> >
> > > Updated patch sent.
> > >
> > > Please see and let me know your feedback and comments.
> > >
> > > On Tue, Jun 9, 2015 at 12:32 AM, Artiom Shutak <ashutak@gridgain.com>
> > > wrote:
> > >
> > > > See comments at Jira.
> > > >
> > > > -- Artem --
> > > >
> > > > On Mon, Jun 8, 2015 at 8:21 PM, Atri Sharma <atri.jiit@gmail.com>
> > wrote:
> > > >
> > > > > Latest patch uploaded.  Please see and let me know your comments
> > > > > On 8 Jun 2015 22:19, "Atri Sharma" <atri.jiit@gmail.com> wrote:
> > > > >
> > > > > > Thanks for that.
> > > > > >
> > > > > > So got a build success.
> > > > > >
> > > > > > On Mon, Jun 8, 2015 at 10:07 PM, Artiom Shutak <
> > ashutak@gridgain.com
> > > >
> > > > > > wrote:
> > > > > >
> > > > > >> Atri,
> > > > > >>
> > > > > >> As usual, then you are using Apache Maven then BUILD SUCCESS
> means
> > > all
> > > > > are
> > > > > >> OK, and BUILD FAILURE means that something went wrong.
> > > > > >>
> > > > > >> -- Artem --
> > > > > >>
> > > > > >> On Mon, Jun 8, 2015 at 7:20 PM, Atri Sharma <
> atri.jiit@gmail.com>
> > > > > wrote:
> > > > > >>
> > > > > >> > Thanks.
> > > > > >> >
> > > > > >> > I have fixed the comments.
> > > > > >> >
> > > > > >> > My local results for your command are:
> > > > > >> >
> > > > > >> > [21:25:16,252][INFO ][Thread-2][GridProjectionSelfTest0]
> > > > > >> >
> > > > > >> > >>> +-----------------------------------------------------+
> > > > > >> > >>> Ignite ver. 1.1.1-SNAPSHOT#19700101-sha1:DEV
stopped OK
> > > > > >> > >>> +-----------------------------------------------------+
> > > > > >> > >>> Grid name: internal.GridProjectionSelfTest0
> > > > > >> > >>> Grid uptime: 00:03:15:461
> > > > > >> >
> > > > > >> >
> > > > > >> > [21:25:16,252][INFO ][Thread-8][GridProjectionSelfTest3]
> > > > > >> >
> > > > > >> > >>> +-----------------------------------------------------+
> > > > > >> > >>> Ignite ver. 1.1.1-SNAPSHOT#19700101-sha1:DEV
stopped OK
> > > > > >> > >>> +-----------------------------------------------------+
> > > > > >> > >>> Grid name: internal.GridProjectionSelfTest3
> > > > > >> > >>> Grid uptime: 00:03:14:214
> > > > > >> >
> > > > > >> >
> > > > > >> > [21:25:16,252][INFO ][Thread-4][GridProjectionSelfTest1]
> > > > > >> >
> > > > > >> > >>> +-----------------------------------------------------+
> > > > > >> > >>> Ignite ver. 1.1.1-SNAPSHOT#19700101-sha1:DEV
stopped OK
> > > > > >> > >>> +-----------------------------------------------------+
> > > > > >> > >>> Grid name: internal.GridProjectionSelfTest1
> > > > > >> > >>> Grid uptime: 00:03:14:916
> > > > > >> >
> > > > > >> >
> > > > > >> > [21:25:16,266][INFO ][Thread-6][GridProjectionSelfTest2]
> > > > > >> >
> > > > > >> > >>> +-----------------------------------------------------+
> > > > > >> > >>> Ignite ver. 1.1.1-SNAPSHOT#19700101-sha1:DEV
stopped OK
> > > > > >> > >>> +-----------------------------------------------------+
> > > > > >> > >>> Grid name: internal.GridProjectionSelfTest2
> > > > > >> > >>> Grid uptime: 00:03:14:618
> > > > > >> >
> > > > > >> >
> > > > > >> > which I assume means successful run.
> > > > > >> >
> > > > > >> > I am sorry about the formatting issues. For me getting
the
> > > > formatting
> > > > > in
> > > > > >> > place is always the biggest problem :)
> > > > > >> >
> > > > > >> > I have learnt a lot about the ASF coding formats and
general
> > Java
> > > > > >> codelines
> > > > > >> > (this is the first time I have written Java in my life).
So I
> am
> > > > sure
> > > > > >> that
> > > > > >> > this patch has allowed me to learn the ways to be used
in
> > further
> > > > > >> patches
> > > > > >> > that I write and review.
> > > > > >> >
> > > > > >> > On Mon, Jun 8, 2015 at 9:34 PM, Artiom Shutak <
> > > ashutak@gridgain.com
> > > > >
> > > > > >> > wrote:
> > > > > >> >
> > > > > >> > > As I can see by history for new failed tests they
are not
> > stable
> > > > and
> > > > > >> fail
> > > > > >> > > sometimes.
> > > > > >> > >
> > > > > >> > > I suggest you to focus on your issue and your
new test at
> > first.
> > > > > >> > >
> > > > > >> > > -- Artem --
> > > > > >> > >
> > > > > >> > > On Mon, Jun 8, 2015 at 6:52 PM, Atri Sharma <
> > > atri.jiit@gmail.com>
> > > > > >> wrote:
> > > > > >> > >
> > > > > >> > > > Thanks for the advice.
> > > > > >> > > >
> > > > > >> > > > Actually I am a bit lost here. I can understand
why the
> new
> > > > test I
> > > > > >> > added
> > > > > >> > > > fails but I am not sure why the rest of the
tests fail
> > since I
> > > > > have
> > > > > >> not
> > > > > >> > > > touched any code that follows the call path
for those
> tests.
> > > > Sorry
> > > > > >> if I
> > > > > >> > > am
> > > > > >> > > > being naive, but is there a way I can identify
what is
> > > causing a
> > > > > >> test
> > > > > >> > to
> > > > > >> > > > fail, please?
> > > > > >> > > >
> > > > > >> > > > On Mon, Jun 8, 2015 at 9:17 PM, Artiom Shutak
<
> > > > > ashutak@gridgain.com
> > > > > >> >
> > > > > >> > > > wrote:
> > > > > >> > > >
> > > > > >> > > > > To run tests locally use:
> > > > > >> > > > >
> > > > > >> > > > > mvn clean test -U -Plgpl,examples,-clean-libs,-release
> > > > > >> > > > > -Dmaven.test.failure.ignore=true -DfailIfNoTests=false
> > > > > >> > > > > -Dtest=%TEST_PATTERN%
> > > > > >> > > > >
> > > > > >> > > > > For example, %TEST_PATTERN% can be
> > > > > >> > > > > 'org.apache.ignite.testsuites.IgniteBasicTestSuite'
or
> > > > > >> > > > > 'GridCacheLocalAtomicFullApiSelfTest#testGet'
> > > > > >> > > > >
> > > > > >> > > > > In your case
> > > > > >> > > > >
> > > > > >> > > > > mvn clean test -U -Plgpl,examples,-clean-libs,-release
> > > > > >> > > > > -Dmaven.test.failure.ignore=true -DfailIfNoTests=false
> > > -Dtest=
> > > > > >> > > > > GridProjectionSelfTest#testforHostString
> > > > > >> > > > >
> > > > > >> > > > >
> > > > > >> > > > > -- Artem --
> > > > > >> > > > >
> > > > > >> > > > > On Mon, Jun 8, 2015 at 5:07 PM, Atri
Sharma <
> > > > > atri.jiit@gmail.com>
> > > > > >> > > wrote:
> > > > > >> > > > >
> > > > > >> > > > > > Can you advice on the test failures
please? I have no
> > idea
> > > > of
> > > > > >> > > debugging
> > > > > >> > > > > the
> > > > > >> > > > > > plethora of tests but I suspect
that the same fault in
> > the
> > > > > >> patch is
> > > > > >> > > > > causing
> > > > > >> > > > > > them to fail...
> > > > > >> > > > > >
> > > > > >> > > > > > On Mon, Jun 8, 2015 at 7:18 PM,
Artiom Shutak <
> > > > > >> > ashutak@gridgain.com>
> > > > > >> > > > > > wrote:
> > > > > >> > > > > >
> > > > > >> > > > > > > Atri, see my comments at Jira.
> > > > > >> > > > > > >
> > > > > >> > > > > > > I want to ask you to be more
careful with all review
> > > > > comments
> > > > > >> > > (reread
> > > > > >> > > > > all
> > > > > >> > > > > > > above) and fix all of them.
> > > > > >> > > > > > >
> > > > > >> > > > > > > -- Artem --
> > > > > >> > > > > > >
> > > > > >> > > > > > > On Mon, Jun 8, 2015 at 1:49
PM, Atri Sharma <
> > > > > >> atri.jiit@gmail.com
> > > > > >> > >
> > > > > >> > > > > wrote:
> > > > > >> > > > > > >
> > > > > >> > > > > > > > Fixed and attached.
> > > > > >> > > > > > > >
> > > > > >> > > > > > > > Please see and let me
know your feedback and
> > comments.
> > > > > >> > > > > > > >
> > > > > >> > > > > > > > On Fri, Jun 5, 2015 at
4:44 PM, Artiom Shutak <
> > > > > >> > > > ashutak@gridgain.com>
> > > > > >> > > > > > > > wrote:
> > > > > >> > > > > > > >
> > > > > >> > > > > > > > > Hi Atri,
> > > > > >> > > > > > > > >
> > > > > >> > > > > > > > > See my new review
in jira.
> > > > > >> > > > > > > > >
> > > > > >> > > > > > > > > -- Artem --
> > > > > >> > > > > > > > >
> > > > > >> > > > > > > > > On Fri, Jun 5, 2015
at 11:20 AM, Atri Sharma <
> > > > > >> > > > atri.jiit@gmail.com>
> > > > > >> > > > > > > > wrote:
> > > > > >> > > > > > > > >
> > > > > >> > > > > > > > > > Artem,
> > > > > >> > > > > > > > > >
> > > > > >> > > > > > > > > > Thanks for
your comments.
> > > > > >> > > > > > > > > >
> > > > > >> > > > > > > > > >
> > > > > >> > > > > > > > > > I incorporated
your comments and sent new
> patch.
> > > > > Please
> > > > > >> see
> > > > > >> > > and
> > > > > >> > > > > > > > comment.
> > > > > >> > > > > > > > > >
> > > > > >> > > > > > > > > > Regards,
> > > > > >> > > > > > > > > >
> > > > > >> > > > > > > > > > Atri
> > > > > >> > > > > > > > > >
> > > > > >> > > > > > > > > > On Fri, Jun
5, 2015 at 3:22 AM, Artiom Shutak
> <
> > > > > >> > > > > > ashutak@gridgain.com>
> > > > > >> > > > > > > > > > wrote:
> > > > > >> > > > > > > > > >
> > > > > >> > > > > > > > > > > Atri,
please, see my comments at the Jira
> > > ticket.
> > > > > >> > > > > > > > > > >
> > > > > >> > > > > > > > > > > -- Artem
--
> > > > > >> > > > > > > > > > >
> > > > > >> > > > > > > > > > > On Thu,
Jun 4, 2015 at 7:44 PM, Atri Sharma
> <
> > > > > >> > > > > atri.jiit@gmail.com
> > > > > >> > > > > > >
> > > > > >> > > > > > > > > wrote:
> > > > > >> > > > > > > > > > >
> > > > > >> > > > > > > > > > > > Thanks.
> > > > > >> > > > > > > > > > > >
> > > > > >> > > > > > > > > > > > Sorry
for the noise on this one. I am off
> > next
> > > > > week
> > > > > >> so
> > > > > >> > > it's
> > > > > >> > > > > > > helpful
> > > > > >> > > > > > > > > if
> > > > > >> > > > > > > > > > we
> > > > > >> > > > > > > > > > > > can
close this by this week if possible. I
> > am
> > > > > >> willing
> > > > > >> > to
> > > > > >> > > > work
> > > > > >> > > > > > in
> > > > > >> > > > > > > my
> > > > > >> > > > > > > > > > > > midnight
for that if needed :)
> > > > > >> > > > > > > > > > > > On
4 Jun 2015 01:53, "Dmitriy Setrakyan" <
> > > > > >> > > > > > dsetrakyan@apache.org>
> > > > > >> > > > > > > > > > wrote:
> > > > > >> > > > > > > > > > > >
> > > > > >> > > > > > > > > > > > >
Atri,
> > > > > >> > > > > > > > > > > > >
> > > > > >> > > > > > > > > > > > >
Thanks for providing a patch to Ignite!
> I
> > am
> > > > > sure
> > > > > >> > > someone
> > > > > >> > > > > in
> > > > > >> > > > > > > the
> > > > > >> > > > > > > > > > > > community
> > > > > >> > > > > > > > > > > > >
will be looking into it shortly (if not
> > > > > already).
> > > > > >> > > > > > > > > > > > >
> > > > > >> > > > > > > > > > > > >
Once your patch is accepted, you will be
> > > > > eligible
> > > > > >> to
> > > > > >> > > > > become a
> > > > > >> > > > > > > > > > > committer.
> > > > > >> > > > > > > > > > > > >
> > > > > >> > > > > > > > > > > > >
D.
> > > > > >> > > > > > > > > > > > >
> > > > > >> > > > > > > > > > > > >
On Tue, Jun 2, 2015 at 7:03 AM, Atri
> > Sharma
> > > <
> > > > > >> > > > > > > atri.jiit@gmail.com
> > > > > >> > > > > > > > >
> > > > > >> > > > > > > > > > > wrote:
> > > > > >> > > > > > > > > > > > >
> > > > > >> > > > > > > > > > > > >
> Patch version 1 is available. Please
> see
> > > and
> > > > > >> > comment.
> > > > > >> > > > > > > > > > > > >
>
> > > > > >> > > > > > > > > > > > >
> On Mon, Jun 1, 2015 at 9:18 PM, Atri
> > > Sharma
> > > > <
> > > > > >> > > > > > > > atri.jiit@gmail.com
> > > > > >> > > > > > > > > >
> > > > > >> > > > > > > > > > > > wrote:
> > > > > >> > > > > > > > > > > > >
>
> > > > > >> > > > > > > > > > > > >
> > Thanks.
> > > > > >> > > > > > > > > > > > >
> >
> > > > > >> > > > > > > > > > > > >
> > On Mon, Jun 1, 2015 at 9:16 PM,
> Yakov
> > > > > Zhdanov
> > > > > >> <
> > > > > >> > > > > > > > > > yzhdanov@apache.org
> > > > > >> > > > > > > > > > > >
> > > > > >> > > > > > > > > > > > >
> wrote:
> > > > > >> > > > > > > > > > > > >
> >
> > > > > >> > > > > > > > > > > > >
> >> Did you see the comment in the
> > ticket?
> > > > > Andrey
> > > > > >> > Gura
> > > > > >> > > > has
> > > > > >> > > > > > put
> > > > > >> > > > > > > > > some
> > > > > >> > > > > > > > > > > tips
> > > > > >> > > > > > > > > > > > >
> >> there.
> > > > > >> > > > > > > > > > > > >
> >> You can ask further questions in
> the
> > > > > ticket.
> > > > > >> > > > > > > > > > > > >
> >>
> > > > > >> > > > > > > > > > > > >
> >> Good luck!
> > > > > >> > > > > > > > > > > > >
> >>
> > > > > >> > > > > > > > > > > > >
> >> --Yakov
> > > > > >> > > > > > > > > > > > >
> >>
> > > > > >> > > > > > > > > > > > >
> >> 2015-06-01 18:40 GMT+03:00 Atri
> > Sharma
> > > <
> > > > > >> > > > > > > atri.jiit@gmail.com
> > > > > >> > > > > > > > >:
> > > > > >> > > > > > > > > > > > >
> >>
> > > > > >> > > > > > > > > > > > >
> >> > Thanks Yakov.
> > > > > >> > > > > > > > > > > > >
> >> >
> > > > > >> > > > > > > > > > > > >
> >> > Can you also please advice at
> code
> > > > areas
> > > > > >> > where I
> > > > > >> > > > > > should
> > > > > >> > > > > > > > look
> > > > > >> > > > > > > > > > at
> > > > > >> > > > > > > > > > > > for
> > > > > >> > > > > > > > > > > > >
> this
> > > > > >> > > > > > > > > > > > >
> >> > please?
> > > > > >> > > > > > > > > > > > >
> >> >
> > > > > >> > > > > > > > > > > > >
> >> > On Mon, Jun 1, 2015 at 9:03 PM,
> > Yakov
> > > > > >> Zhdanov
> > > > > >> > <
> > > > > >> > > > > > > > > > > > yzhdanov@apache.org>
> > > > > >> > > > > > > > > > > > >
> >> wrote:
> > > > > >> > > > > > > > > > > > >
> >> >
> > > > > >> > > > > > > > > > > > >
> >> > > Arti you can read about sprint
> > > > process
> > > > > >> here
> > > > > >> > > > > > > > > > > > >
> >> > >
> > > > > >> > > > > > > > > > > >
> > > > > >> > > > > > >
> > > > > >> >
> > https://cwiki.apache.org/confluence/display/IGNITE/Sprint+Process
> > > > > >> > > > > > > > > > > > >
> >> > >
> > > > > >> > > > > > > > > > > > >
> >> > > This page will be soon updated
> > with
> > > > > >> > > information
> > > > > >> > > > on
> > > > > >> > > > > > how
> > > > > >> > > > > > > > to
> > > > > >> > > > > > > > > > > format
> > > > > >> > > > > > > > > > > > >
and
> > > > > >> > > > > > > > > > > > >
> >> > submit
> > > > > >> > > > > > > > > > > > >
> >> > > patch and check CI tests.
> > > > > >> > > > > > > > > > > > >
> >> > >
> > > > > >> > > > > > > > > > > > >
> >> > > --Yakov
> > > > > >> > > > > > > > > > > > >
> >> > >
> > > > > >> > > > > > > > > > > > >
> >> > > 2015-06-01 12:54 GMT+03:00 Atri
> > > > Sharma
> > > > > <
> > > > > >> > > > > > > > > atri.jiit@gmail.com
> > > > > >> > > > > > > > > > >:
> > > > > >> > > > > > > > > > > > >
> >> > >
> > > > > >> > > > > > > > > > > > >
> >> > > > I would like to work on 917,
> > have
> > > > > >> assigned
> > > > > >> > > it
> > > > > >> > > > to
> > > > > >> > > > > > > > myself.
> > > > > >> > > > > > > > > > > > >
> >> > > >
> > > > > >> > > > > > > > > > > > >
> >> > > > Please advice on the approach
> > and
> > > > > code
> > > > > >> > areas
> > > > > >> > > > > this
> > > > > >> > > > > > > > patch
> > > > > >> > > > > > > > > > will
> > > > > >> > > > > > > > > > > > >
need
> > > > > >> > > > > > > > > > > > >
> >> > > > modifications in.
> > > > > >> > > > > > > > > > > > >
> >> > > >
> > > > > >> > > > > > > > > > > > >
> >> > > > --
> > > > > >> > > > > > > > > > > > >
> >> > > > Regards,
> > > > > >> > > > > > > > > > > > >
> >> > > >
> > > > > >> > > > > > > > > > > > >
> >> > > > Atri
> > > > > >> > > > > > > > > > > > >
> >> > > > *l'apprenant*
> > > > > >> > > > > > > > > > > > >
> >> > > >
> > > > > >> > > > > > > > > > > > >
> >> > >
> > > > > >> > > > > > > > > > > > >
> >> >
> > > > > >> > > > > > > > > > > > >
> >> >
> > > > > >> > > > > > > > > > > > >
> >> >
> > > > > >> > > > > > > > > > > > >
> >> > --
> > > > > >> > > > > > > > > > > > >
> >> > Regards,
> > > > > >> > > > > > > > > > > > >
> >> >
> > > > > >> > > > > > > > > > > > >
> >> > Atri
> > > > > >> > > > > > > > > > > > >
> >> > *l'apprenant*
> > > > > >> > > > > > > > > > > > >
> >> >
> > > > > >> > > > > > > > > > > > >
> >>
> > > > > >> > > > > > > > > > > > >
> >
> > > > > >> > > > > > > > > > > > >
> >
> > > > > >> > > > > > > > > > > > >
> >
> > > > > >> > > > > > > > > > > > >
> > --
> > > > > >> > > > > > > > > > > > >
> > Regards,
> > > > > >> > > > > > > > > > > > >
> >
> > > > > >> > > > > > > > > > > > >
> > Atri
> > > > > >> > > > > > > > > > > > >
> > *l'apprenant*
> > > > > >> > > > > > > > > > > > >
> >
> > > > > >> > > > > > > > > > > > >
>
> > > > > >> > > > > > > > > > > > >
>
> > > > > >> > > > > > > > > > > > >
>
> > > > > >> > > > > > > > > > > > >
> --
> > > > > >> > > > > > > > > > > > >
> Regards,
> > > > > >> > > > > > > > > > > > >
>
> > > > > >> > > > > > > > > > > > >
> Atri
> > > > > >> > > > > > > > > > > > >
> *l'apprenant*
> > > > > >> > > > > > > > > > > > >
>
> > > > > >> > > > > > > > > > > > >
> > > > > >> > > > > > > > > > > >
> > > > > >> > > > > > > > > > >
> > > > > >> > > > > > > > > >
> > > > > >> > > > > > > > > >
> > > > > >> > > > > > > > > >
> > > > > >> > > > > > > > > > --
> > > > > >> > > > > > > > > > Regards,
> > > > > >> > > > > > > > > >
> > > > > >> > > > > > > > > > Atri
> > > > > >> > > > > > > > > > *l'apprenant*
> > > > > >> > > > > > > > > >
> > > > > >> > > > > > > > >
> > > > > >> > > > > > > >
> > > > > >> > > > > > > >
> > > > > >> > > > > > > >
> > > > > >> > > > > > > > --
> > > > > >> > > > > > > > Regards,
> > > > > >> > > > > > > >
> > > > > >> > > > > > > > Atri
> > > > > >> > > > > > > > *l'apprenant*
> > > > > >> > > > > > > >
> > > > > >> > > > > > >
> > > > > >> > > > > >
> > > > > >> > > > > >
> > > > > >> > > > > >
> > > > > >> > > > > > --
> > > > > >> > > > > > Regards,
> > > > > >> > > > > >
> > > > > >> > > > > > Atri
> > > > > >> > > > > > *l'apprenant*
> > > > > >> > > > > >
> > > > > >> > > > >
> > > > > >> > > >
> > > > > >> > > >
> > > > > >> > > >
> > > > > >> > > > --
> > > > > >> > > > Regards,
> > > > > >> > > >
> > > > > >> > > > Atri
> > > > > >> > > > *l'apprenant*
> > > > > >> > > >
> > > > > >> > >
> > > > > >> >
> > > > > >> >
> > > > > >> >
> > > > > >> > --
> > > > > >> > Regards,
> > > > > >> >
> > > > > >> > Atri
> > > > > >> > *l'apprenant*
> > > > > >> >
> > > > > >>
> > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Regards,
> > > > > >
> > > > > > Atri
> > > > > > *l'apprenant*
> > > > > >
> > > > >
> > > >
> > >
> > >
> > >
> > > --
> > > Regards,
> > >
> > > Atri
> > > *l'apprenant*
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message