ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Atri Sharma <atri.j...@gmail.com>
Subject Re: IGNITE 917
Date Mon, 08 Jun 2015 14:07:25 GMT
Can you advice on the test failures please? I have no idea of debugging the
plethora of tests but I suspect that the same fault in the patch is causing
them to fail...

On Mon, Jun 8, 2015 at 7:18 PM, Artiom Shutak <ashutak@gridgain.com> wrote:

> Atri, see my comments at Jira.
>
> I want to ask you to be more careful with all review comments (reread all
> above) and fix all of them.
>
> -- Artem --
>
> On Mon, Jun 8, 2015 at 1:49 PM, Atri Sharma <atri.jiit@gmail.com> wrote:
>
> > Fixed and attached.
> >
> > Please see and let me know your feedback and comments.
> >
> > On Fri, Jun 5, 2015 at 4:44 PM, Artiom Shutak <ashutak@gridgain.com>
> > wrote:
> >
> > > Hi Atri,
> > >
> > > See my new review in jira.
> > >
> > > -- Artem --
> > >
> > > On Fri, Jun 5, 2015 at 11:20 AM, Atri Sharma <atri.jiit@gmail.com>
> > wrote:
> > >
> > > > Artem,
> > > >
> > > > Thanks for your comments.
> > > >
> > > >
> > > > I incorporated your comments and sent new patch. Please see and
> > comment.
> > > >
> > > > Regards,
> > > >
> > > > Atri
> > > >
> > > > On Fri, Jun 5, 2015 at 3:22 AM, Artiom Shutak <ashutak@gridgain.com>
> > > > wrote:
> > > >
> > > > > Atri, please, see my comments at the Jira ticket.
> > > > >
> > > > > -- Artem --
> > > > >
> > > > > On Thu, Jun 4, 2015 at 7:44 PM, Atri Sharma <atri.jiit@gmail.com>
> > > wrote:
> > > > >
> > > > > > Thanks.
> > > > > >
> > > > > > Sorry for the noise on this one. I am off next week so it's
> helpful
> > > if
> > > > we
> > > > > > can close this by this week if possible. I am willing to work
in
> my
> > > > > > midnight for that if needed :)
> > > > > > On 4 Jun 2015 01:53, "Dmitriy Setrakyan" <dsetrakyan@apache.org>
> > > > wrote:
> > > > > >
> > > > > > > Atri,
> > > > > > >
> > > > > > > Thanks for providing a patch to Ignite! I am sure someone
in
> the
> > > > > > community
> > > > > > > will be looking into it shortly (if not already).
> > > > > > >
> > > > > > > Once your patch is accepted, you will be eligible to become
a
> > > > > committer.
> > > > > > >
> > > > > > > D.
> > > > > > >
> > > > > > > On Tue, Jun 2, 2015 at 7:03 AM, Atri Sharma <
> atri.jiit@gmail.com
> > >
> > > > > wrote:
> > > > > > >
> > > > > > > > Patch version 1 is available. Please see and comment.
> > > > > > > >
> > > > > > > > On Mon, Jun 1, 2015 at 9:18 PM, Atri Sharma <
> > atri.jiit@gmail.com
> > > >
> > > > > > wrote:
> > > > > > > >
> > > > > > > > > Thanks.
> > > > > > > > >
> > > > > > > > > On Mon, Jun 1, 2015 at 9:16 PM, Yakov Zhdanov
<
> > > > yzhdanov@apache.org
> > > > > >
> > > > > > > > wrote:
> > > > > > > > >
> > > > > > > > >> Did you see the comment in the ticket? Andrey
Gura has put
> > > some
> > > > > tips
> > > > > > > > >> there.
> > > > > > > > >> You can ask further questions in the ticket.
> > > > > > > > >>
> > > > > > > > >> Good luck!
> > > > > > > > >>
> > > > > > > > >> --Yakov
> > > > > > > > >>
> > > > > > > > >> 2015-06-01 18:40 GMT+03:00 Atri Sharma <
> atri.jiit@gmail.com
> > >:
> > > > > > > > >>
> > > > > > > > >> > Thanks Yakov.
> > > > > > > > >> >
> > > > > > > > >> > Can you also please advice at code areas
where I should
> > look
> > > > at
> > > > > > for
> > > > > > > > this
> > > > > > > > >> > please?
> > > > > > > > >> >
> > > > > > > > >> > On Mon, Jun 1, 2015 at 9:03 PM, Yakov
Zhdanov <
> > > > > > yzhdanov@apache.org>
> > > > > > > > >> wrote:
> > > > > > > > >> >
> > > > > > > > >> > > Arti you can read about sprint
process here
> > > > > > > > >> > >
> > > > > >
> https://cwiki.apache.org/confluence/display/IGNITE/Sprint+Process
> > > > > > > > >> > >
> > > > > > > > >> > > This page will be soon updated
with information on how
> > to
> > > > > format
> > > > > > > and
> > > > > > > > >> > submit
> > > > > > > > >> > > patch and check CI tests.
> > > > > > > > >> > >
> > > > > > > > >> > > --Yakov
> > > > > > > > >> > >
> > > > > > > > >> > > 2015-06-01 12:54 GMT+03:00 Atri
Sharma <
> > > atri.jiit@gmail.com
> > > > >:
> > > > > > > > >> > >
> > > > > > > > >> > > > I would like to work on 917,
have assigned it to
> > myself.
> > > > > > > > >> > > >
> > > > > > > > >> > > > Please advice on the approach
and code areas this
> > patch
> > > > will
> > > > > > > need
> > > > > > > > >> > > > modifications in.
> > > > > > > > >> > > >
> > > > > > > > >> > > > --
> > > > > > > > >> > > > Regards,
> > > > > > > > >> > > >
> > > > > > > > >> > > > Atri
> > > > > > > > >> > > > *l'apprenant*
> > > > > > > > >> > > >
> > > > > > > > >> > >
> > > > > > > > >> >
> > > > > > > > >> >
> > > > > > > > >> >
> > > > > > > > >> > --
> > > > > > > > >> > Regards,
> > > > > > > > >> >
> > > > > > > > >> > Atri
> > > > > > > > >> > *l'apprenant*
> > > > > > > > >> >
> > > > > > > > >>
> > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > --
> > > > > > > > > Regards,
> > > > > > > > >
> > > > > > > > > Atri
> > > > > > > > > *l'apprenant*
> > > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > --
> > > > > > > > Regards,
> > > > > > > >
> > > > > > > > Atri
> > > > > > > > *l'apprenant*
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > > >
> > > >
> > > > --
> > > > Regards,
> > > >
> > > > Atri
> > > > *l'apprenant*
> > > >
> > >
> >
> >
> >
> > --
> > Regards,
> >
> > Atri
> > *l'apprenant*
> >
>



-- 
Regards,

Atri
*l'apprenant*

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message