ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Atri Sharma <atri.j...@gmail.com>
Subject Re: IGNITE 1017
Date Fri, 26 Jun 2015 15:08:25 GMT
Super cool, thanks.

On Fri, Jun 26, 2015 at 8:37 PM, Artiom Shutak <ashutak@gridgain.com> wrote:

> Hi Atri,
>
> Yes, we are solved just change String on Object.
>
> This changes were pushed at sprint-7. You can see it now. I will close the
> ticket.
>
> Thanks for your contribution!
>
> -- Artem --
>
> On Fri, Jun 26, 2015 at 5:28 PM, Atri Sharma <atri.jiit@gmail.com> wrote:
>
> > Hi,
> >
> > Have we reached a conclusion for this please?
> > On 26 Jun 2015 00:09, "Atri Sharma" <atri.jiit@gmail.com> wrote:
> >
> > > If it's ok I can upload patch for it tomorrow
> > > On 25 Jun 2015 23:52, "Atri Sharma" <atri.jiit@gmail.com> wrote:
> > >
> > >> +1.
> > >>
> > >> I had that thought too since AttributeFilter's behaviour works with
> > >> Objects itself and not any specific datatype so it should be simple
> > matter
> > >> of changing current function's datatype to Object but thought not to
> > >> disturb the existing function.
> > >>
> > >> On Thu, Jun 25, 2015 at 11:04 PM, Artiom Shutak <ashutak@gridgain.com
> >
> > >> wrote:
> > >>
> > >>> Igniters,
> > >>>
> > >>> I've looked at patch. It is consistent with ticket description.
> > >>>
> > >>> But I see a problem with described in the task approach. From the
> task:
> > >>>
> > >>> Node attribute value can be an object of any type, but
> > >>> > ClusterGroup.forAttribute(..) method accepts only string as a
> value.
> > >>> > Need to add new public ClusterGroup forAttribute(String name,
> > @Nullable
> > >>> > Object val) method and deprecate the existing one
> > >>>
> > >>> In this case, all users who use forAttributes before will get
> > deprecated
> > >>> usages and will not be able to do anything with it (Actually all
> users,
> > >>> which will try to use forAttribute with String or null).
> > >>>
> > >>> I suggest just change type of value from String to Object and it will
> > be
> > >>> all fix.
> > >>>
> > >>> Valentin, as soon as the ticket was created by you, do you have any
> > >>> objections?
> > >>>
> > >>>
> > >>>
> > >>> -- Artem --
> > >>>
> > >>> On Wed, Jun 24, 2015 at 3:47 PM, Atri Sharma <atri.jiit@gmail.com>
> > >>> wrote:
> > >>>
> > >>> > Thank you so much!
> > >>> >
> > >>> > On Wed, Jun 24, 2015 at 6:16 PM, Artiom Shutak <
> ashutak@gridgain.com
> > >
> > >>> > wrote:
> > >>> >
> > >>> > > Atri, I will look at your patch at a couple of days.
> > >>> > >
> > >>> > > -- Artem --
> > >>> > >
> > >>> > > On Tue, Jun 23, 2015 at 4:35 PM, Atri Sharma <
> atri.jiit@gmail.com>
> > >>> > wrote:
> > >>> > >
> > >>> > > > Patch is available.
> > >>> > > > Please seen and let me know your comments.
> > >>> > > >
> > >>> > > > On Fri, Jun 19, 2015 at 12:33 AM, Atri Sharma <
> > atri.jiit@gmail.com
> > >>> >
> > >>> > > wrote:
> > >>> > > >
> > >>> > > > > Thanks,
> > >>> > > > >
> > >>> > > > > That is what I was intending to do actually, sorry
if it
> didn't
> > >>> come
> > >>> > > > > across clearly.
> > >>> > > > >
> > >>> > > > > I will work on the ticket and ask if I have any
questions.
> > >>> > > > >
> > >>> > > > > Thanks Brane, Dmitriy!
> > >>> > > > >
> > >>> > > > > On Fri, Jun 19, 2015 at 12:30 AM, Dmitriy Setrakyan
<
> > >>> > > > dsetrakyan@apache.org
> > >>> > > > > > wrote:
> > >>> > > > >
> > >>> > > > >> Agree with Brane, no need to ask. However,
if you would like
> > to
> > >>> let
> > >>> > us
> > >>> > > > >> know
> > >>> > > > >> that you have grabbed that ticket or have any
questions,
> this
> > >>> dev
> > >>> > list
> > >>> > > > is
> > >>> > > > >> a
> > >>> > > > >> good place for it.
> > >>> > > > >>
> > >>> > > > >> D.
> > >>> > > > >>
> > >>> > > > >> On Thu, Jun 18, 2015 at 10:46 AM, Branko ─îibej
<
> > >>> brane@apache.org>
> > >>> > > > wrote:
> > >>> > > > >>
> > >>> > > > >> > On 18.06.2015 19:36, Atri Sharma wrote:
> > >>> > > > >> > > Folks,
> > >>> > > > >> > >
> > >>> > > > >> > > Would like to take 1017. Please confirm
if I can go
> ahead
> > >>> and
> > >>> > > advise
> > >>> > > > >> on
> > >>> > > > >> > > implementation.
> > >>> > > > >> >
> > >>> > > > >> > You really don't have to ask, just go
ahead, grab the
> issue
> > >>> and
> > >>> > > start
> > >>> > > > >> > coding.
> > >>> > > > >> >
> > >>> > > > >> > -- Brane
> > >>> > > > >> >
> > >>> > > > >>
> > >>> > > > >
> > >>> > > > >
> > >>> > > > >
> > >>> > > > > --
> > >>> > > > > Regards,
> > >>> > > > >
> > >>> > > > > Atri
> > >>> > > > > *l'apprenant*
> > >>> > > > >
> > >>> > > >
> > >>> > > >
> > >>> > > >
> > >>> > > > --
> > >>> > > > Regards,
> > >>> > > >
> > >>> > > > Atri
> > >>> > > > *l'apprenant*
> > >>> > > >
> > >>> > >
> > >>> >
> > >>> >
> > >>> >
> > >>> > --
> > >>> > Regards,
> > >>> >
> > >>> > Atri
> > >>> > *l'apprenant*
> > >>> >
> > >>>
> > >>
> > >>
> > >>
> > >> --
> > >> Regards,
> > >>
> > >> Atri
> > >> *l'apprenant*
> > >>
> > >
> >
>



-- 
Regards,

Atri
*l'apprenant*

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message