ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Atri Sharma <atri.j...@gmail.com>
Subject Re: IGNITE 1006
Date Thu, 25 Jun 2015 19:03:42 GMT
Hi,

Sorry to bug about this. Is there any chance we can get this in sprint 7
please?

Please see and let me know your comments.
On 25 Jun 2015 14:19, "Atri Sharma" <atri.jiit@gmail.com> wrote:

> Hi,
>
> I have uploaded next version of patch on ticket.
>
> Please see and let me know your comments and feedback.
>
> Regards,
>
> Atri
>
> On Wed, Jun 24, 2015 at 5:48 PM, Atri Sharma <atri.jiit@gmail.com> wrote:
>
>> Thanks.
>>
>> Let me work and revert.
>>
>> On Wed, Jun 24, 2015 at 5:44 PM, Artiom Shutak <ashutak@gridgain.com>
>> wrote:
>>
>>> Hi Atri, see my comments at Jira.
>>>
>>> -- Artem --
>>>
>>> On Wed, Jun 24, 2015 at 1:15 PM, Atri Sharma <atri.jiit@gmail.com>
>>> wrote:
>>>
>>> > Hi Artem,
>>> >
>>> >
>>> > Please let me know your comments on this so I can fix it ASAP.
>>> >
>>> > Thanks and Regards,
>>> >
>>> > Atri
>>> >
>>> > On Tue, Jun 23, 2015 at 5:08 PM, Atri Sharma <atri.jiit@gmail.com>
>>> wrote:
>>> >
>>> > > Thanks for your comments.
>>> > >
>>> > > I am not sure if I understood your comments correctly.
>>> > >
>>> > > For your concern about not reusing ClusterGroupAdapter#nodes, I
>>> mentioned
>>> > > that I cannot see a clear mechanism of reusing existing nodes()
>>> (without
>>> > > major refactoring of ClusterGroupAdapter#nodes which I try to avoid
>>> since
>>> > > ClusterGroupAdapter#nodes is a heavily used method). If there is a
>>> > method I
>>> > > missed, please let me know.
>>> > >
>>> > > For the tests, test I added gets all the hostnames for test cluster
>>> using
>>> > > new method, gets localnode's hostnames and tests if all of
>>> localnode's
>>> > > hostnames are present in hostnames result returned by hostNames()
>>> > method. I
>>> > > did not understand your concern around it (is it that test cluster
>>> might
>>> > > have single node)? Please elaborate a bit.
>>> > >
>>> > > Thanks!
>>> > >
>>> > > On Tue, Jun 23, 2015 at 4:54 PM, Artiom Shutak <ashutak@gridgain.com
>>> >
>>> > > wrote:
>>> > >
>>> > >> See my comments for test at jira.
>>> > >>
>>> > >> In future, can you please fix all comments before giving new patch
>>> for
>>> > >> review?
>>> > >>
>>> > >> -- Artem --
>>> > >>
>>> > >> On Tue, Jun 23, 2015 at 12:50 PM, Atri Sharma <atri.jiit@gmail.com>
>>> > >> wrote:
>>> > >>
>>> > >> > Added tests.
>>> > >> >
>>> > >> > Please see and let me know your feedback and comments.
>>> > >> >
>>> > >> > On Mon, Jun 22, 2015 at 4:09 PM, Artiom Shutak <
>>> ashutak@gridgain.com>
>>> > >> > wrote:
>>> > >> >
>>> > >> > > Hi, see my comments at jira.
>>> > >> > >
>>> > >> > > -- Artem --
>>> > >> > >
>>> > >> > > On Fri, Jun 19, 2015 at 6:43 PM, Atri Sharma <
>>> atri.jiit@gmail.com>
>>> > >> > wrote:
>>> > >> > >
>>> > >> > > > Folks,
>>> > >> > > >
>>> > >> > > > I request to please have a look AT IGNITE 1006.
It has been
>>> ready
>>> > >> for a
>>> > >> > > > while.
>>> > >> > > >
>>> > >> > > > Please let me know if anything is needed.
>>> > >> > > >
>>> > >> > >
>>> > >> >
>>> > >> >
>>> > >> >
>>> > >> > --
>>> > >> > Regards,
>>> > >> >
>>> > >> > Atri
>>> > >> > *l'apprenant*
>>> > >> >
>>> > >>
>>> > >
>>> > >
>>> > >
>>> > > --
>>> > > Regards,
>>> > >
>>> > > Atri
>>> > > *l'apprenant*
>>> > >
>>> >
>>> >
>>> >
>>> > --
>>> > Regards,
>>> >
>>> > Atri
>>> > *l'apprenant*
>>> >
>>>
>>
>>
>>
>> --
>> Regards,
>>
>> Atri
>> *l'apprenant*
>>
>
>
>
> --
> Regards,
>
> Atri
> *l'apprenant*
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message