Return-Path: X-Original-To: apmail-ignite-dev-archive@minotaur.apache.org Delivered-To: apmail-ignite-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A4B14188C4 for ; Sat, 9 May 2015 00:45:34 +0000 (UTC) Received: (qmail 52754 invoked by uid 500); 9 May 2015 00:45:34 -0000 Delivered-To: apmail-ignite-dev-archive@ignite.apache.org Received: (qmail 52725 invoked by uid 500); 9 May 2015 00:45:34 -0000 Mailing-List: contact dev-help@ignite.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.incubator.apache.org Delivered-To: mailing list dev@ignite.incubator.apache.org Received: (qmail 52713 invoked by uid 99); 9 May 2015 00:45:34 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 09 May 2015 00:45:34 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id CB47FC2B7D for ; Sat, 9 May 2015 00:45:33 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.898 X-Spam-Level: ** X-Spam-Status: No, score=2.898 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=3, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-us-east.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id iJc2FBLA_gKD for ; Sat, 9 May 2015 00:45:33 +0000 (UTC) Received: from mail-ig0-f175.google.com (mail-ig0-f175.google.com [209.85.213.175]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with ESMTPS id 2530642989 for ; Sat, 9 May 2015 00:45:33 +0000 (UTC) Received: by iget9 with SMTP id t9so40586622ige.1 for ; Fri, 08 May 2015 17:45:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=5QV0hjkxO9/L6emzryGblQUZpMF+6aOXGZgkP3c98qg=; b=Z/QtrjKMnrQXWKPYciuu2tFd2ymWmMcZkKVxmM86YWtimMlJ3IqY7APEzE30a0inLL l2/uL8HNm1HMPwE5A8/G74X5v+wbrSo48JiDIBJJytbx8AFJvXdI8mflCICXYYSK4a4G nKiKjCc+uIVA8q5rEWBXLQuEv0O4NpGwlRopGL1nxdB3lFhKhqRlPgUPPUMMWG5kBqvf cqcqlyzKJ+o3oWnojm8ybR/gIj+/ZC8qTlBVsTIJqKDF+AR4zeoCEZ65YOqKPSyIzIn6 XNAjSZgGut/490NWd6wU9++RxSN47wQjzbiUYL+JyKXKnxnIbt/Uo25JYMiS6Ju/E8b/ yWYA== MIME-Version: 1.0 X-Received: by 10.107.6.84 with SMTP id 81mr791507iog.52.1431132332803; Fri, 08 May 2015 17:45:32 -0700 (PDT) Received: by 10.107.155.80 with HTTP; Fri, 8 May 2015 17:45:32 -0700 (PDT) Date: Fri, 8 May 2015 17:45:32 -0700 Message-ID: Subject: Configuration inconsistency From: Valentin Kulichenko To: dev@ignite.incubator.apache.org Content-Type: multipart/alternative; boundary=001a113ed7d252ce0105159b7614 --001a113ed7d252ce0105159b7614 Content-Type: text/plain; charset=UTF-8 Guys, I noticed that some entities on cache configuration are configured via factories, while others are set directly. For example, we use factory for ExpiryPolicy, but not for EvictionPolicy, which looks inconsistent. Since factory-based approach comes from JCache, I think we should use it wherever possible. Here is the list of settings that need to be fixed (I checked only cache config): - Affinity - AffinityMapper - EvictionFilter - EvictionPolicy - CacheInterceptor - TopologyValidator Agree? -- Val --001a113ed7d252ce0105159b7614--