Mailing-List: contact dev-help@ignite.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ignite.incubator.apache.org
Date: Wed, 13 May 2015 13:40:47 -0700
From: Konstantin Boudnik <cos@apache.org>
To: dev@ignite.incubator.apache.org
Subject: Release tag ignite-1.1.0-incubating-rc5
Message-ID: <20150513204046.GD28615@boudnik.org>
Mail-Followup-To: dev@ignite.incubator.apache.org
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
User-Agent: Mutt/1.5.21 (2010-09-15)

I've been pocking around the latest release candidate and here's a couple of
issues I see:
 - version change commit message has missing closing double quote, e.g. the
   message says 
     "Version changed
   which is an indication that something is wrong with the script that invokes mvn release 
 - bin/ignite.sh line 61 has this

. "${SCRIPTS_HOME}"/include/build-classpath.sh # Will be removed in release.

   which means that release's zip file will contain different scripts than
   that of the release tag, right? And there's a whole bunch of other
   massaging that's done to the scripts and pom during the package phase of
   release process. While binaries (aka packages) aren't of any concern to the
   Apache, the practice does look quite funky to me. Is there guarantee that
   published release pom will be _exactly_ the same as the one in source code?

Thanks,
  Cos