Return-Path: X-Original-To: apmail-ignite-dev-archive@minotaur.apache.org Delivered-To: apmail-ignite-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F01A117D39 for ; Fri, 13 Mar 2015 01:02:24 +0000 (UTC) Received: (qmail 91813 invoked by uid 500); 13 Mar 2015 01:02:24 -0000 Delivered-To: apmail-ignite-dev-archive@ignite.apache.org Received: (qmail 91767 invoked by uid 500); 13 Mar 2015 01:02:24 -0000 Mailing-List: contact dev-help@ignite.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.incubator.apache.org Delivered-To: mailing list dev@ignite.incubator.apache.org Received: (qmail 91755 invoked by uid 99); 13 Mar 2015 01:02:24 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Mar 2015 01:02:24 +0000 X-ASF-Spam-Status: No, hits=0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE X-Spam-Check-By: apache.org Received-SPF: error (athena.apache.org: local policy) Received: from [69.252.207.40] (HELO resqmta-ch2-08v.sys.comcast.net) (69.252.207.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Mar 2015 01:02:17 +0000 Received: from resomta-ch2-11v.sys.comcast.net ([69.252.207.107]) by resqmta-ch2-08v.sys.comcast.net with comcast id 2p0c1q0012Ka2Q501p0chr; Fri, 13 Mar 2015 01:00:36 +0000 Received: from tinybb.boudnik.org ([24.130.135.131]) by resomta-ch2-11v.sys.comcast.net with comcast id 2p0b1q00f2qGB6001p0cLA; Fri, 13 Mar 2015 01:00:36 +0000 Received: by tinybb.boudnik.org (Postfix, from userid 1002) id 884331F7; Fri, 13 Mar 2015 01:01:30 +0000 (UTC) Date: Fri, 13 Mar 2015 01:01:30 +0000 From: Konstantin Boudnik To: dev@ignite.incubator.apache.org Subject: Re: maven builds Message-ID: <20150313010130.GQ1657@boudnik.org> References: <20150313002342.GP1657@boudnik.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Organization: It's something of 'Cos User-Agent: Mutt/1.5.21 (2010-09-15) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20140121; t=1426208436; bh=JYJ5lqmLzVOfGt+MZbs9wAUGT9CIXBohKZegJqgb7Sk=; h=Received:Received:Received:Date:From:To:Subject:Message-ID: MIME-Version:Content-Type; b=n1DiPYQ+hSIUyLSe0BbXqbmCyzDPhr+ZATfJokokeSjXsUtshEZNamALvH4vO17Th 2Om5MJjXLJynGn/Ji6xZ0qtwvRBftryF8cQ+TQ//MnPDqGlWq0c2NHHkxwQDAxj1/4 UMMjUR0ZN8DaG9N35Og7swcd9q5PJFg/kxugwqUdMODuv/OecSw+p63CsoJGzS0pGk V1sJ/yaQ08KEQP/kYbyxTCcqE54LM65hx56m9uMm307rjeS63vyEIjPsC1nwM7qZoi 6B957+0MPB8TelUmJtxiz4+6DeuEtePKIRxr0a2b7DH7uYqogfR8yqobETZ5eor82C 9gH/MgFLffIyA== X-Virus-Checked: Checked by ClamAV on apache.org Ah, I see. Yes, I think a better way to go from a pure Maven perspective is to bind this sort of generation to assembly step perhaps. Cause 'package' is expected to produce jar files. What you do with them afterwards - isn't a 'package' business, IMO. On Thu, Mar 12, 2015 at 05:36PM, Dmitriy Setrakyan wrote: > It is OK for "mvn package" to generate JAR files. However, in case of > Ignite, it also generates the release binary ZIP archive which actually > requires that you are in the root of a valid Ignite GIT tree. I would > rather have the release ZIP file generated with an additional option added > to the "mvn" command. > > D. > > On Thu, Mar 12, 2015 at 5:23 PM, Konstantin Boudnik wrote: > > > I think package is by default bound to the binary generation, so it > > would'be > > pretty messy if you'll try to break this dependency. > > > > Cos > > > > On Thu, Mar 12, 2015 at 04:38PM, Dmitriy Setrakyan wrote: > > > Igniters, > > > > > > Based on the latest feedback from the mentors, I think we need to make > > sure > > > that standard "mvn clean package -DskipTests" command can run > > successfully > > > by default. This means that that this command should not generate a > > binary > > > build by default. > > > > > > It is OK to add extra parameters when doing the binary build though. > > > > > > How hard would it be to implement this change? > > > > > > D. > >