Mailing-List: contact dev-help@ignite.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ignite.incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of vozerov@gridgain.com
 designates 209.85.192.47 as permitted sender)
MIME-Version: 1.0
Date: Wed, 4 Feb 2015 12:40:29 +0300
Message-ID: 
 <CAGt6o8n0wtOi2aiznfyRxUqNdeLGYb6Qog4XJK1yr=P5md397w@mail.gmail.com>
Subject: "executorServiceShutdown" properties concept review.
From: Vladimir Ozerov <vozerov@gridgain.com>
To: dev@ignite.incubator.apache.org
Content-Type: multipart/alternative; boundary=001a1133d99659013a050e3ffa66

--001a1133d99659013a050e3ffa66
Content-Type: text/plain; charset=UTF-8

Hi,

I'd like to start the discussion about infamous "shutdown" properties in
configuration classes:

   - IgniteConfiguration.executorServiceShutdown()
   - IgniteConfiguration.ggfsExecutorServiceShutdown()
   - IgniteConfiguration.managementExecutorServiceShutdown()
   - IgniteConfiguration.peerClassLoadingExecutorServiceShutdown()
   - IgniteConfiguration.systemExecutorServiceShutdown()
   - IgniteConfiguration.restExecutorServiceShutdown()
   - ClientConnectionConfiguration.restExecutorServiceShutdown()

This yields in 12 additional methods in IgniteConfiguration and 2 in
ClientConnectionConfiguration.
Reason why we have these properties is clear: if you starts Ignite in
embedded mode and provides his own thread pool, he may want to keep it
running even after Ignite node is stopped.

On the other hand, it seems to me that custom executor service is pretty
unusal and rare use case.

What if we create wrapper class encapsulating both executor service and
shutdown flag? E.g.:
IgniteExecutorServiceConfiguration {
    ExecutorService getExecutorService();
    bool isExecutorServiceShutdown();
}

This will remove 6 properties. +19 deprecated client-related properties
which are also will be removed. In summary, we will be able to remove 25
properties (of 103 currently) from IgniteConfiguration.

Any thoughts on this?

Vladimir.

--001a1133d99659013a050e3ffa66--