ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Konstantin Boudnik <...@apache.org>
Subject Re: Fwd: patches in GIT
Date Thu, 19 Feb 2015 06:43:20 GMT
Perhaps it's not my place to say, but I never seen anything good coming out of
such gigantic patches.

Cos

On Wed, Feb 18, 2015 at 12:51PM, Dmitriy Setrakyan wrote:
> I think some folks have been struggling applying large (over 1MB in size)
> patches. Can you share what kind of issues you were experiencing?
> 
> D.
> 
> On Wed, Feb 18, 2015 at 10:37 AM, Konstantin Boudnik <cos@apache.org> wrote:
> 
> > I think it doesn't matter if you have a script or else, but it all boils
> > down
> > to the format of the patch you'll be attaching to JIRA for further
> > automatic
> > validation. And that's what Dmitriy is suggesting, IMO
> >
> > Cos
> >
> > On Wed, Feb 18, 2015 at 07:03PM, Sergi Vladykin wrote:
> > > I would prefer having scripts which will generate or apply patches
> > > correctly for me.
> > >
> > > Sergi
> > >
> > > 2015-02-10 7:36 GMT+03:00 Konstantin Boudnik <cos@apache.org>:
> > >
> > > > On Mon, Feb 09, 2015 at 07:27PM, Dmitriy Setrakyan wrote:
> > > > > Nice blog on how to create patches in GIT:
> > > > >
> > https://ariejan.net/2009/10/26/how-to-create-and-apply-a-patch-with-git/
> > > > >
> > > > > To create a patch:
> > > > > *git format-patch sprint-1 --stdout > mychanges.patch*
> > > >
> > > > You might need to specify the range of the commits you want to
> > generate the
> > > > patches for. E.g.
> > > >     git format-patch sprint-1 HEAD~1
> > > > to produce formatted patch just for single commit
> > > >
> > > > And yes - it's a good idea esp. for automated bot that needs to apply
a
> > > > patch
> > > > automatically.
> > > >
> > > > Cos
> > > >
> > > > >
> > > > > To check a patch (before applying):
> > > > > *git apply --check mychanges.patch*
> > > > >
> > > > > To apply a patch:
> > > > > *git am --signoff < mychanges.patch*
> > > > >
> > > > > Let's use these commands to attach patches to Jira tickets.
> > > > >
> > > > > D.
> > > >
> >

Mime
View raw message