ignite-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ipavluk...@apache.org
Subject [ignite] branch master updated: IGNITE-11888: Fix CacheContinuousQueryAsyncFailoverAtomicSelfTest.testFailoverStartStopBackup - Fixes #6583.
Date Sun, 02 Jun 2019 18:36:56 GMT
This is an automated email from the ASF dual-hosted git repository.

ipavlukhin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ignite.git


The following commit(s) were added to refs/heads/master by this push:
     new 8cc8b6e  IGNITE-11888: Fix CacheContinuousQueryAsyncFailoverAtomicSelfTest.testFailoverStartStopBackup
- Fixes #6583.
8cc8b6e is described below

commit 8cc8b6e2e92631388e3e4acc958923a958a821f4
Author: pavlukhin <vololo100@gmail.com>
AuthorDate: Sun Jun 2 21:36:05 2019 +0300

    IGNITE-11888: Fix CacheContinuousQueryAsyncFailoverAtomicSelfTest.testFailoverStartStopBackup
- Fixes #6583.
    
    Signed-off-by: ipavlukhin <vololo100@gmail.com>
---
 .../CacheContinuousQueryFailoverAbstractSelfTest.java     | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/query/continuous/CacheContinuousQueryFailoverAbstractSelfTest.java
b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/query/continuous/CacheContinuousQueryFailoverAbstractSelfTest.java
index 0769c3f..30b2b22 100644
--- a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/query/continuous/CacheContinuousQueryFailoverAbstractSelfTest.java
+++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/query/continuous/CacheContinuousQueryFailoverAbstractSelfTest.java
@@ -1753,11 +1753,22 @@ public abstract class CacheContinuousQueryFailoverAbstractSelfTest
extends GridC
                 if (System.currentTimeMillis() > startFilterTime) {
                     // Stop filter and check events.
                     if (dinQry != null) {
-                        dinQry.close();
+                        // If sync callback is used then we can close a query before checking
notifications
+                        // because CQ listeners on a server side have a pending notification
upon each
+                        // successfull cache update operations completion.
+                        if (!asyncCallback())
+                            dinQry.close();
 
-                        log.info("Continuous query listener closed. Await events: " + expEvtsNewLsnr.size());
+                        log.info("Await events: " + expEvtsNewLsnr.size());
 
                         checkEvents(expEvtsNewLsnr, dinLsnr, backups == 0);
+
+                        // If async callback is used and we close a query before checking
notifications then
+                        // some updates can be missed because a callback submitted in parallel
can be executed
+                        // after CQ is closed and no notification will be sent as a result.
+                        // So, we close CQ after the check.
+                        if (asyncCallback())
+                            dinQry.close();
                     }
 
                     dinLsnr = new CacheEventListener2();


Mime
View raw message