ignite-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dpav...@apache.org
Subject [ignite-teamcity-bot] 01/02: IGNITE-10540 Compare builds page with Internal Server Error 500. - Fixes #87.
Date Wed, 05 Dec 2018 12:39:18 GMT
This is an automated email from the ASF dual-hosted git repository.

dpavlov pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ignite-teamcity-bot.git

commit 550a96f373c2ce6cf5159ef856f6cd395ba96ab5
Author: Дмитрий Рябов <SomeFireOne@gmail.com>
AuthorDate: Wed Dec 5 15:38:55 2018 +0300

    IGNITE-10540 Compare builds page with Internal Server Error 500. - Fixes #87.
    
    Signed-off-by: Dmitriy Pavlov <dpavlov@apache.org>
---
 .../org/apache/ignite/ci/tcbot/builds/CompareBuildsService.java  | 9 +++++++--
 .../java/org/apache/ignite/ci/web/rest/build/CompareBuilds.java  | 2 +-
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/tcbot/builds/CompareBuildsService.java
b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/tcbot/builds/CompareBuildsService.java
index e420ca4..8ca0b24 100644
--- a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/tcbot/builds/CompareBuildsService.java
+++ b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/tcbot/builds/CompareBuildsService.java
@@ -40,12 +40,17 @@ public class CompareBuildsService {
     private static final Logger logger = LoggerFactory.getLogger(CompareBuildsService.class);
 
     @Inject ITcServerProvider helper;
-    @Inject ICredentialsProv prov;
     @Inject BuildChainProcessor bcp;
     @Inject ITeamcityIgnitedProvider tcIgnitedProv;
     @Inject IStringCompactor compactor;
 
-    public List<String> tests0(String srvId, Integer buildId ) {
+    /**
+     * @param srvId Server id.
+     * @param buildId Build id.
+     * @param prov Credentials provider.
+     * @return List of build tests.
+     */
+    public List<String> tests0(String srvId, Integer buildId, ICredentialsProv prov
) {
         IAnalyticsEnabledTeamcity teamcity = helper.server(srvId, prov);
 
         String hrefById = teamcity.getBuildHrefById(buildId);
diff --git a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/rest/build/CompareBuilds.java
b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/rest/build/CompareBuilds.java
index e46ce5a..87db6cf 100644
--- a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/rest/build/CompareBuilds.java
+++ b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/rest/build/CompareBuilds.java
@@ -123,6 +123,6 @@ public class CompareBuilds {
         if (!prov.hasAccess(srv))
             throw ServiceUnauthorizedException.noCreds(srv);
 
-        return compareBuildsSvc.tests0(srv, buildId);
+        return compareBuildsSvc.tests0(srv, buildId, prov);
     }
 }


Mime
View raw message