From commits-return-121558-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Fri Nov 2 10:35:03 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 11EC81807AA for ; Fri, 2 Nov 2018 10:34:58 +0100 (CET) Received: (qmail 97993 invoked by uid 500); 2 Nov 2018 09:34:58 -0000 Mailing-List: contact commits-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list commits@ignite.apache.org Received: (qmail 97781 invoked by uid 99); 2 Nov 2018 09:34:58 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Nov 2018 09:34:58 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 476BDE1121; Fri, 2 Nov 2018 09:34:57 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: nizhikov@apache.org To: commits@ignite.apache.org Date: Fri, 02 Nov 2018 09:35:07 -0000 Message-Id: <1418d32cbb2f4fdc97751a9462ec26ec@git.apache.org> In-Reply-To: References: X-Mailer: ASF-Git Admin Mailer Subject: [11/12] ignite git commit: IGNITE-9312: Remove unnecessary @SuppressWarnings annotation - Fixes #4632. http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcAbstractDmlStatementSelfTest.java ---------------------------------------------------------------------- diff --git a/modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcAbstractDmlStatementSelfTest.java b/modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcAbstractDmlStatementSelfTest.java index 1cc5740..636a717 100644 --- a/modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcAbstractDmlStatementSelfTest.java +++ b/modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcAbstractDmlStatementSelfTest.java @@ -189,7 +189,6 @@ public abstract class JdbcAbstractDmlStatementSelfTest extends GridCommonAbstrac /** * Person. */ - @SuppressWarnings("UnusedDeclaration") static class Person implements Serializable { /** ID. */ @QuerySqlField http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcBulkLoadSelfTest.java ---------------------------------------------------------------------- diff --git a/modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcBulkLoadSelfTest.java b/modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcBulkLoadSelfTest.java index 753a98c..f6958ab 100644 --- a/modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcBulkLoadSelfTest.java +++ b/modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcBulkLoadSelfTest.java @@ -142,7 +142,6 @@ public class JdbcBulkLoadSelfTest extends GridCommonAbstractTest { /** * A test class for creating a query entity. */ - @SuppressWarnings("UnusedDeclaration") private static class Person implements Serializable { /** ID. */ @QuerySqlField http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcComplexQuerySelfTest.java ---------------------------------------------------------------------- diff --git a/modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcComplexQuerySelfTest.java b/modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcComplexQuerySelfTest.java index 8b1390e..62b3840 100644 --- a/modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcComplexQuerySelfTest.java +++ b/modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcComplexQuerySelfTest.java @@ -265,7 +265,6 @@ public class JdbcComplexQuerySelfTest extends GridCommonAbstractTest { /** * Person. */ - @SuppressWarnings("UnusedDeclaration") private static class Person implements Serializable { /** ID. */ @QuerySqlField @@ -304,7 +303,6 @@ public class JdbcComplexQuerySelfTest extends GridCommonAbstractTest { /** * Organization. */ - @SuppressWarnings("UnusedDeclaration") private static class Organization implements Serializable { /** ID. */ @QuerySqlField http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcDistributedJoinsQueryTest.java ---------------------------------------------------------------------- diff --git a/modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcDistributedJoinsQueryTest.java b/modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcDistributedJoinsQueryTest.java index 2a58e02..bcf6159 100644 --- a/modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcDistributedJoinsQueryTest.java +++ b/modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcDistributedJoinsQueryTest.java @@ -250,7 +250,6 @@ public class JdbcDistributedJoinsQueryTest extends GridCommonAbstractTest { /** * Person. */ - @SuppressWarnings("UnusedDeclaration") private static class Person implements Serializable { /** ID. */ @QuerySqlField @@ -289,7 +288,6 @@ public class JdbcDistributedJoinsQueryTest extends GridCommonAbstractTest { /** * Organization. */ - @SuppressWarnings("UnusedDeclaration") private static class Organization implements Serializable { /** ID. */ @QuerySqlField http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcMetadataSelfTest.java ---------------------------------------------------------------------- diff --git a/modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcMetadataSelfTest.java b/modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcMetadataSelfTest.java index c3d0824..a1c36e1 100755 --- a/modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcMetadataSelfTest.java +++ b/modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcMetadataSelfTest.java @@ -433,7 +433,6 @@ public class JdbcMetadataSelfTest extends GridCommonAbstractTest { /** * Person. */ - @SuppressWarnings("UnusedDeclaration") private static class Person implements Serializable { /** Name. */ @QuerySqlField(index = false) @@ -466,7 +465,6 @@ public class JdbcMetadataSelfTest extends GridCommonAbstractTest { /** * Organization. */ - @SuppressWarnings("UnusedDeclaration") private static class Organization implements Serializable { /** ID. */ @QuerySqlField http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcPreparedStatementSelfTest.java ---------------------------------------------------------------------- diff --git a/modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcPreparedStatementSelfTest.java b/modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcPreparedStatementSelfTest.java index 0a48961..b6afc94 100644 --- a/modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcPreparedStatementSelfTest.java +++ b/modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcPreparedStatementSelfTest.java @@ -748,7 +748,6 @@ public class JdbcPreparedStatementSelfTest extends GridCommonAbstractTest { /** * Test object. */ - @SuppressWarnings("UnusedDeclaration") private static class TestObject implements Serializable { /** */ @QuerySqlField(index = false) http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcResultSetSelfTest.java ---------------------------------------------------------------------- diff --git a/modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcResultSetSelfTest.java b/modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcResultSetSelfTest.java index bd73bcd..486af7f 100644 --- a/modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcResultSetSelfTest.java +++ b/modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcResultSetSelfTest.java @@ -908,7 +908,6 @@ public class JdbcResultSetSelfTest extends GridCommonAbstractTest { /** * Test object. */ - @SuppressWarnings("UnusedDeclaration") private static class BaseTestObject implements Serializable { /** */ @QuerySqlField(index = false) @@ -931,7 +930,6 @@ public class JdbcResultSetSelfTest extends GridCommonAbstractTest { /** * Test object. */ - @SuppressWarnings("UnusedDeclaration") private static class TestObject extends BaseTestObject { /** */ @QuerySqlField http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcStatementSelfTest.java ---------------------------------------------------------------------- diff --git a/modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcStatementSelfTest.java b/modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcStatementSelfTest.java index f778fde..2762b53 100644 --- a/modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcStatementSelfTest.java +++ b/modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcStatementSelfTest.java @@ -375,7 +375,6 @@ public class JdbcStatementSelfTest extends GridCommonAbstractTest { /** * Person. */ - @SuppressWarnings("UnusedDeclaration") private static class Person implements Serializable { /** ID. */ @QuerySqlField http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/clients/src/test/java/org/apache/ignite/internal/processors/rest/RestMemcacheProtocolSelfTest.java ---------------------------------------------------------------------- diff --git a/modules/clients/src/test/java/org/apache/ignite/internal/processors/rest/RestMemcacheProtocolSelfTest.java b/modules/clients/src/test/java/org/apache/ignite/internal/processors/rest/RestMemcacheProtocolSelfTest.java index c2d4681..8b6c2bf 100644 --- a/modules/clients/src/test/java/org/apache/ignite/internal/processors/rest/RestMemcacheProtocolSelfTest.java +++ b/modules/clients/src/test/java/org/apache/ignite/internal/processors/rest/RestMemcacheProtocolSelfTest.java @@ -35,7 +35,6 @@ import static org.apache.ignite.cache.CacheWriteSynchronizationMode.FULL_SYNC; /** * TCP protocol test. */ -@SuppressWarnings("unchecked") public class RestMemcacheProtocolSelfTest extends GridCommonAbstractTest { /** */ private static final TcpDiscoveryIpFinder IP_FINDER = new TcpDiscoveryVmIpFinder(true); http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/clients/src/test/java/org/apache/ignite/internal/processors/rest/TestBinaryClient.java ---------------------------------------------------------------------- diff --git a/modules/clients/src/test/java/org/apache/ignite/internal/processors/rest/TestBinaryClient.java b/modules/clients/src/test/java/org/apache/ignite/internal/processors/rest/TestBinaryClient.java index badfd64..49ea1ce 100644 --- a/modules/clients/src/test/java/org/apache/ignite/internal/processors/rest/TestBinaryClient.java +++ b/modules/clients/src/test/java/org/apache/ignite/internal/processors/rest/TestBinaryClient.java @@ -134,7 +134,6 @@ final class TestBinaryClient { // Start socket reader thread. rdr = new Thread(new Runnable() { - @SuppressWarnings("InfiniteLoopStatement") @Override public void run() { try { ByteArrayOutputStream buf = new ByteArrayOutputStream(); http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/clients/src/test/java/org/apache/ignite/internal/processors/rest/TestMemcacheClient.java ---------------------------------------------------------------------- diff --git a/modules/clients/src/test/java/org/apache/ignite/internal/processors/rest/TestMemcacheClient.java b/modules/clients/src/test/java/org/apache/ignite/internal/processors/rest/TestMemcacheClient.java index a9a0489..adf1c50 100644 --- a/modules/clients/src/test/java/org/apache/ignite/internal/processors/rest/TestMemcacheClient.java +++ b/modules/clients/src/test/java/org/apache/ignite/internal/processors/rest/TestMemcacheClient.java @@ -113,7 +113,6 @@ final class TestMemcacheClient { // Start socket reader thread. rdr = new Thread(new Runnable() { - @SuppressWarnings("InfiniteLoopStatement") @Override public void run() { try { InputStream in = sock.getInputStream(); http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/clients/src/test/java/org/apache/ignite/jdbc/JdbcComplexQuerySelfTest.java ---------------------------------------------------------------------- diff --git a/modules/clients/src/test/java/org/apache/ignite/jdbc/JdbcComplexQuerySelfTest.java b/modules/clients/src/test/java/org/apache/ignite/jdbc/JdbcComplexQuerySelfTest.java index 3c00288..269e301 100644 --- a/modules/clients/src/test/java/org/apache/ignite/jdbc/JdbcComplexQuerySelfTest.java +++ b/modules/clients/src/test/java/org/apache/ignite/jdbc/JdbcComplexQuerySelfTest.java @@ -260,7 +260,6 @@ public class JdbcComplexQuerySelfTest extends GridCommonAbstractTest { /** * Person. */ - @SuppressWarnings("UnusedDeclaration") private static class Person implements Serializable { /** ID. */ @QuerySqlField @@ -299,7 +298,6 @@ public class JdbcComplexQuerySelfTest extends GridCommonAbstractTest { /** * Organization. */ - @SuppressWarnings("UnusedDeclaration") private static class Organization implements Serializable { /** ID. */ @QuerySqlField http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/clients/src/test/java/org/apache/ignite/jdbc/JdbcErrorsAbstractSelfTest.java ---------------------------------------------------------------------- diff --git a/modules/clients/src/test/java/org/apache/ignite/jdbc/JdbcErrorsAbstractSelfTest.java b/modules/clients/src/test/java/org/apache/ignite/jdbc/JdbcErrorsAbstractSelfTest.java index c44e007..bdcfe5b 100644 --- a/modules/clients/src/test/java/org/apache/ignite/jdbc/JdbcErrorsAbstractSelfTest.java +++ b/modules/clients/src/test/java/org/apache/ignite/jdbc/JdbcErrorsAbstractSelfTest.java @@ -717,7 +717,6 @@ public abstract class JdbcErrorsAbstractSelfTest extends GridCommonAbstractTest * @param expState expected SQLSTATE code. * @throws SQLException if failed. */ - @SuppressWarnings("ThrowableResultOfMethodCallIgnored") private void checkErrorState(final String sql, String expState, String expMsg) throws SQLException { checkErrorState(new ConnClosure() { @Override public void run(Connection conn) throws Exception { @@ -734,7 +733,6 @@ public abstract class JdbcErrorsAbstractSelfTest extends GridCommonAbstractTest * @param expState expected SQLSTATE code. * @throws SQLException if failed. */ - @SuppressWarnings("ThrowableResultOfMethodCallIgnored") protected void checkErrorState(final ConnClosure clo, String expState, String expMsg) throws SQLException { checkErrorState(new IgniteCallable() { @Override public Void call() throws Exception { @@ -755,7 +753,6 @@ public abstract class JdbcErrorsAbstractSelfTest extends GridCommonAbstractTest * @param expState expected SQLSTATE code. * @throws SQLException if failed. */ - @SuppressWarnings("ThrowableResultOfMethodCallIgnored") protected void checkErrorState(final IgniteCallable clo, String expState, String expMsg) throws SQLException { SQLException ex = (SQLException)GridTestUtils.assertThrows(null, clo, SQLException.class, expMsg); http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/clients/src/test/java/org/apache/ignite/jdbc/JdbcMetadataSelfTest.java ---------------------------------------------------------------------- diff --git a/modules/clients/src/test/java/org/apache/ignite/jdbc/JdbcMetadataSelfTest.java b/modules/clients/src/test/java/org/apache/ignite/jdbc/JdbcMetadataSelfTest.java index f270910..87c1202 100644 --- a/modules/clients/src/test/java/org/apache/ignite/jdbc/JdbcMetadataSelfTest.java +++ b/modules/clients/src/test/java/org/apache/ignite/jdbc/JdbcMetadataSelfTest.java @@ -287,7 +287,6 @@ public class JdbcMetadataSelfTest extends GridCommonAbstractTest { /** * Person. */ - @SuppressWarnings("UnusedDeclaration") private static class Person implements Serializable { /** Name. */ @QuerySqlField(index = false) @@ -320,7 +319,6 @@ public class JdbcMetadataSelfTest extends GridCommonAbstractTest { /** * Organization. */ - @SuppressWarnings("UnusedDeclaration") private static class Organization implements Serializable { /** ID. */ @QuerySqlField http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/clients/src/test/java/org/apache/ignite/jdbc/JdbcPreparedStatementSelfTest.java ---------------------------------------------------------------------- diff --git a/modules/clients/src/test/java/org/apache/ignite/jdbc/JdbcPreparedStatementSelfTest.java b/modules/clients/src/test/java/org/apache/ignite/jdbc/JdbcPreparedStatementSelfTest.java index 9bdb7d8..7a52edf 100644 --- a/modules/clients/src/test/java/org/apache/ignite/jdbc/JdbcPreparedStatementSelfTest.java +++ b/modules/clients/src/test/java/org/apache/ignite/jdbc/JdbcPreparedStatementSelfTest.java @@ -704,7 +704,6 @@ public class JdbcPreparedStatementSelfTest extends GridCommonAbstractTest { /** * Test object. */ - @SuppressWarnings("UnusedDeclaration") private static class TestObject implements Serializable { /** */ @QuerySqlField(index = false) http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/clients/src/test/java/org/apache/ignite/jdbc/JdbcResultSetSelfTest.java ---------------------------------------------------------------------- diff --git a/modules/clients/src/test/java/org/apache/ignite/jdbc/JdbcResultSetSelfTest.java b/modules/clients/src/test/java/org/apache/ignite/jdbc/JdbcResultSetSelfTest.java index 0fe55f2..2214139 100644 --- a/modules/clients/src/test/java/org/apache/ignite/jdbc/JdbcResultSetSelfTest.java +++ b/modules/clients/src/test/java/org/apache/ignite/jdbc/JdbcResultSetSelfTest.java @@ -603,7 +603,6 @@ public class JdbcResultSetSelfTest extends GridCommonAbstractTest { /** * Test object. */ - @SuppressWarnings("UnusedDeclaration") private static class TestObject implements Serializable { /** */ @QuerySqlField http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/clients/src/test/java/org/apache/ignite/jdbc/JdbcStatementSelfTest.java ---------------------------------------------------------------------- diff --git a/modules/clients/src/test/java/org/apache/ignite/jdbc/JdbcStatementSelfTest.java b/modules/clients/src/test/java/org/apache/ignite/jdbc/JdbcStatementSelfTest.java index 4d72b8e..3530801 100644 --- a/modules/clients/src/test/java/org/apache/ignite/jdbc/JdbcStatementSelfTest.java +++ b/modules/clients/src/test/java/org/apache/ignite/jdbc/JdbcStatementSelfTest.java @@ -248,7 +248,6 @@ public class JdbcStatementSelfTest extends GridCommonAbstractTest { /** * Person. */ - @SuppressWarnings("UnusedDeclaration") private static class Person implements Serializable { /** ID. */ @QuerySqlField http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinAbstractDmlStatementSelfTest.java ---------------------------------------------------------------------- diff --git a/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinAbstractDmlStatementSelfTest.java b/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinAbstractDmlStatementSelfTest.java index 9363467..405f21a 100644 --- a/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinAbstractDmlStatementSelfTest.java +++ b/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinAbstractDmlStatementSelfTest.java @@ -186,7 +186,6 @@ public abstract class JdbcThinAbstractDmlStatementSelfTest extends JdbcThinAbstr /** * Person. */ - @SuppressWarnings("UnusedDeclaration") static class Person implements Serializable { /** ID. */ @QuerySqlField http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinAutoCloseServerCursorTest.java ---------------------------------------------------------------------- diff --git a/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinAutoCloseServerCursorTest.java b/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinAutoCloseServerCursorTest.java index bb2696f..0e0bcb7 100644 --- a/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinAutoCloseServerCursorTest.java +++ b/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinAutoCloseServerCursorTest.java @@ -95,7 +95,6 @@ public class JdbcThinAutoCloseServerCursorTest extends JdbcThinAbstractSelfTest * * @throws Exception If failed. */ - @SuppressWarnings("ThrowableResultOfMethodCallIgnored") public void testQuery() throws Exception { IgniteCache cache = grid(0).cache(CACHE_NAME); @@ -288,7 +287,6 @@ public class JdbcThinAutoCloseServerCursorTest extends JdbcThinAbstractSelfTest /** * Person. */ - @SuppressWarnings("UnusedDeclaration") static class Person implements Serializable { /** ID. */ @QuerySqlField http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinComplexDmlDdlSelfTest.java ---------------------------------------------------------------------- diff --git a/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinComplexDmlDdlSelfTest.java b/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinComplexDmlDdlSelfTest.java index 36ee34a..88fcab2 100644 --- a/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinComplexDmlDdlSelfTest.java +++ b/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinComplexDmlDdlSelfTest.java @@ -127,7 +127,6 @@ public class JdbcThinComplexDmlDdlSelfTest extends GridCommonAbstractTest { /** * @throws Exception If failed. */ - @SuppressWarnings("ThrowableResultOfMethodCallIgnored") public void testCreateSelectDrop() throws Exception { conn = createConnection(); http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinComplexQuerySelfTest.java ---------------------------------------------------------------------- diff --git a/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinComplexQuerySelfTest.java b/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinComplexQuerySelfTest.java index 692de7c..f93c4fa 100644 --- a/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinComplexQuerySelfTest.java +++ b/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinComplexQuerySelfTest.java @@ -264,7 +264,6 @@ public class JdbcThinComplexQuerySelfTest extends JdbcThinAbstractSelfTest { /** * Person. */ - @SuppressWarnings("UnusedDeclaration") private static class Person implements Serializable { /** ID. */ @QuerySqlField @@ -303,7 +302,6 @@ public class JdbcThinComplexQuerySelfTest extends JdbcThinAbstractSelfTest { /** * Organization. */ - @SuppressWarnings("UnusedDeclaration") private static class Organization implements Serializable { /** ID. */ @QuerySqlField http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinConnectionSelfTest.java ---------------------------------------------------------------------- diff --git a/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinConnectionSelfTest.java b/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinConnectionSelfTest.java index 5e12bae..5d2a33e 100644 --- a/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinConnectionSelfTest.java +++ b/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinConnectionSelfTest.java @@ -1924,7 +1924,6 @@ public class JdbcThinConnectionSelfTest extends JdbcThinAbstractSelfTest { /** * Test that attempting to supply invalid nested TX mode to driver fails on the client. */ - @SuppressWarnings("ThrowableResultOfMethodCallIgnored") public void testInvalidNestedTxMode() { GridTestUtils.assertThrows(null, new Callable() { @Override public Object call() throws Exception { @@ -1940,7 +1939,6 @@ public class JdbcThinConnectionSelfTest extends JdbcThinAbstractSelfTest { * We have to do this without explicit {@link Connection} as long as there's no other way to bypass validation and * supply a malformed {@link ConnectionProperties} to {@link JdbcThinTcpIo}. */ - @SuppressWarnings({"ThrowableResultOfMethodCallIgnored", "ThrowFromFinallyBlock"}) public void testInvalidNestedTxModeOnServerSide() throws SQLException, NoSuchMethodException, IllegalAccessException, InvocationTargetException, InstantiationException, IOException { ConnectionPropertiesImpl connProps = new ConnectionPropertiesImpl(); http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinErrorsSelfTest.java ---------------------------------------------------------------------- diff --git a/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinErrorsSelfTest.java b/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinErrorsSelfTest.java index 2ff3e9f..13c1bb7 100644 --- a/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinErrorsSelfTest.java +++ b/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinErrorsSelfTest.java @@ -83,7 +83,6 @@ public class JdbcThinErrorsSelfTest extends JdbcErrorsAbstractSelfTest { * Test error code for the case when error is caused on batch execution. * @throws SQLException if failed. */ - @SuppressWarnings("MagicConstant") public void testBatchUpdateException() throws SQLException { try (final Connection conn = getConnection()) { try (Statement stmt = conn.createStatement()) { http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinMetadataSelfTest.java ---------------------------------------------------------------------- diff --git a/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinMetadataSelfTest.java b/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinMetadataSelfTest.java index 35832b7..2bc569d 100644 --- a/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinMetadataSelfTest.java +++ b/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinMetadataSelfTest.java @@ -641,7 +641,6 @@ public class JdbcThinMetadataSelfTest extends JdbcThinAbstractSelfTest { /** * Person. */ - @SuppressWarnings("UnusedDeclaration") private static class Person implements Serializable { /** Name. */ private final String name; @@ -671,7 +670,6 @@ public class JdbcThinMetadataSelfTest extends JdbcThinAbstractSelfTest { /** * Organization. */ - @SuppressWarnings("UnusedDeclaration") private static class Organization implements Serializable { /** ID. */ private final int id; @@ -692,7 +690,6 @@ public class JdbcThinMetadataSelfTest extends JdbcThinAbstractSelfTest { /** * Organization. */ - @SuppressWarnings("UnusedDeclaration") private static class Department implements Serializable { /** ID. */ @QuerySqlField http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinMissingLongArrayResultsTest.java ---------------------------------------------------------------------- diff --git a/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinMissingLongArrayResultsTest.java b/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinMissingLongArrayResultsTest.java index 633c74b..f78ce70 100644 --- a/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinMissingLongArrayResultsTest.java +++ b/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinMissingLongArrayResultsTest.java @@ -164,7 +164,7 @@ public class JdbcThinMissingLongArrayResultsTest extends JdbcThinAbstractSelfTes /** * @throws Exception If failed. */ - @SuppressWarnings({"EmptyTryBlock", "unused"}) + @SuppressWarnings({"unused"}) public void testDefaults() throws Exception { try (Connection conn = DriverManager.getConnection(URL)) { conn.setSchema('"' + CACHE_NAME + '"'); http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinPreparedStatementSelfTest.java ---------------------------------------------------------------------- diff --git a/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinPreparedStatementSelfTest.java b/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinPreparedStatementSelfTest.java index 85efb4d..36bc80c 100644 --- a/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinPreparedStatementSelfTest.java +++ b/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinPreparedStatementSelfTest.java @@ -981,7 +981,6 @@ public class JdbcThinPreparedStatementSelfTest extends JdbcThinAbstractSelfTest /** * Test object. */ - @SuppressWarnings("UnusedDeclaration") private static class TestObject implements Serializable { /** */ @QuerySqlField http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinResultSetSelfTest.java ---------------------------------------------------------------------- diff --git a/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinResultSetSelfTest.java b/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinResultSetSelfTest.java index 36a0a15..75ca8b6 100644 --- a/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinResultSetSelfTest.java +++ b/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinResultSetSelfTest.java @@ -1655,7 +1655,6 @@ public class JdbcThinResultSetSelfTest extends JdbcThinAbstractSelfTest { /** * Test object. */ - @SuppressWarnings("UnusedDeclaration") private static class TestObject implements Serializable { /** */ @QuerySqlField http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinSchemaCaseTest.java ---------------------------------------------------------------------- diff --git a/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinSchemaCaseTest.java b/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinSchemaCaseTest.java index 8f11087..0a4e6f5 100644 --- a/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinSchemaCaseTest.java +++ b/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinSchemaCaseTest.java @@ -90,7 +90,7 @@ public class JdbcThinSchemaCaseTest extends JdbcThinAbstractSelfTest { /** * @throws Exception If failed. */ - @SuppressWarnings({"EmptyTryBlock", "unused"}) + @SuppressWarnings({"unused"}) public void testSchemaName() throws Exception { checkSchemaConnection("test0"); checkSchemaConnection("test1"); http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinSelectAfterAlterTable.java ---------------------------------------------------------------------- diff --git a/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinSelectAfterAlterTable.java b/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinSelectAfterAlterTable.java index ef711dc..5374bca 100644 --- a/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinSelectAfterAlterTable.java +++ b/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinSelectAfterAlterTable.java @@ -119,7 +119,6 @@ public class JdbcThinSelectAfterAlterTable extends GridCommonAbstractTest { /** * @throws Exception If failed. */ - @SuppressWarnings({"ThrowableResultOfMethodCallIgnored", "unchecked"}) public void testSelectAfterAlterTableSingleNode() throws Exception { stmt.executeUpdate("alter table person add age int"); @@ -129,7 +128,6 @@ public class JdbcThinSelectAfterAlterTable extends GridCommonAbstractTest { /** * @throws Exception If failed. */ - @SuppressWarnings({"ThrowableResultOfMethodCallIgnored", "unchecked"}) public void testSelectAfterAlterTableMultiNode() throws Exception { try (Connection conn2 = DriverManager.getConnection("jdbc:ignite:thin://127.0.0.1:" + (ClientConnectorConfiguration.DFLT_PORT + 1))) { http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinStatementSelfTest.java ---------------------------------------------------------------------- diff --git a/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinStatementSelfTest.java b/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinStatementSelfTest.java index 3605575..db3955d 100644 --- a/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinStatementSelfTest.java +++ b/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinStatementSelfTest.java @@ -44,7 +44,7 @@ import static org.apache.ignite.cache.CacheWriteSynchronizationMode.FULL_SYNC; /** * Statement test. */ -@SuppressWarnings({"ThrowableNotThrown", "ThrowableResultOfMethodCallIgnored"}) +@SuppressWarnings({"ThrowableNotThrown"}) public class JdbcThinStatementSelfTest extends JdbcThinAbstractSelfTest { /** IP finder. */ private static final TcpDiscoveryIpFinder IP_FINDER = new TcpDiscoveryVmIpFinder(true); @@ -1182,7 +1182,6 @@ public class JdbcThinStatementSelfTest extends JdbcThinAbstractSelfTest { /** * Person. */ - @SuppressWarnings("UnusedDeclaration") private static class Person implements Serializable { /** ID. */ @QuerySqlField http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinTcpIoTest.java ---------------------------------------------------------------------- diff --git a/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinTcpIoTest.java b/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinTcpIoTest.java index fc3704b..d8ce82b 100644 --- a/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinTcpIoTest.java +++ b/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinTcpIoTest.java @@ -36,7 +36,6 @@ import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest; /** * Tests for JdbcThinTcpIo. */ -@SuppressWarnings("ThrowableNotThrown") public class JdbcThinTcpIoTest extends GridCommonAbstractTest { /** Server port range. */ private static final int[] SERVER_PORT_RANGE = {59000, 59020}; http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinTransactionsAbstractComplexSelfTest.java ---------------------------------------------------------------------- diff --git a/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinTransactionsAbstractComplexSelfTest.java b/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinTransactionsAbstractComplexSelfTest.java index 4a1b02c..af78f8e 100644 --- a/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinTransactionsAbstractComplexSelfTest.java +++ b/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinTransactionsAbstractComplexSelfTest.java @@ -271,7 +271,6 @@ public abstract class JdbcThinTransactionsAbstractComplexSelfTest extends JdbcTh /** * */ - @SuppressWarnings("ThrowableResultOfMethodCallIgnored") public void testBatchDmlStatementsIntermediateFailure() throws SQLException { insertPerson(6, "John", "Doe", 2, 2); @@ -688,7 +687,6 @@ public abstract class JdbcThinTransactionsAbstractComplexSelfTest extends JdbcTh * (must yield an exception). * @throws Exception if failed. */ - @SuppressWarnings("ThrowableResultOfMethodCallIgnored") private void doTestRepeatableRead(final IgniteInClosure concurrentWriteClo, final IgniteInClosure afterReadClo) throws Exception { final CountDownLatch repeatableReadLatch = new CountDownLatch(1); http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinTransactionsSelfTest.java ---------------------------------------------------------------------- diff --git a/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinTransactionsSelfTest.java b/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinTransactionsSelfTest.java index 783a8cd..88e53d9 100644 --- a/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinTransactionsSelfTest.java +++ b/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinTransactionsSelfTest.java @@ -186,7 +186,6 @@ public class JdbcThinTransactionsSelfTest extends JdbcThinAbstractSelfTest { /** * */ - @SuppressWarnings("ThrowableResultOfMethodCallIgnored") public void testIgnoreNestedTxAutocommitOff() throws SQLException { try (Connection c = c(false, NestedTxMode.IGNORE)) { doNestedTxStart(c, false); @@ -198,7 +197,6 @@ public class JdbcThinTransactionsSelfTest extends JdbcThinAbstractSelfTest { /** * */ - @SuppressWarnings("ThrowableResultOfMethodCallIgnored") public void testCommitNestedTxAutocommitOff() throws SQLException { try (Connection c = c(false, NestedTxMode.COMMIT)) { doNestedTxStart(c, false); @@ -210,7 +208,6 @@ public class JdbcThinTransactionsSelfTest extends JdbcThinAbstractSelfTest { /** * */ - @SuppressWarnings("ThrowableResultOfMethodCallIgnored") public void testErrorNestedTxAutocommitOff() throws SQLException { GridTestUtils.assertThrows(null, new Callable() { @Override public Void call() throws Exception { @@ -226,7 +223,6 @@ public class JdbcThinTransactionsSelfTest extends JdbcThinAbstractSelfTest { /** * */ - @SuppressWarnings("ThrowableResultOfMethodCallIgnored") public void testIgnoreNestedTxAutocommitOn() throws SQLException { try (Connection c = c(true, NestedTxMode.IGNORE)) { doNestedTxStart(c, false); @@ -238,7 +234,6 @@ public class JdbcThinTransactionsSelfTest extends JdbcThinAbstractSelfTest { /** * */ - @SuppressWarnings("ThrowableResultOfMethodCallIgnored") public void testCommitNestedTxAutocommitOn() throws SQLException { try (Connection c = c(true, NestedTxMode.COMMIT)) { doNestedTxStart(c, false); @@ -250,7 +245,6 @@ public class JdbcThinTransactionsSelfTest extends JdbcThinAbstractSelfTest { /** * */ - @SuppressWarnings("ThrowableResultOfMethodCallIgnored") public void testErrorNestedTxAutocommitOn() throws SQLException { GridTestUtils.assertThrows(null, new Callable() { @Override public Void call() throws Exception { @@ -266,7 +260,6 @@ public class JdbcThinTransactionsSelfTest extends JdbcThinAbstractSelfTest { /** * */ - @SuppressWarnings("ThrowableResultOfMethodCallIgnored") public void testIgnoreNestedTxAutocommitOffBatched() throws SQLException { try (Connection c = c(false, NestedTxMode.IGNORE)) { doNestedTxStart(c, true); @@ -278,7 +271,6 @@ public class JdbcThinTransactionsSelfTest extends JdbcThinAbstractSelfTest { /** * */ - @SuppressWarnings("ThrowableResultOfMethodCallIgnored") public void testCommitNestedTxAutocommitOffBatched() throws SQLException { try (Connection c = c(false, NestedTxMode.COMMIT)) { doNestedTxStart(c, true); @@ -290,7 +282,6 @@ public class JdbcThinTransactionsSelfTest extends JdbcThinAbstractSelfTest { /** * */ - @SuppressWarnings("ThrowableResultOfMethodCallIgnored") public void testErrorNestedTxAutocommitOffBatched() throws SQLException { GridTestUtils.assertThrows(null, new Callable() { @Override public Void call() throws Exception { @@ -306,7 +297,6 @@ public class JdbcThinTransactionsSelfTest extends JdbcThinAbstractSelfTest { /** * */ - @SuppressWarnings("ThrowableResultOfMethodCallIgnored") public void testIgnoreNestedTxAutocommitOnBatched() throws SQLException { try (Connection c = c(true, NestedTxMode.IGNORE)) { doNestedTxStart(c, true); @@ -318,7 +308,6 @@ public class JdbcThinTransactionsSelfTest extends JdbcThinAbstractSelfTest { /** * */ - @SuppressWarnings("ThrowableResultOfMethodCallIgnored") public void testCommitNestedTxAutocommitOnBatched() throws SQLException { try (Connection c = c(true, NestedTxMode.COMMIT)) { doNestedTxStart(c, true); @@ -330,7 +319,6 @@ public class JdbcThinTransactionsSelfTest extends JdbcThinAbstractSelfTest { /** * */ - @SuppressWarnings("ThrowableResultOfMethodCallIgnored") public void testErrorNestedTxAutocommitOnBatched() throws SQLException { GridTestUtils.assertThrows(null, new Callable() { @Override public Void call() throws Exception { @@ -422,7 +410,6 @@ public class JdbcThinTransactionsSelfTest extends JdbcThinAbstractSelfTest { * Test that exception in one of the statements does not kill connection worker altogether. * @throws SQLException if failed. */ - @SuppressWarnings("ThrowableResultOfMethodCallIgnored") public void testExceptionHandling() throws SQLException { try (Connection c = c(true, NestedTxMode.ERROR)) { try (Statement s = c.createStatement()) { @@ -449,7 +436,6 @@ public class JdbcThinTransactionsSelfTest extends JdbcThinAbstractSelfTest { * Test that exception in one of the statements does not kill connection worker altogether. * @throws SQLException if failed. */ - @SuppressWarnings("ThrowableResultOfMethodCallIgnored") public void testParsingErrorHasNoSideEffect() throws SQLException { try (Connection c = c(false, NestedTxMode.ERROR)) { try (Statement s = c.createStatement()) { http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinTransactionsWithMvccEnabledSelfTest.java ---------------------------------------------------------------------- diff --git a/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinTransactionsWithMvccEnabledSelfTest.java b/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinTransactionsWithMvccEnabledSelfTest.java index 3ee003a..2261523 100644 --- a/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinTransactionsWithMvccEnabledSelfTest.java +++ b/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinTransactionsWithMvccEnabledSelfTest.java @@ -185,7 +185,6 @@ public class JdbcThinTransactionsWithMvccEnabledSelfTest extends JdbcThinAbstrac /** * */ - @SuppressWarnings("ThrowableResultOfMethodCallIgnored") public void testIgnoreNestedTxAutocommitOff() throws SQLException { try (Connection c = c(false, NestedTxMode.IGNORE)) { doNestedTxStart(c, false); @@ -197,7 +196,6 @@ public class JdbcThinTransactionsWithMvccEnabledSelfTest extends JdbcThinAbstrac /** * */ - @SuppressWarnings("ThrowableResultOfMethodCallIgnored") public void testCommitNestedTxAutocommitOff() throws SQLException { try (Connection c = c(false, NestedTxMode.COMMIT)) { doNestedTxStart(c, false); @@ -209,7 +207,6 @@ public class JdbcThinTransactionsWithMvccEnabledSelfTest extends JdbcThinAbstrac /** * */ - @SuppressWarnings("ThrowableResultOfMethodCallIgnored") public void testErrorNestedTxAutocommitOff() { GridTestUtils.assertThrows(null, new Callable() { @Override public Void call() throws Exception { @@ -225,7 +222,6 @@ public class JdbcThinTransactionsWithMvccEnabledSelfTest extends JdbcThinAbstrac /** * */ - @SuppressWarnings("ThrowableResultOfMethodCallIgnored") public void testIgnoreNestedTxAutocommitOn() throws SQLException { try (Connection c = c(true, NestedTxMode.IGNORE)) { doNestedTxStart(c, false); @@ -237,7 +233,6 @@ public class JdbcThinTransactionsWithMvccEnabledSelfTest extends JdbcThinAbstrac /** * */ - @SuppressWarnings("ThrowableResultOfMethodCallIgnored") public void testCommitNestedTxAutocommitOn() throws SQLException { try (Connection c = c(true, NestedTxMode.COMMIT)) { doNestedTxStart(c, false); @@ -249,7 +244,6 @@ public class JdbcThinTransactionsWithMvccEnabledSelfTest extends JdbcThinAbstrac /** * */ - @SuppressWarnings("ThrowableResultOfMethodCallIgnored") public void testErrorNestedTxAutocommitOn() { GridTestUtils.assertThrows(null, new Callable() { @Override public Void call() throws Exception { @@ -265,7 +259,6 @@ public class JdbcThinTransactionsWithMvccEnabledSelfTest extends JdbcThinAbstrac /** * */ - @SuppressWarnings("ThrowableResultOfMethodCallIgnored") public void testIgnoreNestedTxAutocommitOffBatched() throws SQLException { try (Connection c = c(false, NestedTxMode.IGNORE)) { doNestedTxStart(c, true); @@ -277,7 +270,6 @@ public class JdbcThinTransactionsWithMvccEnabledSelfTest extends JdbcThinAbstrac /** * */ - @SuppressWarnings("ThrowableResultOfMethodCallIgnored") public void testCommitNestedTxAutocommitOffBatched() throws SQLException { try (Connection c = c(false, NestedTxMode.COMMIT)) { doNestedTxStart(c, true); @@ -289,7 +281,6 @@ public class JdbcThinTransactionsWithMvccEnabledSelfTest extends JdbcThinAbstrac /** * */ - @SuppressWarnings("ThrowableResultOfMethodCallIgnored") public void testErrorNestedTxAutocommitOffBatched() { GridTestUtils.assertThrows(null, new Callable() { @Override public Void call() throws Exception { @@ -305,7 +296,6 @@ public class JdbcThinTransactionsWithMvccEnabledSelfTest extends JdbcThinAbstrac /** * */ - @SuppressWarnings("ThrowableResultOfMethodCallIgnored") public void testIgnoreNestedTxAutocommitOnBatched() throws SQLException { try (Connection c = c(true, NestedTxMode.IGNORE)) { doNestedTxStart(c, true); @@ -317,7 +307,6 @@ public class JdbcThinTransactionsWithMvccEnabledSelfTest extends JdbcThinAbstrac /** * */ - @SuppressWarnings("ThrowableResultOfMethodCallIgnored") public void testCommitNestedTxAutocommitOnBatched() throws SQLException { try (Connection c = c(true, NestedTxMode.COMMIT)) { doNestedTxStart(c, true); @@ -329,7 +318,6 @@ public class JdbcThinTransactionsWithMvccEnabledSelfTest extends JdbcThinAbstrac /** * */ - @SuppressWarnings("ThrowableResultOfMethodCallIgnored") public void testErrorNestedTxAutocommitOnBatched() { GridTestUtils.assertThrows(null, new Callable() { @Override public Void call() throws Exception { @@ -421,7 +409,6 @@ public class JdbcThinTransactionsWithMvccEnabledSelfTest extends JdbcThinAbstrac * Test that exception in one of the statements does not kill connection worker altogether. * @throws SQLException if failed. */ - @SuppressWarnings("ThrowableResultOfMethodCallIgnored") public void testExceptionHandling() throws SQLException { try (Connection c = c(true, NestedTxMode.ERROR)) { try (Statement s = c.createStatement()) { http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/clients/src/test/java/org/apache/ignite/loadtests/client/ClientCacheBenchmark.java ---------------------------------------------------------------------- diff --git a/modules/clients/src/test/java/org/apache/ignite/loadtests/client/ClientCacheBenchmark.java b/modules/clients/src/test/java/org/apache/ignite/loadtests/client/ClientCacheBenchmark.java index 662af2b..8b5292f 100644 --- a/modules/clients/src/test/java/org/apache/ignite/loadtests/client/ClientCacheBenchmark.java +++ b/modules/clients/src/test/java/org/apache/ignite/loadtests/client/ClientCacheBenchmark.java @@ -96,7 +96,6 @@ public class ClientCacheBenchmark { * @param printResults Whether to print results. * @throws GridClientException If failed. */ - @SuppressWarnings("NullableProblems") public void run(boolean printResults) throws GridClientException { Collection workers = new ArrayList<>(threadCnt); http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/clients/src/test/java/org/apache/ignite/loadtests/client/ClientTcpSslLoadTest.java ---------------------------------------------------------------------- diff --git a/modules/clients/src/test/java/org/apache/ignite/loadtests/client/ClientTcpSslLoadTest.java b/modules/clients/src/test/java/org/apache/ignite/loadtests/client/ClientTcpSslLoadTest.java index 669c110..a90a3bf 100644 --- a/modules/clients/src/test/java/org/apache/ignite/loadtests/client/ClientTcpSslLoadTest.java +++ b/modules/clients/src/test/java/org/apache/ignite/loadtests/client/ClientTcpSslLoadTest.java @@ -74,7 +74,6 @@ public class ClientTcpSslLoadTest extends ClientTcpSslMultiThreadedSelfTest { /** * Clears caches on all nodes. */ - @SuppressWarnings("ConstantConditions") private void clearCaches() { for (int i = 0; i < NODES_CNT; i++) try { http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/IgniteJdbcDriver.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/IgniteJdbcDriver.java b/modules/core/src/main/java/org/apache/ignite/IgniteJdbcDriver.java index aed6f86..2a146ca 100644 --- a/modules/core/src/main/java/org/apache/ignite/IgniteJdbcDriver.java +++ b/modules/core/src/main/java/org/apache/ignite/IgniteJdbcDriver.java @@ -285,7 +285,6 @@ import org.apache.ignite.internal.jdbc.JdbcDriverPropertyInfo; * } * */ -@SuppressWarnings("JavadocReference") public class IgniteJdbcDriver implements Driver { /** Prefix for property names. */ private static final String PROP_PREFIX = "ignite.jdbc."; http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/IgniteJdbcThinDriver.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/IgniteJdbcThinDriver.java b/modules/core/src/main/java/org/apache/ignite/IgniteJdbcThinDriver.java index ba4199f..b6dff88 100644 --- a/modules/core/src/main/java/org/apache/ignite/IgniteJdbcThinDriver.java +++ b/modules/core/src/main/java/org/apache/ignite/IgniteJdbcThinDriver.java @@ -125,7 +125,6 @@ import org.apache.ignite.internal.jdbc.thin.JdbcThinUtils; * } * */ -@SuppressWarnings("JavadocReference") public class IgniteJdbcThinDriver implements Driver { /** Driver instance. */ private static final Driver INSTANCE = new IgniteJdbcThinDriver(); http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/cache/store/jdbc/CacheJdbcBlobStore.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/cache/store/jdbc/CacheJdbcBlobStore.java b/modules/core/src/main/java/org/apache/ignite/cache/store/jdbc/CacheJdbcBlobStore.java index 2b480bd..c3abf1a 100644 --- a/modules/core/src/main/java/org/apache/ignite/cache/store/jdbc/CacheJdbcBlobStore.java +++ b/modules/core/src/main/java/org/apache/ignite/cache/store/jdbc/CacheJdbcBlobStore.java @@ -207,7 +207,6 @@ public class CacheJdbcBlobStore extends CacheStoreAdapter { } /** {@inheritDoc} */ - @SuppressWarnings({"RedundantTypeArguments"}) @Override public V load(K key) { init(); http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/cache/store/jdbc/CacheJdbcPojoStoreFactory.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/cache/store/jdbc/CacheJdbcPojoStoreFactory.java b/modules/core/src/main/java/org/apache/ignite/cache/store/jdbc/CacheJdbcPojoStoreFactory.java index 154b922..0bf6de6 100644 --- a/modules/core/src/main/java/org/apache/ignite/cache/store/jdbc/CacheJdbcPojoStoreFactory.java +++ b/modules/core/src/main/java/org/apache/ignite/cache/store/jdbc/CacheJdbcPojoStoreFactory.java @@ -398,7 +398,6 @@ public class CacheJdbcPojoStoreFactory implements Factory getDataSourceFactory() { return dataSrcFactory; } @@ -409,7 +408,6 @@ public class CacheJdbcPojoStoreFactory implements Factory setDataSourceFactory(Factory dataSrcFactory) { this.dataSrcFactory = dataSrcFactory; http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/compute/ComputeTaskName.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/compute/ComputeTaskName.java b/modules/core/src/main/java/org/apache/ignite/compute/ComputeTaskName.java index 7f45155..38ee960 100644 --- a/modules/core/src/main/java/org/apache/ignite/compute/ComputeTaskName.java +++ b/modules/core/src/main/java/org/apache/ignite/compute/ComputeTaskName.java @@ -35,5 +35,5 @@ public @interface ComputeTaskName { /** * Optional task name. */ - @SuppressWarnings({"JavaDoc"}) String value(); + String value(); } \ No newline at end of file http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/compute/ComputeTaskSpis.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/compute/ComputeTaskSpis.java b/modules/core/src/main/java/org/apache/ignite/compute/ComputeTaskSpis.java index 0b6e425..89ebe9b 100644 --- a/modules/core/src/main/java/org/apache/ignite/compute/ComputeTaskSpis.java +++ b/modules/core/src/main/java/org/apache/ignite/compute/ComputeTaskSpis.java @@ -31,7 +31,6 @@ import java.lang.annotation.Target; * you need to tell a task which SPI to use (by default it will use the fist * SPI in the list). */ -@SuppressWarnings({"JavaDoc"}) @Documented @Retention(RetentionPolicy.RUNTIME) @Target({ElementType.TYPE}) http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/compute/gridify/Gridify.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/compute/gridify/Gridify.java b/modules/core/src/main/java/org/apache/ignite/compute/gridify/Gridify.java index 93e91db..3a4c2d7 100644 --- a/modules/core/src/main/java/org/apache/ignite/compute/gridify/Gridify.java +++ b/modules/core/src/main/java/org/apache/ignite/compute/gridify/Gridify.java @@ -156,7 +156,6 @@ public @interface Gridify { * be specified - but not both. If neither one is specified tasks' fully qualified name * will be used as a default name. */ - @SuppressWarnings({"JavaDoc"}) String taskName() default ""; /** @@ -164,21 +163,18 @@ public @interface Gridify { * be specified - but not both. If neither one is specified tasks' fully qualified name * will be used as a default name. */ - @SuppressWarnings({"JavaDoc"}) Class> taskClass() default GridifyDefaultTask.class; /** * Optional gridify task execution timeout. Default is {@code 0} * which indicates that task will not timeout. */ - @SuppressWarnings({"JavaDoc"}) long timeout() default 0; /** * Optional interceptor class. Since {@code null} are not supported the value of * {@code GridifyInterceptor.class} acts as a default value. */ - @SuppressWarnings({"JavaDoc"}) Class interceptor() default GridifyInterceptor.class; /** @@ -187,7 +183,6 @@ public @interface Gridify { * * @deprecated Use {@link #igniteInstanceName()}. Nonempty {@link #igniteInstanceName()} takes precedence. */ - @SuppressWarnings({"JavaDoc"}) @Deprecated String gridName() default ""; @@ -195,6 +190,5 @@ public @interface Gridify { * Name of the Ignite instance to use. By default, no-name default Ignite instance is used. * Refer to {@link org.apache.ignite.Ignition} for information about named Ignite instances. */ - @SuppressWarnings({"JavaDoc"}) String igniteInstanceName() default ""; } \ No newline at end of file http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/compute/gridify/GridifySetToSet.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/compute/gridify/GridifySetToSet.java b/modules/core/src/main/java/org/apache/ignite/compute/gridify/GridifySetToSet.java index 635f28d..1e6aea3 100644 --- a/modules/core/src/main/java/org/apache/ignite/compute/gridify/GridifySetToSet.java +++ b/modules/core/src/main/java/org/apache/ignite/compute/gridify/GridifySetToSet.java @@ -208,6 +208,5 @@ public @interface GridifySetToSet { * Name of the Ignite instance to use. By default, no-name default Ignite instance is used. * Refer to {@link org.apache.ignite.Ignition} for information about named Ignite instances. */ - @SuppressWarnings({"JavaDoc"}) String igniteInstanceName() default ""; } \ No newline at end of file http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/compute/gridify/GridifySetToValue.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/compute/gridify/GridifySetToValue.java b/modules/core/src/main/java/org/apache/ignite/compute/gridify/GridifySetToValue.java index 34590d4..17c58f2 100644 --- a/modules/core/src/main/java/org/apache/ignite/compute/gridify/GridifySetToValue.java +++ b/modules/core/src/main/java/org/apache/ignite/compute/gridify/GridifySetToValue.java @@ -206,6 +206,5 @@ public @interface GridifySetToValue { * Name of the Ignite instance to use. By default, no-name default Ignite instance is used. * Refer to {@link org.apache.ignite.Ignition} for information about named Ignite instances. */ - @SuppressWarnings({"JavaDoc"}) String igniteInstanceName() default ""; } \ No newline at end of file http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/compute/gridify/aop/GridifyDefaultRangeTask.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/compute/gridify/aop/GridifyDefaultRangeTask.java b/modules/core/src/main/java/org/apache/ignite/compute/gridify/aop/GridifyDefaultRangeTask.java index 0a3ce3f..2decedc 100644 --- a/modules/core/src/main/java/org/apache/ignite/compute/gridify/aop/GridifyDefaultRangeTask.java +++ b/modules/core/src/main/java/org/apache/ignite/compute/gridify/aop/GridifyDefaultRangeTask.java @@ -83,7 +83,6 @@ public class GridifyDefaultRangeTask extends ComputeTaskAdapter cls, Iterable taskRes) { assert taskRes != null; http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/configuration/CacheConfiguration.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/configuration/CacheConfiguration.java b/modules/core/src/main/java/org/apache/ignite/configuration/CacheConfiguration.java index 35978e7..d28d842 100644 --- a/modules/core/src/main/java/org/apache/ignite/configuration/CacheConfiguration.java +++ b/modules/core/src/main/java/org/apache/ignite/configuration/CacheConfiguration.java @@ -73,7 +73,6 @@ import org.jetbrains.annotations.Nullable; * can be configured from Spring XML files (or other DI frameworks).

Note that absolutely all configuration * properties are optional, so users should only change what they need. */ -@SuppressWarnings("RedundantFieldInitialization") public class CacheConfiguration extends MutableConfiguration { /** */ private static final long serialVersionUID = 0L; http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/configuration/DataStorageConfiguration.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/configuration/DataStorageConfiguration.java b/modules/core/src/main/java/org/apache/ignite/configuration/DataStorageConfiguration.java index 7bca0f9..20b314f 100644 --- a/modules/core/src/main/java/org/apache/ignite/configuration/DataStorageConfiguration.java +++ b/modules/core/src/main/java/org/apache/ignite/configuration/DataStorageConfiguration.java @@ -68,7 +68,6 @@ public class DataStorageConfiguration implements Serializable { private static final long serialVersionUID = 0L; /** Default data region start size (256 MB). */ - @SuppressWarnings("UnnecessaryBoxing") public static final long DFLT_DATA_REGION_INITIAL_SIZE = 256L * 1024 * 1024; /** Fraction of available memory to allocate for default DataRegion. */ http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/configuration/IgniteConfiguration.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/configuration/IgniteConfiguration.java b/modules/core/src/main/java/org/apache/ignite/configuration/IgniteConfiguration.java index e7ccaf5..528dbbe 100644 --- a/modules/core/src/main/java/org/apache/ignite/configuration/IgniteConfiguration.java +++ b/modules/core/src/main/java/org/apache/ignite/configuration/IgniteConfiguration.java @@ -421,7 +421,6 @@ public class IgniteConfiguration { private String[] includeProps; /** Frequency of metrics log print out. */ - @SuppressWarnings("RedundantFieldInitialization") private long metricsLogFreq = DFLT_METRICS_LOG_FREQ; /** Local event listeners. */ http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/configuration/MemoryConfiguration.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/configuration/MemoryConfiguration.java b/modules/core/src/main/java/org/apache/ignite/configuration/MemoryConfiguration.java index 16e0939..74c926e 100644 --- a/modules/core/src/main/java/org/apache/ignite/configuration/MemoryConfiguration.java +++ b/modules/core/src/main/java/org/apache/ignite/configuration/MemoryConfiguration.java @@ -67,7 +67,6 @@ public class MemoryConfiguration implements Serializable { private static final long serialVersionUID = 0L; /** Default memory policy start size (256 MB). */ - @SuppressWarnings("UnnecessaryBoxing") public static final long DFLT_MEMORY_POLICY_INITIAL_SIZE = 256L * 1024 * 1024; /** Fraction of available memory to allocate for default DataRegion. */ http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/configuration/SqlConnectorConfiguration.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/configuration/SqlConnectorConfiguration.java b/modules/core/src/main/java/org/apache/ignite/configuration/SqlConnectorConfiguration.java index 4233d44..eca081c 100644 --- a/modules/core/src/main/java/org/apache/ignite/configuration/SqlConnectorConfiguration.java +++ b/modules/core/src/main/java/org/apache/ignite/configuration/SqlConnectorConfiguration.java @@ -26,7 +26,6 @@ import org.jetbrains.annotations.Nullable; * Deprecated as of Apache Ignite 2.3. Please use {@link ClientConnectorConfiguration} and * {@link IgniteConfiguration#setClientConnectorConfiguration(ClientConnectorConfiguration)} instead. */ -@SuppressWarnings("deprecation") @Deprecated public class SqlConnectorConfiguration { /** Default port. */ http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/igfs/IgfsPath.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/igfs/IgfsPath.java b/modules/core/src/main/java/org/apache/ignite/igfs/IgfsPath.java index eb3c3f6..92e9f51 100644 --- a/modules/core/src/main/java/org/apache/ignite/igfs/IgfsPath.java +++ b/modules/core/src/main/java/org/apache/ignite/igfs/IgfsPath.java @@ -234,7 +234,6 @@ public final class IgfsPath implements Comparable, Externalizable, Bin } /** {@inheritDoc} */ - @SuppressWarnings("NullableProblems") @Override public int compareTo(IgfsPath o) { return path.compareTo(o.path); } http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/igfs/mapreduce/records/IgfsNewLineRecordResolver.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/igfs/mapreduce/records/IgfsNewLineRecordResolver.java b/modules/core/src/main/java/org/apache/ignite/igfs/mapreduce/records/IgfsNewLineRecordResolver.java index a5db7aa..0aa134e 100644 --- a/modules/core/src/main/java/org/apache/ignite/igfs/mapreduce/records/IgfsNewLineRecordResolver.java +++ b/modules/core/src/main/java/org/apache/ignite/igfs/mapreduce/records/IgfsNewLineRecordResolver.java @@ -53,7 +53,6 @@ public class IgfsNewLineRecordResolver extends IgfsByteDelimiterRecordResolver { * * @param b Artificial flag to differentiate from empty constructor. */ - @SuppressWarnings("UnusedParameters") private IgfsNewLineRecordResolver(boolean b) { super(new byte[] { SYM_CR, SYM_LF }, new byte[] { SYM_LF }); } http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/AsyncSupportAdapter.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/AsyncSupportAdapter.java b/modules/core/src/main/java/org/apache/ignite/internal/AsyncSupportAdapter.java index a4bb37b..409a3d2 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/AsyncSupportAdapter.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/AsyncSupportAdapter.java @@ -68,7 +68,6 @@ public class AsyncSupportAdapter implements Ignite } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Override public IgniteFuture future() { return future(true); } http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/GridEventConsumeHandler.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/GridEventConsumeHandler.java b/modules/core/src/main/java/org/apache/ignite/internal/GridEventConsumeHandler.java index ac568f0..58d0d9a 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/GridEventConsumeHandler.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/GridEventConsumeHandler.java @@ -71,7 +71,6 @@ class GridEventConsumeHandler implements GridContinuousHandler { }; /** Local callback. */ - @SuppressWarnings("FieldAccessedSynchronizedAndUnsynchronized") private IgniteBiPredicate cb; /** Filter. */ http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/GridJobSessionImpl.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/GridJobSessionImpl.java b/modules/core/src/main/java/org/apache/ignite/internal/GridJobSessionImpl.java index 6fc9969..e8e6645 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/GridJobSessionImpl.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/GridJobSessionImpl.java @@ -198,7 +198,6 @@ public class GridJobSessionImpl implements GridTaskSessionInternal { } /** {@inheritDoc} */ - @SuppressWarnings({"unchecked"}) @Override public V getAttribute(K key) { return ses.getAttribute(key); } @@ -233,7 +232,6 @@ public class GridJobSessionImpl implements GridTaskSessionInternal { } /** {@inheritDoc} */ - @SuppressWarnings({"unchecked"}) @Override public V waitForAttribute(K key, long timeout) throws InterruptedException { return ses.waitForAttribute(key, timeout); } @@ -271,7 +269,6 @@ public class GridJobSessionImpl implements GridTaskSessionInternal { } /** {@inheritDoc} */ - @SuppressWarnings({"unchecked"}) @Override public T loadCheckpoint(String key) { return ses.loadCheckpoint0(this, key); } http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/GridKernalGatewayImpl.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/GridKernalGatewayImpl.java b/modules/core/src/main/java/org/apache/ignite/internal/GridKernalGatewayImpl.java index 1f75d4b..75da88e 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/GridKernalGatewayImpl.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/GridKernalGatewayImpl.java @@ -71,7 +71,7 @@ public class GridKernalGatewayImpl implements GridKernalGateway, Serializable { } /** {@inheritDoc} */ - @SuppressWarnings({"LockAcquiredButNotSafelyReleased", "BusyWait"}) + @SuppressWarnings({"LockAcquiredButNotSafelyReleased"}) @Override public void readLock() throws IllegalStateException { if (stackTrace == null) stackTrace = stackTrace(); http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/GridLoggerProxy.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/GridLoggerProxy.java b/modules/core/src/main/java/org/apache/ignite/internal/GridLoggerProxy.java index 4b3befc..fb59da9 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/GridLoggerProxy.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/GridLoggerProxy.java @@ -80,7 +80,6 @@ public class GridLoggerProxy implements IgniteLogger, LifecycleAware, Externaliz * @param igniteInstanceName Ignite instance name (can be {@code null} for default grid). * @param id8 Node ID. */ - @SuppressWarnings({"IfMayBeConditional", "SimplifiableIfStatement"}) public GridLoggerProxy(IgniteLogger impl, @Nullable Object ctgr, @Nullable String igniteInstanceName, String id8) { assert impl != null; @@ -221,7 +220,6 @@ public class GridLoggerProxy implements IgniteLogger, LifecycleAware, Externaliz } /** {@inheritDoc} */ - @SuppressWarnings({"MismatchedQueryAndUpdateOfCollection"}) @Override public void readExternal(ObjectInput in) throws IOException, ClassNotFoundException { IgniteBiTuple t = stash.get(); http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/GridPluginComponent.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/GridPluginComponent.java b/modules/core/src/main/java/org/apache/ignite/internal/GridPluginComponent.java index 1e49e5c..3864e9f 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/GridPluginComponent.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/GridPluginComponent.java @@ -50,7 +50,6 @@ public class GridPluginComponent implements GridComponent { } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Override public void start() throws IgniteCheckedException { throw new UnsupportedOperationException(); } http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/IgniteInterruptedCheckedException.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/IgniteInterruptedCheckedException.java b/modules/core/src/main/java/org/apache/ignite/internal/IgniteInterruptedCheckedException.java index 556d39c..14c022f 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/IgniteInterruptedCheckedException.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/IgniteInterruptedCheckedException.java @@ -22,7 +22,6 @@ import org.apache.ignite.IgniteCheckedException; /** * This exception is used to wrap standard {@link InterruptedException} into {@link IgniteCheckedException}. */ -@SuppressWarnings({"TypeMayBeWeakened"}) public class IgniteInterruptedCheckedException extends IgniteCheckedException { /** */ private static final long serialVersionUID = 0L; http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/IgniteKernal.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/IgniteKernal.java b/modules/core/src/main/java/org/apache/ignite/internal/IgniteKernal.java index b200238..710fd09 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/IgniteKernal.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/IgniteKernal.java @@ -323,7 +323,6 @@ public class IgniteKernal implements IgniteEx, IgniteMXBean, Externalizable { private IgniteConfiguration cfg; /** */ - @SuppressWarnings({"FieldAccessedSynchronizedAndUnsynchronized"}) @GridToStringExclude private GridLoggerProxy log; @@ -716,7 +715,6 @@ public class IgniteKernal implements IgniteEx, IgniteMXBean, Externalizable { * @param evt Grid event. * @throws IgniteCheckedException If user threw exception during start. */ - @SuppressWarnings({"CatchGenericClass"}) private void notifyLifecycleBeans(LifecycleEventType evt) throws IgniteCheckedException { if (!cfg.isDaemon() && cfg.getLifecycleBeans() != null) { for (LifecycleBean bean : cfg.getLifecycleBeans()) @@ -736,7 +734,6 @@ public class IgniteKernal implements IgniteEx, IgniteMXBean, Externalizable { * * @param evt Grid event. */ - @SuppressWarnings({"CatchGenericClass"}) private void notifyLifecycleBeansEx(LifecycleEventType evt) { try { notifyLifecycleBeans(evt); @@ -773,7 +770,7 @@ public class IgniteKernal implements IgniteEx, IgniteMXBean, Externalizable { * @param hnd Default uncaught exception handler used by thread pools. * @throws IgniteCheckedException Thrown in case of any errors. */ - @SuppressWarnings({"CatchGenericClass", "unchecked"}) + @SuppressWarnings({"unchecked"}) public void start( final IgniteConfiguration cfg, ExecutorService utilityCachePool, @@ -1456,7 +1453,7 @@ public class IgniteKernal implements IgniteEx, IgniteMXBean, Externalizable { * @param notifyEnabled Update notifier flag. * @throws IgniteCheckedException thrown if was unable to set up attribute. */ - @SuppressWarnings({"SuspiciousMethodCalls", "unchecked", "TypeMayBeWeakened"}) + @SuppressWarnings({"unchecked", "TypeMayBeWeakened"}) private void fillNodeAttributes(boolean notifyEnabled) throws IgniteCheckedException { ctx.addNodeAttribute(ATTR_REBALANCE_POOL_SIZE, configuration().getRebalanceThreadPoolSize()); ctx.addNodeAttribute(ATTR_DATA_STREAMER_POOL_SIZE, configuration().getDataStreamerThreadPoolSize()); @@ -2175,7 +2172,6 @@ public class IgniteKernal implements IgniteEx, IgniteMXBean, Externalizable { /** * @return Language runtime. */ - @SuppressWarnings("ThrowableInstanceNeverThrown") private String getLanguage() { boolean scala = false; boolean groovy = false; http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/IgnitionEx.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/IgnitionEx.java b/modules/core/src/main/java/org/apache/ignite/internal/IgnitionEx.java index d3dde71..adc0068 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/IgnitionEx.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/IgnitionEx.java @@ -1749,7 +1749,7 @@ public class IgnitionEx { * @param startCtx Starting context. * @throws IgniteCheckedException If start failed. */ - @SuppressWarnings({"unchecked", "TooBroadScope"}) + @SuppressWarnings({"TooBroadScope"}) private void start0(GridStartContext startCtx) throws IgniteCheckedException { assert grid == null : "Grid is already started: " + name; @@ -2352,7 +2352,6 @@ public class IgnitionEx { * @param cfg Ignite configuration. * @throws IgniteCheckedException If failed. */ - @SuppressWarnings("unchecked") public void initializeDefaultCacheConfiguration(IgniteConfiguration cfg) throws IgniteCheckedException { List cacheCfgs = new ArrayList<>(); http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryClassDescriptor.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryClassDescriptor.java b/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryClassDescriptor.java index cd32120..73dee2b 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryClassDescriptor.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryClassDescriptor.java @@ -533,7 +533,6 @@ public class BinaryClassDescriptor { /** * @return binaryReadResolve() method */ - @SuppressWarnings("UnusedDeclaration") @Nullable Method getReadResolveMethod() { return readResolveMtd; } http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryMarshaller.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryMarshaller.java b/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryMarshaller.java index 87f9a22..bffd35a 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryMarshaller.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryMarshaller.java @@ -73,7 +73,6 @@ public class BinaryMarshaller extends AbstractNodeNameAwareMarshaller { *

* @param ctx Binary context. */ - @SuppressWarnings("UnusedDeclaration") private void setBinaryContext(BinaryContext ctx, IgniteConfiguration cfg) { ctx.configure(this, cfg); http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryObjectOffheapImpl.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryObjectOffheapImpl.java b/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryObjectOffheapImpl.java index 05f6963..7063c56 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryObjectOffheapImpl.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryObjectOffheapImpl.java @@ -425,7 +425,6 @@ public class BinaryObjectOffheapImpl extends BinaryObjectExImpl implements Exter } /** {@inheritDoc} */ - @SuppressWarnings("CloneDoesntCallSuperClone") @Override public BinaryObject clone() throws CloneNotSupportedException { return heapCopy(); } http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryTreeSet.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryTreeSet.java b/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryTreeSet.java index 2b01528..137dab9 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryTreeSet.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryTreeSet.java @@ -52,7 +52,6 @@ public class BinaryTreeSet implements Binarylizable { } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Override public void writeBinary(BinaryWriter writer) throws BinaryObjectException { BinaryRawWriter rawWriter = writer.rawWriter(); http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/binary/builder/BinaryObjectBuilderImpl.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/binary/builder/BinaryObjectBuilderImpl.java b/modules/core/src/main/java/org/apache/ignite/internal/binary/builder/BinaryObjectBuilderImpl.java index abd63cd..6bf9999 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/binary/builder/BinaryObjectBuilderImpl.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/binary/builder/BinaryObjectBuilderImpl.java @@ -199,7 +199,6 @@ public class BinaryObjectBuilderImpl implements BinaryObjectBuilder { * @param writer Writer. * @param serializer Serializer. */ - @SuppressWarnings("ResultOfMethodCallIgnored") void serializeTo(BinaryWriterExImpl writer, BinaryBuilderSerializer serializer) { try { writer.preWrite(registeredType ? null : clsNameToWrite); @@ -340,7 +339,6 @@ public class BinaryObjectBuilderImpl implements BinaryObjectBuilder { reader.position(start + BinaryUtils.length(reader, start)); } - //noinspection NumberEquality writer.postWrite(true, registeredType); // Update metadata if needed. http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/client/GridClientPartitionAffinity.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/client/GridClientPartitionAffinity.java b/modules/core/src/main/java/org/apache/ignite/internal/client/GridClientPartitionAffinity.java index 21f4abe..36120d8 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/client/GridClientPartitionAffinity.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/client/GridClientPartitionAffinity.java @@ -41,7 +41,6 @@ import org.apache.ignite.internal.util.typedef.internal.U; * * */ -@SuppressWarnings("NullableProblems") public class GridClientPartitionAffinity implements GridClientDataAffinity, GridClientTopologyListener { /** * This resolver is used to provide alternate hash ID, other than node ID. http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/client/impl/connection/GridClientNioTcpConnection.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/client/impl/connection/GridClientNioTcpConnection.java b/modules/core/src/main/java/org/apache/ignite/internal/client/impl/connection/GridClientNioTcpConnection.java index 896fbd8..8a9b0f1 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/client/impl/connection/GridClientNioTcpConnection.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/client/impl/connection/GridClientNioTcpConnection.java @@ -514,7 +514,7 @@ public class GridClientNioTcpConnection extends GridClientConnection { * * @param res Incoming response data. */ - @SuppressWarnings({"unchecked", "TooBroadScope"}) + @SuppressWarnings({"unchecked"}) void handleResponse(GridClientMessage res) throws IOException { lastMsgRcvTime = System.currentTimeMillis(); http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/client/router/GridTcpRouterConfiguration.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/client/router/GridTcpRouterConfiguration.java b/modules/core/src/main/java/org/apache/ignite/internal/client/router/GridTcpRouterConfiguration.java index e37ffea..126b5b8 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/client/router/GridTcpRouterConfiguration.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/client/router/GridTcpRouterConfiguration.java @@ -63,7 +63,6 @@ public class GridTcpRouterConfiguration { private int port = DFLT_TCP_PORT; /** Port range. */ - @SuppressWarnings("RedundantFieldInitialization") private int portRange = DFLT_PORT_RANGE; /** No delay. */ http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/client/router/impl/GridRouterCommandLineStartup.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/client/router/impl/GridRouterCommandLineStartup.java b/modules/core/src/main/java/org/apache/ignite/internal/client/router/impl/GridRouterCommandLineStartup.java index 6889e73..fc42b6e 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/client/router/impl/GridRouterCommandLineStartup.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/client/router/impl/GridRouterCommandLineStartup.java @@ -39,7 +39,6 @@ import static org.apache.ignite.internal.IgniteVersionUtils.COPYRIGHT; */ public class GridRouterCommandLineStartup { /** Logger. */ - @SuppressWarnings("FieldCanBeLocal") private IgniteLogger log; /** TCP router. */