ignite-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nizhi...@apache.org
Subject [01/12] ignite git commit: IGNITE-9312: Remove unnecessary @SuppressWarnings annotation - Fixes #4632.
Date Fri, 02 Nov 2018 09:34:57 GMT
Repository: ignite
Updated Branches:
  refs/heads/master 5cf44e8e3 -> 9e35993c0


http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/test/java/org/apache/ignite/sqltests/BaseSqlTest.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/test/java/org/apache/ignite/sqltests/BaseSqlTest.java b/modules/indexing/src/test/java/org/apache/ignite/sqltests/BaseSqlTest.java
index 9431cfa..83d35a8 100644
--- a/modules/indexing/src/test/java/org/apache/ignite/sqltests/BaseSqlTest.java
+++ b/modules/indexing/src/test/java/org/apache/ignite/sqltests/BaseSqlTest.java
@@ -486,7 +486,6 @@ public class BaseSqlTest extends GridCommonAbstractTest {
      * @param from Collection which copy is left argument of subtraction.
      * @param toRemove Right argument of subtraction.
      */
-    @SuppressWarnings("UseBulkOperation")
     private static Collection removeFromCopy(Collection<?> from, Collection<?>
toRemove) {
         List<?> fromCp = new ArrayList<>(from);
 

http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/jta/src/main/java/org/apache/ignite/cache/jta/websphere/WebSphereTmFactory.java
----------------------------------------------------------------------
diff --git a/modules/jta/src/main/java/org/apache/ignite/cache/jta/websphere/WebSphereTmFactory.java
b/modules/jta/src/main/java/org/apache/ignite/cache/jta/websphere/WebSphereTmFactory.java
index 84024ee..cf398e2 100644
--- a/modules/jta/src/main/java/org/apache/ignite/cache/jta/websphere/WebSphereTmFactory.java
+++ b/modules/jta/src/main/java/org/apache/ignite/cache/jta/websphere/WebSphereTmFactory.java
@@ -201,7 +201,6 @@ public class WebSphereTmFactory implements Factory<TransactionManager>
{
         }
 
         /** {@inheritDoc} */
-        @SuppressWarnings("SimplifiableIfStatement")
         @Override public boolean enlistResource(final XAResource xaRes) throws RollbackException,
IllegalStateException,
             SystemException {
             if (xaRes == null)

http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/jta/src/test/java/org/apache/ignite/internal/processors/cache/jta/AbstractCacheJtaSelfTest.java
----------------------------------------------------------------------
diff --git a/modules/jta/src/test/java/org/apache/ignite/internal/processors/cache/jta/AbstractCacheJtaSelfTest.java
b/modules/jta/src/test/java/org/apache/ignite/internal/processors/cache/jta/AbstractCacheJtaSelfTest.java
index 89fb72f..5111b44 100644
--- a/modules/jta/src/test/java/org/apache/ignite/internal/processors/cache/jta/AbstractCacheJtaSelfTest.java
+++ b/modules/jta/src/test/java/org/apache/ignite/internal/processors/cache/jta/AbstractCacheJtaSelfTest.java
@@ -140,7 +140,6 @@ public abstract class AbstractCacheJtaSelfTest extends GridCacheAbstractSelfTest
     /**
      * @throws Exception If failed.
      */
-    @SuppressWarnings("ConstantConditions")
     public void testJtaTwoCaches() throws Exception {
         UserTransaction jtaTx = jotm.getUserTransaction();
 

http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/kafka/src/test/java/org/apache/ignite/stream/kafka/connect/IgniteSinkConnectorTest.java
----------------------------------------------------------------------
diff --git a/modules/kafka/src/test/java/org/apache/ignite/stream/kafka/connect/IgniteSinkConnectorTest.java
b/modules/kafka/src/test/java/org/apache/ignite/stream/kafka/connect/IgniteSinkConnectorTest.java
index e3072ba..4fcc4a4 100644
--- a/modules/kafka/src/test/java/org/apache/ignite/stream/kafka/connect/IgniteSinkConnectorTest.java
+++ b/modules/kafka/src/test/java/org/apache/ignite/stream/kafka/connect/IgniteSinkConnectorTest.java
@@ -90,7 +90,6 @@ public class IgniteSinkConnectorTest extends GridCommonAbstractTest {
     private static Ignite grid;
 
     /** {@inheritDoc} */
-    @SuppressWarnings("unchecked")
     @Override protected void beforeTest() throws Exception {
         kafkaBroker = new TestKafkaBroker();
 
@@ -128,7 +127,6 @@ public class IgniteSinkConnectorTest extends GridCommonAbstractTest {
     }
 
     /** {@inheritDoc} */
-    @SuppressWarnings("unchecked")
     @Override protected void beforeTestsStarted() throws Exception {
         IgniteConfiguration cfg = loadConfiguration("modules/kafka/src/test/resources/example-ignite.xml");
 

http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/kafka/src/test/java/org/apache/ignite/stream/kafka/connect/IgniteSourceConnectorTest.java
----------------------------------------------------------------------
diff --git a/modules/kafka/src/test/java/org/apache/ignite/stream/kafka/connect/IgniteSourceConnectorTest.java
b/modules/kafka/src/test/java/org/apache/ignite/stream/kafka/connect/IgniteSourceConnectorTest.java
index 8717044..2a882f0 100644
--- a/modules/kafka/src/test/java/org/apache/ignite/stream/kafka/connect/IgniteSourceConnectorTest.java
+++ b/modules/kafka/src/test/java/org/apache/ignite/stream/kafka/connect/IgniteSourceConnectorTest.java
@@ -87,7 +87,6 @@ public class IgniteSourceConnectorTest extends GridCommonAbstractTest {
     private static Ignite grid;
 
     /** {@inheritDoc} */
-    @SuppressWarnings("unchecked")
     @Override protected void beforeTestsStarted() throws Exception {
         IgniteConfiguration cfg = loadConfiguration("modules/kafka/src/test/resources/example-ignite.xml");
 

http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/log4j/src/test/java/org/apache/ignite/logger/log4j/GridLog4jConfigUpdateTest.java
----------------------------------------------------------------------
diff --git a/modules/log4j/src/test/java/org/apache/ignite/logger/log4j/GridLog4jConfigUpdateTest.java
b/modules/log4j/src/test/java/org/apache/ignite/logger/log4j/GridLog4jConfigUpdateTest.java
index c0d9591..debbb37 100644
--- a/modules/log4j/src/test/java/org/apache/ignite/logger/log4j/GridLog4jConfigUpdateTest.java
+++ b/modules/log4j/src/test/java/org/apache/ignite/logger/log4j/GridLog4jConfigUpdateTest.java
@@ -51,7 +51,6 @@ public class GridLog4jConfigUpdateTest extends TestCase {
      * Check that changing log4j config file causes the logger configuration to be updated.
      * String-accepting constructor is used.
      */
-    @SuppressWarnings("ResultOfMethodCallIgnored")
     public void testConfigChangeStringConstructor() throws Exception {
         checkConfigUpdate(new Log4JLoggerSupplier() {
             @Override public Log4JLogger get(File cfgFile) throws Exception {
@@ -64,7 +63,6 @@ public class GridLog4jConfigUpdateTest extends TestCase {
      * Check that changing log4j config file causes the logger configuration to be updated.
      * String-accepting constructor is used.
      */
-    @SuppressWarnings("ResultOfMethodCallIgnored")
     public void testConfigChangeStringConstructorDefaultDelay() throws Exception {
         checkConfigUpdate(new Log4JLoggerSupplier() {
             @Override public Log4JLogger get(File cfgFile) throws Exception {
@@ -77,7 +75,6 @@ public class GridLog4jConfigUpdateTest extends TestCase {
      * Check that changing log4j config file causes the logger configuration to be updated.
      * File-accepting constructor is used.
      */
-    @SuppressWarnings("ResultOfMethodCallIgnored")
     public void testConfigChangeFileConstructor() throws Exception {
         checkConfigUpdate(new Log4JLoggerSupplier() {
             @Override public Log4JLogger get(File cfgFile) throws Exception {
@@ -90,7 +87,6 @@ public class GridLog4jConfigUpdateTest extends TestCase {
      * Check that changing log4j config file causes the logger configuration to be updated.
      * File-accepting constructor is used.
      */
-    @SuppressWarnings("ResultOfMethodCallIgnored")
     public void testConfigChangeUrlConstructor() throws Exception {
         checkConfigUpdate(new Log4JLoggerSupplier() {
             @Override public Log4JLogger get(File cfgFile) throws Exception {

http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/log4j2/src/test/java/org/apache/ignite/logger/log4j2/Log4j2ConfigUpdateTest.java
----------------------------------------------------------------------
diff --git a/modules/log4j2/src/test/java/org/apache/ignite/logger/log4j2/Log4j2ConfigUpdateTest.java
b/modules/log4j2/src/test/java/org/apache/ignite/logger/log4j2/Log4j2ConfigUpdateTest.java
index d9f7517..ad8f7d9 100644
--- a/modules/log4j2/src/test/java/org/apache/ignite/logger/log4j2/Log4j2ConfigUpdateTest.java
+++ b/modules/log4j2/src/test/java/org/apache/ignite/logger/log4j2/Log4j2ConfigUpdateTest.java
@@ -56,7 +56,6 @@ public class Log4j2ConfigUpdateTest extends TestCase {
      * Check that changing log4j2 config file causes the logger configuration to be updated.
      * String-accepting constructor is used.
      */
-    @SuppressWarnings("ResultOfMethodCallIgnored")
     public void testConfigChangeStringConstructor() throws Exception {
         checkConfigUpdate(new Log4J2LoggerSupplier() {
             @Override public Log4J2Logger get(File cfgFile) throws Exception {
@@ -69,7 +68,6 @@ public class Log4j2ConfigUpdateTest extends TestCase {
      * Check that changing log4j config file causes the logger configuration to be updated.
      * File-accepting constructor is used.
      */
-    @SuppressWarnings("ResultOfMethodCallIgnored")
     public void testConfigChangeFileConstructor() throws Exception {
         checkConfigUpdate(new Log4J2LoggerSupplier() {
             @Override public Log4J2Logger get(File cfgFile) throws Exception {
@@ -82,7 +80,6 @@ public class Log4j2ConfigUpdateTest extends TestCase {
      * Check that changing log4j config file causes the logger configuration to be updated.
      * File-accepting constructor is used.
      */
-    @SuppressWarnings("ResultOfMethodCallIgnored")
     public void testConfigChangeUrlConstructor() throws Exception {
         checkConfigUpdate(new Log4J2LoggerSupplier() {
             @Override public Log4J2Logger get(File cfgFile) throws Exception {

http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/ml/src/main/java/org/apache/ignite/ml/dataset/impl/local/LocalDatasetBuilder.java
----------------------------------------------------------------------
diff --git a/modules/ml/src/main/java/org/apache/ignite/ml/dataset/impl/local/LocalDatasetBuilder.java
b/modules/ml/src/main/java/org/apache/ignite/ml/dataset/impl/local/LocalDatasetBuilder.java
index 2586759..6e0df2f 100644
--- a/modules/ml/src/main/java/org/apache/ignite/ml/dataset/impl/local/LocalDatasetBuilder.java
+++ b/modules/ml/src/main/java/org/apache/ignite/ml/dataset/impl/local/LocalDatasetBuilder.java
@@ -72,7 +72,6 @@ public class LocalDatasetBuilder<K, V> implements DatasetBuilder<K,
V> {
     }
 
     /** {@inheritDoc} */
-    @SuppressWarnings("unchecked")
     @Override public <C extends Serializable, D extends AutoCloseable> LocalDataset<C,
D> build(
         PartitionContextBuilder<K, V, C> partCtxBuilder, PartitionDataBuilder<K,
V, C, D> partDataBuilder) {
         List<C> ctxList = new ArrayList<>();

http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/ml/src/test/java/org/apache/ignite/ml/math/primitives/matrix/SparseMatrixConstructorTest.java
----------------------------------------------------------------------
diff --git a/modules/ml/src/test/java/org/apache/ignite/ml/math/primitives/matrix/SparseMatrixConstructorTest.java
b/modules/ml/src/test/java/org/apache/ignite/ml/math/primitives/matrix/SparseMatrixConstructorTest.java
index 76b76e7..f66fad0 100644
--- a/modules/ml/src/test/java/org/apache/ignite/ml/math/primitives/matrix/SparseMatrixConstructorTest.java
+++ b/modules/ml/src/test/java/org/apache/ignite/ml/math/primitives/matrix/SparseMatrixConstructorTest.java
@@ -48,7 +48,6 @@ public class SparseMatrixConstructorTest {
         SparseMatrix m = new SparseMatrix(1, 1);
         //noinspection EqualsWithItself
         assertTrue("Matrix is expected to be equal to self.", m.equals(m));
-        //noinspection ObjectEqualsNull
         assertFalse("Matrix is expected to be not equal to null.", m.equals(null));
     }
 }

http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/ml/src/test/java/org/apache/ignite/ml/math/primitives/vector/AbstractVectorTest.java
----------------------------------------------------------------------
diff --git a/modules/ml/src/test/java/org/apache/ignite/ml/math/primitives/vector/AbstractVectorTest.java
b/modules/ml/src/test/java/org/apache/ignite/ml/math/primitives/vector/AbstractVectorTest.java
index bfc9557..b790f8d 100644
--- a/modules/ml/src/test/java/org/apache/ignite/ml/math/primitives/vector/AbstractVectorTest.java
+++ b/modules/ml/src/test/java/org/apache/ignite/ml/math/primitives/vector/AbstractVectorTest.java
@@ -353,7 +353,6 @@ public class AbstractVectorTest {
      * @param storage {@link VectorStorage}
      * @return AbstractVector.
      */
-    @SuppressWarnings("ClassWithoutNoArgConstructor")
     private AbstractVector getAbstractVector(VectorStorage storage) {
         return new AbstractVector(storage) { // TODO: IGNTIE-5723, find out how to fix warning
about missing constructor
             /** {@inheritDoc} */

http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/ml/src/test/java/org/apache/ignite/ml/math/primitives/vector/MatrixVectorViewTest.java
----------------------------------------------------------------------
diff --git a/modules/ml/src/test/java/org/apache/ignite/ml/math/primitives/vector/MatrixVectorViewTest.java
b/modules/ml/src/test/java/org/apache/ignite/ml/math/primitives/vector/MatrixVectorViewTest.java
index 922a1ef..6541570 100644
--- a/modules/ml/src/test/java/org/apache/ignite/ml/math/primitives/vector/MatrixVectorViewTest.java
+++ b/modules/ml/src/test/java/org/apache/ignite/ml/math/primitives/vector/MatrixVectorViewTest.java
@@ -94,7 +94,6 @@ public class MatrixVectorViewTest {
     /** */
     @Test(expected = AssertionError.class)
     public void parentNullTest() {
-        //noinspection ConstantConditions
         assertEquals(IMPOSSIBLE_SIZE,
             new VectorizedViewMatrix(null, 1, 1, 1, 1).size());
     }
@@ -102,7 +101,6 @@ public class MatrixVectorViewTest {
     /** */
     @Test(expected = IndexException.class)
     public void rowNegativeTest() {
-        //noinspection ConstantConditions
         assertEquals(IMPOSSIBLE_SIZE,
             new VectorizedViewMatrix(parent, -1, 1, 1, 1).size());
     }
@@ -110,7 +108,6 @@ public class MatrixVectorViewTest {
     /** */
     @Test(expected = IndexException.class)
     public void colNegativeTest() {
-        //noinspection ConstantConditions
         assertEquals(IMPOSSIBLE_SIZE,
             new VectorizedViewMatrix(parent, 1, -1, 1, 1).size());
     }
@@ -118,7 +115,6 @@ public class MatrixVectorViewTest {
     /** */
     @Test(expected = IndexException.class)
     public void rowTooLargeTest() {
-        //noinspection ConstantConditions
         assertEquals(IMPOSSIBLE_SIZE,
             new VectorizedViewMatrix(parent, parent.rowSize() + 1, 1, 1, 1).size());
     }
@@ -126,7 +122,6 @@ public class MatrixVectorViewTest {
     /** */
     @Test(expected = IndexException.class)
     public void colTooLargeTest() {
-        //noinspection ConstantConditions
         assertEquals(IMPOSSIBLE_SIZE,
             new VectorizedViewMatrix(parent, 1, parent.columnSize() + 1, 1, 1).size());
     }
@@ -134,7 +129,6 @@ public class MatrixVectorViewTest {
     /** */
     @Test(expected = AssertionError.class)
     public void rowStrideNegativeTest() {
-        //noinspection ConstantConditions
         assertEquals(IMPOSSIBLE_SIZE,
             new VectorizedViewMatrix(parent, 1, 1, -1, 1).size());
     }
@@ -142,7 +136,6 @@ public class MatrixVectorViewTest {
     /** */
     @Test(expected = AssertionError.class)
     public void colStrideNegativeTest() {
-        //noinspection ConstantConditions
         assertEquals(IMPOSSIBLE_SIZE,
             new VectorizedViewMatrix(parent, 1, 1, 1, -1).size());
     }
@@ -150,7 +143,6 @@ public class MatrixVectorViewTest {
     /** */
     @Test(expected = AssertionError.class)
     public void rowStrideTooLargeTest() {
-        //noinspection ConstantConditions
         assertEquals(IMPOSSIBLE_SIZE,
             new VectorizedViewMatrix(parent, 1, 1, parent.rowSize() + 1, 1).size());
     }
@@ -158,7 +150,6 @@ public class MatrixVectorViewTest {
     /** */
     @Test(expected = AssertionError.class)
     public void colStrideTooLargeTest() {
-        //noinspection ConstantConditions
         assertEquals(IMPOSSIBLE_SIZE,
             new VectorizedViewMatrix(parent, 1, 1, 1, parent.columnSize() + 1).size());
     }
@@ -166,7 +157,6 @@ public class MatrixVectorViewTest {
     /** */
     @Test(expected = AssertionError.class)
     public void bothStridesZeroTest() {
-        //noinspection ConstantConditions
         assertEquals(IMPOSSIBLE_SIZE,
             new VectorizedViewMatrix(parent, 1, 1, 0, 0).size());
     }

http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/rest-http/src/main/java/org/apache/ignite/internal/processors/rest/protocols/http/jetty/GridJettyRestHandler.java
----------------------------------------------------------------------
diff --git a/modules/rest-http/src/main/java/org/apache/ignite/internal/processors/rest/protocols/http/jetty/GridJettyRestHandler.java
b/modules/rest-http/src/main/java/org/apache/ignite/internal/processors/rest/protocols/http/jetty/GridJettyRestHandler.java
index c0a4fe1..000f980 100644
--- a/modules/rest-http/src/main/java/org/apache/ignite/internal/processors/rest/protocols/http/jetty/GridJettyRestHandler.java
+++ b/modules/rest-http/src/main/java/org/apache/ignite/internal/processors/rest/protocols/http/jetty/GridJettyRestHandler.java
@@ -979,7 +979,6 @@ public class GridJettyRestHandler extends AbstractHandler {
      * @param req Request.
      * @return Map of parsed parameters.
      */
-    @SuppressWarnings({"unchecked"})
     private Map<String, Object> parameters(ServletRequest req) {
         Map<String, String[]> params = req.getParameterMap();
 

http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/rest-http/src/main/java/org/apache/ignite/internal/processors/rest/protocols/http/jetty/GridJettyRestProtocol.java
----------------------------------------------------------------------
diff --git a/modules/rest-http/src/main/java/org/apache/ignite/internal/processors/rest/protocols/http/jetty/GridJettyRestProtocol.java
b/modules/rest-http/src/main/java/org/apache/ignite/internal/processors/rest/protocols/http/jetty/GridJettyRestProtocol.java
index e5c1a04..2c9c137 100644
--- a/modules/rest-http/src/main/java/org/apache/ignite/internal/processors/rest/protocols/http/jetty/GridJettyRestProtocol.java
+++ b/modules/rest-http/src/main/java/org/apache/ignite/internal/processors/rest/protocols/http/jetty/GridJettyRestProtocol.java
@@ -112,7 +112,6 @@ public class GridJettyRestProtocol extends GridRestProtocolAdapter {
     }
 
     /** {@inheritDoc} */
-    @SuppressWarnings("BusyWait")
     @Override public void start(GridRestProtocolHandler hnd) throws IgniteCheckedException
{
         assert ctx.config().getConnectorConfiguration() != null;
 
@@ -208,7 +207,6 @@ public class GridJettyRestProtocol extends GridRestProtocolAdapter {
      * @throws IgniteCheckedException If failed.
      * @return {@code True} if Jetty started.
      */
-    @SuppressWarnings("IfMayBeConditional")
     private boolean startJetty() throws IgniteCheckedException {
         try {
             httpSrv.start();

http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/rocketmq/src/test/java/org/apache/ignite/stream/rocketmq/RocketMQStreamerTest.java
----------------------------------------------------------------------
diff --git a/modules/rocketmq/src/test/java/org/apache/ignite/stream/rocketmq/RocketMQStreamerTest.java
b/modules/rocketmq/src/test/java/org/apache/ignite/stream/rocketmq/RocketMQStreamerTest.java
index 44b0030..606a6d1 100644
--- a/modules/rocketmq/src/test/java/org/apache/ignite/stream/rocketmq/RocketMQStreamerTest.java
+++ b/modules/rocketmq/src/test/java/org/apache/ignite/stream/rocketmq/RocketMQStreamerTest.java
@@ -71,7 +71,6 @@ public class RocketMQStreamerTest extends GridCommonAbstractTest {
     }
 
     /** {@inheritDoc} */
-    @SuppressWarnings("unchecked")
     @Override protected void beforeTestsStarted() throws Exception {
         testRocketMQServer = new TestRocketMQServer(log);
     }

http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/spring/src/test/java/org/apache/ignite/internal/GridFactorySelfTest.java
----------------------------------------------------------------------
diff --git a/modules/spring/src/test/java/org/apache/ignite/internal/GridFactorySelfTest.java
b/modules/spring/src/test/java/org/apache/ignite/internal/GridFactorySelfTest.java
index fd832a0..d2d8627 100644
--- a/modules/spring/src/test/java/org/apache/ignite/internal/GridFactorySelfTest.java
+++ b/modules/spring/src/test/java/org/apache/ignite/internal/GridFactorySelfTest.java
@@ -83,7 +83,6 @@ import static org.apache.ignite.IgniteSystemProperties.IGNITE_OVERRIDE_MCAST_GRP
  * Tests for {@link org.apache.ignite.Ignition}.
  * @see GridFactoryVmShutdownTest
  */
-@SuppressWarnings("UnusedDeclaration")
 @GridCommonTest(group = "NonDistributed Kernal Self")
 public class GridFactorySelfTest extends GridCommonAbstractTest {
     /** IP finder. */
@@ -364,7 +363,6 @@ public class GridFactorySelfTest extends GridCommonAbstractTest {
     /**
      * @throws Exception If failed.
      */
-    @SuppressWarnings({"SynchronizationOnLocalVariableOrMethodParameter"})
     public void testStartMultipleGridsFromSpring() throws Exception {
         File cfgFile =
             GridTestUtils.resolveIgnitePath(GridTestProperties.getProperty("loader.self.multipletest.config"));

http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/spring/src/test/java/org/apache/ignite/internal/processors/resource/GridResourceProcessorSelfTest.java
----------------------------------------------------------------------
diff --git a/modules/spring/src/test/java/org/apache/ignite/internal/processors/resource/GridResourceProcessorSelfTest.java
b/modules/spring/src/test/java/org/apache/ignite/internal/processors/resource/GridResourceProcessorSelfTest.java
index f3aecf8..12535a7e 100644
--- a/modules/spring/src/test/java/org/apache/ignite/internal/processors/resource/GridResourceProcessorSelfTest.java
+++ b/modules/spring/src/test/java/org/apache/ignite/internal/processors/resource/GridResourceProcessorSelfTest.java
@@ -174,7 +174,7 @@ public class GridResourceProcessorSelfTest extends GridCommonAbstractTest
{
         private String str2;
 
         /** */
-        @SuppressWarnings({"UnusedDeclaration"}) @TestAnnotation3
+        @TestAnnotation3
         private String str7;
 
         /**
@@ -226,11 +226,11 @@ public class GridResourceProcessorSelfTest extends GridCommonAbstractTest
{
                 private String str6;
 
                 private Callable<String> c = new Callable<String>() {
-                    @SuppressWarnings({"UnusedDeclaration"}) @TestAnnotation
+                    @TestAnnotation
                     private String cStr;
 
                     private Runnable r = new Runnable() {
-                        @SuppressWarnings({"UnusedDeclaration"}) @TestAnnotation
+                        @TestAnnotation
                         private String rStr;
 
                         @Override public void run() {
@@ -471,7 +471,7 @@ public class GridResourceProcessorSelfTest extends GridCommonAbstractTest
{
      */
     private static final class Test1 {
         /** */
-        @SuppressWarnings({"unused", "UnusedDeclaration"})
+        @SuppressWarnings({"unused"})
         @TestAnnotation1
         private String val1;
     }

http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/spring/src/test/java/org/apache/ignite/internal/processors/resource/GridSpringResourceInjectionSelfTest.java
----------------------------------------------------------------------
diff --git a/modules/spring/src/test/java/org/apache/ignite/internal/processors/resource/GridSpringResourceInjectionSelfTest.java
b/modules/spring/src/test/java/org/apache/ignite/internal/processors/resource/GridSpringResourceInjectionSelfTest.java
index 7f89b32..afb34b4 100644
--- a/modules/spring/src/test/java/org/apache/ignite/internal/processors/resource/GridSpringResourceInjectionSelfTest.java
+++ b/modules/spring/src/test/java/org/apache/ignite/internal/processors/resource/GridSpringResourceInjectionSelfTest.java
@@ -218,7 +218,6 @@ public class GridSpringResourceInjectionSelfTest extends GridCommonAbstractTest
     /**
      * @throws Exception If failed.
      */
-    @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
     public void testClosureMethodWithResourceClassWithMultipleBeans() throws Exception {
         IgniteConfiguration anotherCfg = new IgniteConfiguration();
         anotherCfg.setIgniteInstanceName("anotherGrid");
@@ -330,7 +329,6 @@ public class GridSpringResourceInjectionSelfTest extends GridCommonAbstractTest
      * @param expE Expected exception type.
      * @param expEMsg Expected exception message.
      */
-    @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
     private void assertError(final IgniteCallable<?> job, final Ignite grid, Class<?
extends Throwable> expE,
         String expEMsg) {
         GridTestUtils.assertThrowsAnyCause(log, new Callable<Object>() {

http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/spring/src/test/java/org/apache/ignite/p2p/GridP2PUserVersionChangeSelfTest.java
----------------------------------------------------------------------
diff --git a/modules/spring/src/test/java/org/apache/ignite/p2p/GridP2PUserVersionChangeSelfTest.java
b/modules/spring/src/test/java/org/apache/ignite/p2p/GridP2PUserVersionChangeSelfTest.java
index 46da3cc..96cae61 100644
--- a/modules/spring/src/test/java/org/apache/ignite/p2p/GridP2PUserVersionChangeSelfTest.java
+++ b/modules/spring/src/test/java/org/apache/ignite/p2p/GridP2PUserVersionChangeSelfTest.java
@@ -58,7 +58,7 @@ import static org.apache.ignite.events.EventType.EVT_TASK_UNDEPLOYED;
  * 3. The test should execute a task in SHARED_UNDEPLOY mode, restart a node with same version
and
  *      make sure that a new class loader is created on remote node.
  */
-@SuppressWarnings({"ProhibitedExceptionDeclared", "ObjectEquality", "unchecked"})
+@SuppressWarnings({"ProhibitedExceptionDeclared", "unchecked"})
 public class GridP2PUserVersionChangeSelfTest extends GridCommonAbstractTest {
     /** Current deployment mode. */
     private DeploymentMode depMode;

http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/storm/src/test/java/org/apache/ignite/stream/storm/StormIgniteStreamerSelfTest.java
----------------------------------------------------------------------
diff --git a/modules/storm/src/test/java/org/apache/ignite/stream/storm/StormIgniteStreamerSelfTest.java
b/modules/storm/src/test/java/org/apache/ignite/stream/storm/StormIgniteStreamerSelfTest.java
index e2547b1..b5295ad 100644
--- a/modules/storm/src/test/java/org/apache/ignite/stream/storm/StormIgniteStreamerSelfTest.java
+++ b/modules/storm/src/test/java/org/apache/ignite/stream/storm/StormIgniteStreamerSelfTest.java
@@ -62,7 +62,6 @@ public class StormIgniteStreamerSelfTest extends GridCommonAbstractTest
{
     private static final int STORM_EXECUTORS = 2;
 
     /** {@inheritDoc} */
-    @SuppressWarnings("unchecked")
     @Override protected void beforeTest() throws Exception {
         IgniteConfiguration cfg = loadConfiguration(GRID_CONF_FILE);
 

http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/urideploy/src/main/java/org/apache/ignite/spi/deployment/uri/GridUriDeploymentDiscovery.java
----------------------------------------------------------------------
diff --git a/modules/urideploy/src/main/java/org/apache/ignite/spi/deployment/uri/GridUriDeploymentDiscovery.java
b/modules/urideploy/src/main/java/org/apache/ignite/spi/deployment/uri/GridUriDeploymentDiscovery.java
index 69e016a..e98a9b8 100644
--- a/modules/urideploy/src/main/java/org/apache/ignite/spi/deployment/uri/GridUriDeploymentDiscovery.java
+++ b/modules/urideploy/src/main/java/org/apache/ignite/spi/deployment/uri/GridUriDeploymentDiscovery.java
@@ -93,7 +93,6 @@ final class GridUriDeploymentDiscovery {
      * @param dir Directory which should be scanned.
      * @param rsrcs Set which will be filled in.
      */
-    @SuppressWarnings({"UnusedCatchParameter"})
     private static void findResourcesInDirectory(GridUriDeploymentFileResourceLoader clsLdr,
File dir,
         Set<Class<? extends ComputeTask<?, ?>>> rsrcs) {
         assert dir.isDirectory() == true;

http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/urideploy/src/main/java/org/apache/ignite/spi/deployment/uri/GridUriDeploymentFileProcessor.java
----------------------------------------------------------------------
diff --git a/modules/urideploy/src/main/java/org/apache/ignite/spi/deployment/uri/GridUriDeploymentFileProcessor.java
b/modules/urideploy/src/main/java/org/apache/ignite/spi/deployment/uri/GridUriDeploymentFileProcessor.java
index edde878..238b710 100644
--- a/modules/urideploy/src/main/java/org/apache/ignite/spi/deployment/uri/GridUriDeploymentFileProcessor.java
+++ b/modules/urideploy/src/main/java/org/apache/ignite/spi/deployment/uri/GridUriDeploymentFileProcessor.java
@@ -331,7 +331,6 @@ final class GridUriDeploymentFileProcessor {
      * @throws org.apache.ignite.spi.IgniteSpiException Thrown if it's impossible to open
file.
      * @return List of tasks from descriptor.
      */
-    @SuppressWarnings({"ClassLoader2Instantiation"})
     private static GridUriDeploymentFileProcessorResult processWithDescriptorFile(GridUriDeploymentSpringDocument
doc,
         File file, String uri, IgniteLogger log) throws IgniteSpiException {
         ClassLoader clsLdr = GridUriDeploymentClassLoaderFactory.create(U.gridClassLoader(),
file, log);

http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/urideploy/src/main/java/org/apache/ignite/spi/deployment/uri/UriDeploymentSpi.java
----------------------------------------------------------------------
diff --git a/modules/urideploy/src/main/java/org/apache/ignite/spi/deployment/uri/UriDeploymentSpi.java
b/modules/urideploy/src/main/java/org/apache/ignite/spi/deployment/uri/UriDeploymentSpi.java
index bea3132..9fcff9a 100644
--- a/modules/urideploy/src/main/java/org/apache/ignite/spi/deployment/uri/UriDeploymentSpi.java
+++ b/modules/urideploy/src/main/java/org/apache/ignite/spi/deployment/uri/UriDeploymentSpi.java
@@ -346,7 +346,6 @@ public class UriDeploymentSpi extends IgniteSpiAdapter implements DeploymentSpi
     private boolean checkMd5;
 
     /** */
-    @SuppressWarnings({"CollectionDeclaredAsConcreteClass"})
     private final LinkedList<GridUriDeploymentUnitDescriptor> unitLoaders = new LinkedList<>();
 
     /** */
@@ -374,7 +373,6 @@ public class UriDeploymentSpi extends IgniteSpiAdapter implements DeploymentSpi
     private IgniteLogger log;
 
     /** NOTE: flag for test purposes only. */
-    @SuppressWarnings("UnusedDeclaration")
     private boolean delayOnNewOrUpdatedFile;
 
     /** Configured scanners. */

http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/urideploy/src/main/java/org/apache/ignite/spi/deployment/uri/scanners/http/UriDeploymentHttpScanner.java
----------------------------------------------------------------------
diff --git a/modules/urideploy/src/main/java/org/apache/ignite/spi/deployment/uri/scanners/http/UriDeploymentHttpScanner.java
b/modules/urideploy/src/main/java/org/apache/ignite/spi/deployment/uri/scanners/http/UriDeploymentHttpScanner.java
index 7fe3602..390686c 100644
--- a/modules/urideploy/src/main/java/org/apache/ignite/spi/deployment/uri/scanners/http/UriDeploymentHttpScanner.java
+++ b/modules/urideploy/src/main/java/org/apache/ignite/spi/deployment/uri/scanners/http/UriDeploymentHttpScanner.java
@@ -278,7 +278,6 @@ public class UriDeploymentHttpScanner implements UriDeploymentScanner
{
          * @param files Files to process.
          * @param scanCtx Scan context.
          */
-        @SuppressWarnings("unchecked")
         private void processHttp(Collection<String> files, UriDeploymentScannerContext
scanCtx) {
             Set<String> urls = getUrls(scanDir, scanCtx);
 
@@ -369,7 +368,6 @@ public class UriDeploymentHttpScanner implements UriDeploymentScanner
{
          * @param scanCtx Scan context.
          * @return Set of referenced URLs in string format.
          */
-        @SuppressWarnings("unchecked")
         private Set<String> getUrls(URL url, UriDeploymentScannerContext scanCtx) {
             assert url != null;
 
@@ -430,7 +428,7 @@ public class UriDeploymentHttpScanner implements UriDeploymentScanner
{
          * @param baseUrl Base URL.
          * @param scanCtx Scan context.
          */
-        @SuppressWarnings( {"UnusedCatchParameter", "UnnecessaryFullyQualifiedName"})
+        @SuppressWarnings( {"UnnecessaryFullyQualifiedName"})
         private void findReferences(org.w3c.dom.Node node, Set<String> res, URL baseUrl,
             UriDeploymentScannerContext scanCtx) {
             if (node instanceof Element && "a".equals(node.getNodeName().toLowerCase()))
{

http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/urideploy/src/test/java/org/apache/ignite/p2p/GridP2PDisabledSelfTest.java
----------------------------------------------------------------------
diff --git a/modules/urideploy/src/test/java/org/apache/ignite/p2p/GridP2PDisabledSelfTest.java
b/modules/urideploy/src/test/java/org/apache/ignite/p2p/GridP2PDisabledSelfTest.java
index bba32af..c514a94 100644
--- a/modules/urideploy/src/test/java/org/apache/ignite/p2p/GridP2PDisabledSelfTest.java
+++ b/modules/urideploy/src/test/java/org/apache/ignite/p2p/GridP2PDisabledSelfTest.java
@@ -36,7 +36,7 @@ import org.apache.ignite.testframework.junits.common.GridCommonTest;
  * In order for this test to run, make sure that your
  * {@code p2p.uri.cls} folder ends with {@code .gar} extension.
  */
-@SuppressWarnings({"ProhibitedExceptionDeclared", "ProhibitedExceptionThrown"})
+@SuppressWarnings({"ProhibitedExceptionDeclared"})
 @GridCommonTest(group = "P2P")
 public class GridP2PDisabledSelfTest extends GridCommonAbstractTest {
     /** Task name. */
@@ -120,7 +120,6 @@ public class GridP2PDisabledSelfTest extends GridCommonAbstractTest {
     /**
      * @throws Exception if error occur.
      */
-    @SuppressWarnings("unchecked")
     private void checkGar() throws Exception {
         initGar = true;
 

http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/urideploy/src/test/java/org/apache/ignite/tools/GridToolsSelfTest.java
----------------------------------------------------------------------
diff --git a/modules/urideploy/src/test/java/org/apache/ignite/tools/GridToolsSelfTest.java
b/modules/urideploy/src/test/java/org/apache/ignite/tools/GridToolsSelfTest.java
index de2d405..b9a3c76 100644
--- a/modules/urideploy/src/test/java/org/apache/ignite/tools/GridToolsSelfTest.java
+++ b/modules/urideploy/src/test/java/org/apache/ignite/tools/GridToolsSelfTest.java
@@ -39,7 +39,6 @@ public class GridToolsSelfTest extends GridCommonAbstractTest {
     /**
      * @throws Exception If failed.
      */
-    @SuppressWarnings({"TypeMayBeWeakened"})
     public void testCorrectAntGarTask() throws Exception {
         String tmpDirName = GridTestProperties.getProperty("ant.gar.tmpdir");
         String srcDirName = GridTestProperties.getProperty("ant.gar.srcdir");
@@ -266,7 +265,6 @@ public class GridToolsSelfTest extends GridCommonAbstractTest {
     /**
      * @throws Exception If failed.
      */
-    @SuppressWarnings({"TypeMayBeWeakened"})
     public void testAntGarTaskWithNullDescriptor() throws Exception {
         String tmpDirName = GridTestProperties.getProperty("ant.gar.tmpdir");
         String srcDirName = GridTestProperties.getProperty("ant.gar.srcdir");

http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/web/src/main/java/org/apache/ignite/cache/websession/WebSessionFilter.java
----------------------------------------------------------------------
diff --git a/modules/web/src/main/java/org/apache/ignite/cache/websession/WebSessionFilter.java
b/modules/web/src/main/java/org/apache/ignite/cache/websession/WebSessionFilter.java
index 0112413..9fa6de2 100644
--- a/modules/web/src/main/java/org/apache/ignite/cache/websession/WebSessionFilter.java
+++ b/modules/web/src/main/java/org/apache/ignite/cache/websession/WebSessionFilter.java
@@ -609,7 +609,6 @@ public class WebSessionFilter implements Filter {
      * @param httpReq Request.
      * @return New session.
      */
-    @SuppressWarnings("unchecked")
     private WebSession createSession(HttpServletRequest httpReq) {
         HttpSession ses = httpReq.getSession(true);
 
@@ -625,7 +624,6 @@ public class WebSessionFilter implements Filter {
      * @param sesId Session id.
      * @return New session.
      */
-    @SuppressWarnings("unchecked")
     private WebSession createSession(HttpSession ses, String sesId) {
         WebSession cached = new WebSession(sesId, ses, true);
 
@@ -780,7 +778,6 @@ public class WebSessionFilter implements Filter {
      * @param updates Updates list.
      * @param maxInactiveInterval Max session inactive interval.
      */
-    @SuppressWarnings("unchecked")
     public void updateAttributes(String sesId, Collection<T2<String, Object>>
updates, int maxInactiveInterval) {
         assert sesId != null;
         assert updates != null;
@@ -865,7 +862,6 @@ public class WebSessionFilter implements Filter {
      * Handles cache operation exception.
      * @param e Exception
      */
-    @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
     void handleCacheOperationException(Exception e){
         IgniteFuture<?> retryFut = null;
 

http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/web/src/main/java/org/apache/ignite/startup/servlet/ServletStartup.java
----------------------------------------------------------------------
diff --git a/modules/web/src/main/java/org/apache/ignite/startup/servlet/ServletStartup.java
b/modules/web/src/main/java/org/apache/ignite/startup/servlet/ServletStartup.java
index ee193c7..a5f2ecd 100644
--- a/modules/web/src/main/java/org/apache/ignite/startup/servlet/ServletStartup.java
+++ b/modules/web/src/main/java/org/apache/ignite/startup/servlet/ServletStartup.java
@@ -124,7 +124,6 @@ public class ServletStartup extends HttpServlet {
     private Collection<String> igniteInstanceNames = new ArrayList<>();
 
     /** {@inheritDoc} */
-    @SuppressWarnings({"unchecked"})
     @Override public void init() throws ServletException {
         // Avoid multiple servlet instances. Ignite should be loaded once.
         if (loaded)

http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/web/src/test/java/org/apache/ignite/internal/websession/IgniteWebSessionSelfTestSuite.java
----------------------------------------------------------------------
diff --git a/modules/web/src/test/java/org/apache/ignite/internal/websession/IgniteWebSessionSelfTestSuite.java
b/modules/web/src/test/java/org/apache/ignite/internal/websession/IgniteWebSessionSelfTestSuite.java
index e1d5c3b..e10052f 100644
--- a/modules/web/src/test/java/org/apache/ignite/internal/websession/IgniteWebSessionSelfTestSuite.java
+++ b/modules/web/src/test/java/org/apache/ignite/internal/websession/IgniteWebSessionSelfTestSuite.java
@@ -26,7 +26,6 @@ import static org.apache.ignite.IgniteSystemProperties.IGNITE_OVERRIDE_MCAST_GRP
 /**
  * Test suite for web sessions caching functionality.
  */
-@SuppressWarnings("PublicInnerClass")
 public class IgniteWebSessionSelfTestSuite extends TestSuite {
     /**
      * @return Test suite.

http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZookeeperDiscoveryImpl.java
----------------------------------------------------------------------
diff --git a/modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZookeeperDiscoveryImpl.java
b/modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZookeeperDiscoveryImpl.java
index 3d42042..abe1877 100644
--- a/modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZookeeperDiscoveryImpl.java
+++ b/modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZookeeperDiscoveryImpl.java
@@ -2224,7 +2224,6 @@ public class ZookeeperDiscoveryImpl {
      * @param prevEvts Events from previous cluster.
      * @throws Exception If failed.
      */
-    @SuppressWarnings("unchecked")
     private void newClusterStarted(@Nullable ZkDiscoveryEventsData prevEvts) throws Exception
{
         assert !locNode.isClient() : locNode;
 
@@ -2614,7 +2613,6 @@ public class ZookeeperDiscoveryImpl {
      * @param evtsData Events.
      * @throws Exception If failed.
      */
-    @SuppressWarnings("unchecked")
     private void processNewEvents(final ZkDiscoveryEventsData evtsData) throws Exception
{
         TreeMap<Long, ZkDiscoveryEventData> evts = evtsData.evts;
 
@@ -2897,7 +2895,6 @@ public class ZookeeperDiscoveryImpl {
      * @param evtData Local join event data.
      * @throws Exception If failed.
      */
-    @SuppressWarnings("unchecked")
     private void processLocalJoin(ZkDiscoveryEventsData evtsData,
         ZkJoinedNodeEvtData joinedEvtData,
         ZkDiscoveryNodeJoinEventData evtData)
@@ -3410,7 +3407,6 @@ public class ZookeeperDiscoveryImpl {
      * @param evtData Event data.
      * @param msg Custom message.
      */
-    @SuppressWarnings("unchecked")
     private void notifyCustomEvent(final ZkDiscoveryCustomEventData evtData, final DiscoverySpiCustomMessage
msg) {
         assert !(msg instanceof ZkInternalMessage) : msg;
 
@@ -3440,7 +3436,6 @@ public class ZookeeperDiscoveryImpl {
      * @param joinedEvtData Event data.
      * @param joiningData Joining node data.
      */
-    @SuppressWarnings("unchecked")
     private void notifyNodeJoin(ZkJoinedNodeEvtData joinedEvtData, ZkJoiningNodeData joiningData)
{
         final ZookeeperClusterNode joinedNode = joiningData.node();
 


Mime
View raw message