ignite-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ptupit...@apache.org
Subject ignite git commit: .NET: Fix code inspection errors
Date Wed, 14 Mar 2018 21:05:40 GMT
Repository: ignite
Updated Branches:
  refs/heads/master 90e0bf0c1 -> a69e1acba


.NET: Fix code inspection errors


Project: http://git-wip-us.apache.org/repos/asf/ignite/repo
Commit: http://git-wip-us.apache.org/repos/asf/ignite/commit/a69e1acb
Tree: http://git-wip-us.apache.org/repos/asf/ignite/tree/a69e1acb
Diff: http://git-wip-us.apache.org/repos/asf/ignite/diff/a69e1acb

Branch: refs/heads/master
Commit: a69e1acba8a69f1818fa9182a1167302f81b93ec
Parents: 90e0bf0
Author: Pavel Tupitsyn <ptupitsyn@apache.org>
Authored: Thu Mar 15 00:05:32 2018 +0300
Committer: Pavel Tupitsyn <ptupitsyn@apache.org>
Committed: Thu Mar 15 00:05:32 2018 +0300

----------------------------------------------------------------------
 .../Apache.Ignite.Core/Compute/IComputeTask.cs  |  2 ++
 .../Query/Continuous/ContinuousQueryFilter.cs   |  2 ++
 .../Impl/Common/IgniteArgumentCheck.cs          |  1 +
 .../Impl/Handle/HandleRegistry.cs               |  1 +
 .../Impl/Unmanaged/Jni/Jvm.cs                   |  1 +
 .../Apache.Ignite.Core/Ssl/SslContextFactory.cs |  8 +++++--
 .../Impl/CacheFieldsQueryProvider.cs            | 23 +++++++++++---------
 7 files changed, 26 insertions(+), 12 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/ignite/blob/a69e1acb/modules/platforms/dotnet/Apache.Ignite.Core/Compute/IComputeTask.cs
----------------------------------------------------------------------
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Compute/IComputeTask.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Compute/IComputeTask.cs
index 5ae1420..353e087 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Compute/IComputeTask.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Compute/IComputeTask.cs
@@ -102,6 +102,8 @@ namespace Apache.Ignite.Core.Compute
         /// <param name="rcvd">All previously received results. Note that if task class
has
         /// <see cref="ComputeTaskNoResultCacheAttribute"/> attribute, then this list
will be empty.</param>
         /// <returns>Result policy that dictates how to process further upcoming job
results.</returns>
+        // ReSharper disable once UnusedParameter.Global
+        // ReSharper disable once ParameterOnlyUsedForPreconditionCheck.Global
         ComputeJobResultPolicy OnResult(IComputeJobResult<TJobRes> res, IList<IComputeJobResult<TJobRes>>
rcvd);
 
         /// <summary>

http://git-wip-us.apache.org/repos/asf/ignite/blob/a69e1acb/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Cache/Query/Continuous/ContinuousQueryFilter.cs
----------------------------------------------------------------------
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Cache/Query/Continuous/ContinuousQueryFilter.cs
b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Cache/Query/Continuous/ContinuousQueryFilter.cs
index 7cdb91b..2499463 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Cache/Query/Continuous/ContinuousQueryFilter.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Cache/Query/Continuous/ContinuousQueryFilter.cs
@@ -83,6 +83,7 @@ namespace Apache.Ignite.Core.Impl.Cache.Query.Continuous
         /** <inheritDoc /> */
         public bool Evaluate(IBinaryStream stream)
         {
+            // ReSharper disable once InconsistentlySynchronizedField
             ICacheEntryEvent<TK, TV> evt = CQU.ReadEvent<TK, TV>(stream, _ignite.Marshaller,
_keepBinary);
 
             return _filter.Evaluate(evt);
@@ -91,6 +92,7 @@ namespace Apache.Ignite.Core.Impl.Cache.Query.Continuous
         /** <inheritDoc /> */
         public void Inject(Ignite grid)
         {
+            // ReSharper disable once InconsistentlySynchronizedField
             _ignite = grid;
 
             ResourceProcessor.Inject(_filter, grid);

http://git-wip-us.apache.org/repos/asf/ignite/blob/a69e1acb/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Common/IgniteArgumentCheck.cs
----------------------------------------------------------------------
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Common/IgniteArgumentCheck.cs
b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Common/IgniteArgumentCheck.cs
index a633291..967225b 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Common/IgniteArgumentCheck.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Common/IgniteArgumentCheck.cs
@@ -15,6 +15,7 @@
  * limitations under the License.
  */
 
+// ReSharper disable ParameterOnlyUsedForPreconditionCheck.Global
 namespace Apache.Ignite.Core.Impl.Common
 {
     using System;

http://git-wip-us.apache.org/repos/asf/ignite/blob/a69e1acb/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Handle/HandleRegistry.cs
----------------------------------------------------------------------
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Handle/HandleRegistry.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Handle/HandleRegistry.cs
index fee7d79..d3d4b30 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Handle/HandleRegistry.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Handle/HandleRegistry.cs
@@ -239,6 +239,7 @@ namespace Apache.Ignite.Core.Impl.Handle
         /// <param name="id">Identifier.</param>
         /// <param name="throwOnAbsent">Whether to throw an exception if resource is
not found.</param>
         /// <returns>Target.</returns>
+        // ReSharper disable once ParameterOnlyUsedForPreconditionCheck.Global
         public T Get<T>(long id, bool throwOnAbsent)
         {
             object target;

http://git-wip-us.apache.org/repos/asf/ignite/blob/a69e1acb/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Unmanaged/Jni/Jvm.cs
----------------------------------------------------------------------
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Unmanaged/Jni/Jvm.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Unmanaged/Jni/Jvm.cs
index 6d706e8..5c781b5 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Unmanaged/Jni/Jvm.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Unmanaged/Jni/Jvm.cs
@@ -145,6 +145,7 @@ namespace Apache.Ignite.Core.Impl.Unmanaged.Jni
         /// <summary>
         /// Gets the JVM.
         /// </summary>
+        // ReSharper disable once ParameterOnlyUsedForPreconditionCheck.Global
         public static Jvm Get(bool ignoreMissing = false)
         {
             var res = _instance;

http://git-wip-us.apache.org/repos/asf/ignite/blob/a69e1acb/modules/platforms/dotnet/Apache.Ignite.Core/Ssl/SslContextFactory.cs
----------------------------------------------------------------------
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Ssl/SslContextFactory.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Ssl/SslContextFactory.cs
index bb5c7a0..a55c6f1 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Ssl/SslContextFactory.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Ssl/SslContextFactory.cs
@@ -48,10 +48,14 @@ namespace Apache.Ignite.Core.Ssl
         /// </summary>
         public string KeyStoreType { get; set; }
 
-        /// <inheritdoc />
+        /// <summary>
+        /// Key store file path.
+        /// </summary>
         public string KeyStoreFilePath { get; set; }
 
-        /// <inheritdoc />
+        /// <summary>
+        /// Key store file password.
+        /// </summary>
         public string KeyStorePassword { get; set; }
 
         /// <summary>

http://git-wip-us.apache.org/repos/asf/ignite/blob/a69e1acb/modules/platforms/dotnet/Apache.Ignite.Linq/Impl/CacheFieldsQueryProvider.cs
----------------------------------------------------------------------
diff --git a/modules/platforms/dotnet/Apache.Ignite.Linq/Impl/CacheFieldsQueryProvider.cs
b/modules/platforms/dotnet/Apache.Ignite.Linq/Impl/CacheFieldsQueryProvider.cs
index 4f35a42..cfc30cc 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Linq/Impl/CacheFieldsQueryProvider.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Linq/Impl/CacheFieldsQueryProvider.cs
@@ -220,17 +220,20 @@ namespace Apache.Ignite.Linq.Impl
             // Try with full type name (this works when TableName is not set).
             var valueTypeName = cacheValueType.FullName;
 
-            if (validTableNames.Contains(valueTypeName, StringComparer.OrdinalIgnoreCase))
+            if (valueTypeName != null)
             {
-                return EscapeTableName(valueTypeName);
-            }
-
-            // Remove namespace and nested class qualification and try again.
-            valueTypeName = EscapeTableName(valueTypeName);
-
-            if (validTableNames.Contains(valueTypeName, StringComparer.OrdinalIgnoreCase))
-            {
-                return valueTypeName;
+                if (validTableNames.Contains(valueTypeName, StringComparer.OrdinalIgnoreCase))
+                {
+                    return EscapeTableName(valueTypeName);
+                }
+
+                // Remove namespace and nested class qualification and try again.
+                valueTypeName = EscapeTableName(valueTypeName);
+
+                if (validTableNames.Contains(valueTypeName, StringComparer.OrdinalIgnoreCase))
+                {
+                    return valueTypeName;
+                }
             }
 
             throw new CacheException(string.Format("Table name cannot be inferred for cache
'{0}', " +


Mime
View raw message