Return-Path: X-Original-To: apmail-ignite-commits-archive@minotaur.apache.org Delivered-To: apmail-ignite-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6AB2218A5F for ; Mon, 18 Jan 2016 14:12:08 +0000 (UTC) Received: (qmail 52317 invoked by uid 500); 18 Jan 2016 14:12:08 -0000 Delivered-To: apmail-ignite-commits-archive@ignite.apache.org Received: (qmail 52212 invoked by uid 500); 18 Jan 2016 14:12:08 -0000 Mailing-List: contact commits-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list commits@ignite.apache.org Received: (qmail 51126 invoked by uid 99); 18 Jan 2016 14:12:07 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Jan 2016 14:12:07 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 923C4E0AC9; Mon, 18 Jan 2016 14:12:07 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: vozerov@apache.org To: commits@ignite.apache.org Date: Mon, 18 Jan 2016 14:12:45 -0000 Message-Id: <3555efb4c2a2491a97b0e0c9421f3f0b@git.apache.org> In-Reply-To: <40b4beb3e488418087724fbc9bd43321@git.apache.org> References: <40b4beb3e488418087724fbc9bd43321@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [40/50] ignite git commit: wip wip Project: http://git-wip-us.apache.org/repos/asf/ignite/repo Commit: http://git-wip-us.apache.org/repos/asf/ignite/commit/a2583c83 Tree: http://git-wip-us.apache.org/repos/asf/ignite/tree/a2583c83 Diff: http://git-wip-us.apache.org/repos/asf/ignite/diff/a2583c83 Branch: refs/heads/ignite-2324 Commit: a2583c83daaf6e0f3d764c9d0529d7356d9e5b56 Parents: 9edb32f Author: Pavel Tupitsyn Authored: Thu Jan 14 12:03:51 2016 +0300 Committer: Pavel Tupitsyn Committed: Thu Jan 14 12:03:51 2016 +0300 ---------------------------------------------------------------------- .../dotnet/Apache.Ignite.Core/Impl/InteropExceptionHolder.cs | 7 ++++--- .../dotnet/Apache.Ignite.Core/Impl/Memory/PlatformMemory.cs | 2 ++ .../Apache.Ignite.Core/Impl/Memory/PlatformMemoryManager.cs | 1 + .../Apache.Ignite.Core/Impl/Memory/PlatformRawMemory.cs | 2 ++ .../Apache.Ignite.Core/Impl/Transactions/TransactionsImpl.cs | 3 +++ .../Apache.Ignite.Core/Impl/Unmanaged/UnmanagedCallbacks.cs | 2 ++ 6 files changed, 14 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/ignite/blob/a2583c83/modules/platforms/dotnet/Apache.Ignite.Core/Impl/InteropExceptionHolder.cs ---------------------------------------------------------------------- diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/InteropExceptionHolder.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/InteropExceptionHolder.cs index c9b491b..20fa146 100644 --- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/InteropExceptionHolder.cs +++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/InteropExceptionHolder.cs @@ -70,9 +70,10 @@ namespace Apache.Ignite.Core.Impl { writer0.WriteBoolean(false); - BinaryFormatter bf = new BinaryFormatter(); - - bf.Serialize(new BinaryStreamAdapter(writer0.Stream), _err); + using (var streamAdapter = new BinaryStreamAdapter(writer0.Stream)) + { + new BinaryFormatter().Serialize(streamAdapter, _err); + } } } http://git-wip-us.apache.org/repos/asf/ignite/blob/a2583c83/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Memory/PlatformMemory.cs ---------------------------------------------------------------------- diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Memory/PlatformMemory.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Memory/PlatformMemory.cs index 4a905c3..87c357f 100644 --- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Memory/PlatformMemory.cs +++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Memory/PlatformMemory.cs @@ -18,6 +18,7 @@ namespace Apache.Ignite.Core.Impl.Memory { using System; + using System.Diagnostics.CodeAnalysis; /// /// Abstract memory chunk. @@ -38,6 +39,7 @@ namespace Apache.Ignite.Core.Impl.Memory } /** */ + [SuppressMessage("Reliability", "S2930:\"IDisposables\" should be disposed")] public virtual PlatformMemoryStream GetStream() { return BitConverter.IsLittleEndian ? new PlatformMemoryStream(this) : http://git-wip-us.apache.org/repos/asf/ignite/blob/a2583c83/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Memory/PlatformMemoryManager.cs ---------------------------------------------------------------------- diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Memory/PlatformMemoryManager.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Memory/PlatformMemoryManager.cs index 945b05f..b66a8ef 100644 --- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Memory/PlatformMemoryManager.cs +++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Memory/PlatformMemoryManager.cs @@ -81,6 +81,7 @@ namespace Apache.Ignite.Core.Impl.Memory /// Gets or creates thread-local memory pool. /// /// Memory pool. + [SuppressMessage("Reliability", "S2930:\"IDisposables\" should be disposed")] public PlatformMemoryPool Pool() { PlatformMemoryPool pool = _threadLocPool.Value; http://git-wip-us.apache.org/repos/asf/ignite/blob/a2583c83/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Memory/PlatformRawMemory.cs ---------------------------------------------------------------------- diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Memory/PlatformRawMemory.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Memory/PlatformRawMemory.cs index 76aa237..bc813af 100644 --- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Memory/PlatformRawMemory.cs +++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Memory/PlatformRawMemory.cs @@ -18,6 +18,7 @@ namespace Apache.Ignite.Core.Impl.Memory { using System; + using System.Diagnostics.CodeAnalysis; /// /// Non-resizeable raw memory chunk without metadata header. @@ -43,6 +44,7 @@ namespace Apache.Ignite.Core.Impl.Memory } /** */ + [SuppressMessage("Reliability", "S2930:\"IDisposables\" should be disposed")] public PlatformMemoryStream GetStream() { return BitConverter.IsLittleEndian ? new PlatformMemoryStream(this) : http://git-wip-us.apache.org/repos/asf/ignite/blob/a2583c83/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Transactions/TransactionsImpl.cs ---------------------------------------------------------------------- diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Transactions/TransactionsImpl.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Transactions/TransactionsImpl.cs index 0bc7172..f1382c0 100644 --- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Transactions/TransactionsImpl.cs +++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Transactions/TransactionsImpl.cs @@ -18,6 +18,7 @@ namespace Apache.Ignite.Core.Impl.Transactions { using System; + using System.Diagnostics.CodeAnalysis; using System.Threading.Tasks; using Apache.Ignite.Core.Binary; using Apache.Ignite.Core.Impl.Binary; @@ -89,7 +90,9 @@ namespace Apache.Ignite.Core.Impl.Transactions return TxStart(concurrency, isolation, _dfltTimeout, 0); } + /** */ + [SuppressMessage("Reliability", "S2930:\"IDisposables\" should be disposed")] public ITransaction TxStart(TransactionConcurrency concurrency, TransactionIsolation isolation, TimeSpan timeout, int txSize) { http://git-wip-us.apache.org/repos/asf/ignite/blob/a2583c83/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Unmanaged/UnmanagedCallbacks.cs ---------------------------------------------------------------------- diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Unmanaged/UnmanagedCallbacks.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Unmanaged/UnmanagedCallbacks.cs index 0f0596e..5dc9897 100644 --- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Unmanaged/UnmanagedCallbacks.cs +++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Unmanaged/UnmanagedCallbacks.cs @@ -284,6 +284,7 @@ namespace Apache.Ignite.Core.Impl.Unmanaged }, true); } + [SuppressMessage("Reliability", "S2930:\"IDisposables\" should be disposed")] private int CacheStoreInvoke(void* target, long objPtr, long memPtr, void* cb) { return SafeCall(() => @@ -604,6 +605,7 @@ namespace Apache.Ignite.Core.Impl.Unmanaged }); } + [SuppressMessage("Reliability", "S2930:\"IDisposables\" should be disposed")] private void DataStreamerStreamReceiverInvoke(void* target, long rcvPtr, void* cache, long memPtr, byte keepBinary) {