ignite-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From voze...@apache.org
Subject [6/6] ignite git commit: IGNITE-1816: Removed incorrect fieldId length addition.
Date Thu, 12 Nov 2015 13:40:42 GMT
IGNITE-1816: Removed incorrect fieldId length addition.


Project: http://git-wip-us.apache.org/repos/asf/ignite/repo
Commit: http://git-wip-us.apache.org/repos/asf/ignite/commit/58f5737c
Tree: http://git-wip-us.apache.org/repos/asf/ignite/tree/58f5737c
Diff: http://git-wip-us.apache.org/repos/asf/ignite/diff/58f5737c

Branch: refs/heads/ignite-1816
Commit: 58f5737c68e14d2ef46b2aab08654aa7fd6b2e4a
Parents: 8065338
Author: vozerov-gridgain <vozerov@gridgain.com>
Authored: Thu Nov 12 16:41:10 2015 +0300
Committer: vozerov-gridgain <vozerov@gridgain.com>
Committed: Thu Nov 12 16:41:10 2015 +0300

----------------------------------------------------------------------
 .../ignite/internal/portable/builder/BinaryObjectBuilderImpl.java | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/ignite/blob/58f5737c/modules/core/src/main/java/org/apache/ignite/internal/portable/builder/BinaryObjectBuilderImpl.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/portable/builder/BinaryObjectBuilderImpl.java
b/modules/core/src/main/java/org/apache/ignite/internal/portable/builder/BinaryObjectBuilderImpl.java
index 509725f..7697c91 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/portable/builder/BinaryObjectBuilderImpl.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/portable/builder/BinaryObjectBuilderImpl.java
@@ -240,8 +240,7 @@ public class BinaryObjectBuilderImpl implements BinaryObjectBuilder {
 
                 int idx = 0;
 
-                // TODO: + fieldIdLen looks incorrect here.
-                while (reader.position() + fieldIdLen < rawPos) {
+                while (reader.position() < rawPos) {
                     int fieldId = schema.fieldId(idx++);
                     int fieldLen =
                         fieldPositionAndLength(footerPos, footerEnd, rawPos, fieldIdLen,
fieldOffsetLen).get2();


Mime
View raw message