Return-Path: X-Original-To: apmail-ignite-commits-archive@minotaur.apache.org Delivered-To: apmail-ignite-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DEA8F18F22 for ; Wed, 1 Jul 2015 10:13:48 +0000 (UTC) Received: (qmail 65085 invoked by uid 500); 1 Jul 2015 10:13:48 -0000 Delivered-To: apmail-ignite-commits-archive@ignite.apache.org Received: (qmail 65053 invoked by uid 500); 1 Jul 2015 10:13:48 -0000 Mailing-List: contact commits-help@ignite.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.incubator.apache.org Delivered-To: mailing list commits@ignite.incubator.apache.org Received: (qmail 65044 invoked by uid 99); 1 Jul 2015 10:13:48 -0000 Received: from Unknown (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jul 2015 10:13:48 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 5A2891A646C for ; Wed, 1 Jul 2015 10:13:48 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.771 X-Spam-Level: * X-Spam-Status: No, score=1.771 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id KndnsfrXtYev for ; Wed, 1 Jul 2015 10:13:47 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with SMTP id 642C2275F0 for ; Wed, 1 Jul 2015 10:13:38 +0000 (UTC) Received: (qmail 64534 invoked by uid 99); 1 Jul 2015 10:13:38 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jul 2015 10:13:38 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 46B1BDFE60; Wed, 1 Jul 2015 10:13:38 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: ivasilinets@apache.org To: commits@ignite.incubator.apache.org Date: Wed, 01 Jul 2015 10:14:11 -0000 Message-Id: <9bf735e286a345dfa89d4ccd157f2c4e@git.apache.org> In-Reply-To: <1e68bcb0a7d44636b3c5ac0e0732c821@git.apache.org> References: <1e68bcb0a7d44636b3c5ac0e0732c821@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [35/39] incubator-ignite git commit: #ignite-964: GridJettyRestHandler code style. #ignite-964: GridJettyRestHandler code style. Project: http://git-wip-us.apache.org/repos/asf/incubator-ignite/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-ignite/commit/990e5ece Tree: http://git-wip-us.apache.org/repos/asf/incubator-ignite/tree/990e5ece Diff: http://git-wip-us.apache.org/repos/asf/incubator-ignite/diff/990e5ece Branch: refs/heads/ignite-964 Commit: 990e5ecee7e78ce0c6f0e3f6a0c5b839f8eb5ff2 Parents: bb412c4 Author: ivasilinets Authored: Wed Jul 1 12:46:35 2015 +0300 Committer: ivasilinets Committed: Wed Jul 1 12:46:35 2015 +0300 ---------------------------------------------------------------------- .../http/jetty/GridJettyRestHandler.java | 95 +++++++++++++------- 1 file changed, 61 insertions(+), 34 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-ignite/blob/990e5ece/modules/rest-http/src/main/java/org/apache/ignite/internal/processors/rest/protocols/http/jetty/GridJettyRestHandler.java ---------------------------------------------------------------------- diff --git a/modules/rest-http/src/main/java/org/apache/ignite/internal/processors/rest/protocols/http/jetty/GridJettyRestHandler.java b/modules/rest-http/src/main/java/org/apache/ignite/internal/processors/rest/protocols/http/jetty/GridJettyRestHandler.java index 55fe156..11059f3 100644 --- a/modules/rest-http/src/main/java/org/apache/ignite/internal/processors/rest/protocols/http/jetty/GridJettyRestHandler.java +++ b/modules/rest-http/src/main/java/org/apache/ignite/internal/processors/rest/protocols/http/jetty/GridJettyRestHandler.java @@ -315,11 +315,14 @@ public class GridJettyRestHandler extends AbstractHandler { } } + /** + * @param cmd Rest command. + * @param cmdRes Rest response. + */ private void createResponse(GridRestCommand cmd, GridRestResponse cmdRes) { if (cmd == CACHE_GET_ALL) { - if (cmdRes.getResponse() == null) { + if (cmdRes.getResponse() == null) return; - } Map o = (Map)cmdRes.getResponse(); @@ -332,37 +335,6 @@ public class GridJettyRestHandler extends AbstractHandler { } } - public static class RestEntry { - private Object key; - private Object value; - public RestEntry(Object key, Object value) { - if (key instanceof JSONCacheObject) - this.key = ((JSONCacheObject)key).getFields(); - else - this.key = key; - - if (value instanceof JSONCacheObject) - this.value = ((JSONCacheObject)value).getFields(); - else - this.value = value; - } - public Object getKey() { - return key; - } - - public void setKey(Object key) { - this.key = key; - } - - public Object getValue() { - return value; - } - - public void setValue(Object value) { - this.value = value; - } - } - /** * Creates REST request. * @@ -804,7 +776,7 @@ public class GridJettyRestHandler extends AbstractHandler { private JSONObject parseRequest(HttpServletRequest req) throws IgniteCheckedException{ StringBuilder builder = new StringBuilder(); - Scanner reader = null; + Scanner reader; try { reader = new Scanner(req.getReader()); @@ -818,4 +790,59 @@ public class GridJettyRestHandler extends AbstractHandler { return JSONObject.fromObject(builder.toString()); } + + /** + * Rest entry. + */ + public static class RestEntry { + /** Key. */ + private Object key; + + /** Value. */ + private Object value; + + /** + * @param key Key. + * @param val Value. + */ + public RestEntry(Object key, Object val) { + if (key instanceof JSONCacheObject) + this.key = ((JSONCacheObject)key).getFields(); + else + this.key = key; + + if (val instanceof JSONCacheObject) + this.value = ((JSONCacheObject)val).getFields(); + else + this.value = val; + } + + /** + * @return Key. + */ + public Object getKey() { + return key; + } + + /** + * @param key Key. + */ + public void setKey(Object key) { + this.key = key; + } + + /** + * @return Value. + */ + public Object getValue() { + return value; + } + + /** + * @param val Value. + */ + public void setValue(Object val) { + this.value = val; + } + } }