Return-Path: X-Original-To: apmail-ignite-commits-archive@minotaur.apache.org Delivered-To: apmail-ignite-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E6EF31776E for ; Wed, 24 Jun 2015 12:48:46 +0000 (UTC) Received: (qmail 65997 invoked by uid 500); 24 Jun 2015 12:48:46 -0000 Delivered-To: apmail-ignite-commits-archive@ignite.apache.org Received: (qmail 65966 invoked by uid 500); 24 Jun 2015 12:48:46 -0000 Mailing-List: contact commits-help@ignite.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.incubator.apache.org Delivered-To: mailing list commits@ignite.incubator.apache.org Received: (qmail 65957 invoked by uid 99); 24 Jun 2015 12:48:46 -0000 Received: from Unknown (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Jun 2015 12:48:46 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 558E01A602B for ; Wed, 24 Jun 2015 12:48:46 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.791 X-Spam-Level: * X-Spam-Status: No, score=1.791 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id WEzlG_Idw4dg for ; Wed, 24 Jun 2015 12:48:38 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with SMTP id B9033254C6 for ; Wed, 24 Jun 2015 12:48:37 +0000 (UTC) Received: (qmail 65771 invoked by uid 99); 24 Jun 2015 12:48:36 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Jun 2015 12:48:36 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 80492E364B; Wed, 24 Jun 2015 12:48:36 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: sboikov@apache.org To: commits@ignite.incubator.apache.org Date: Wed, 24 Jun 2015 12:48:40 -0000 Message-Id: <938b772c766c480a9a53670246cb8874@git.apache.org> In-Reply-To: References: X-Mailer: ASF-Git Admin Mailer Subject: [5/7] incubator-ignite git commit: #ignite-965: emit is a global function. #ignite-965: emit is a global function. Project: http://git-wip-us.apache.org/repos/asf/incubator-ignite/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-ignite/commit/99d2c2ac Tree: http://git-wip-us.apache.org/repos/asf/incubator-ignite/tree/99d2c2ac Diff: http://git-wip-us.apache.org/repos/asf/incubator-ignite/diff/99d2c2ac Branch: refs/heads/ignite-965 Commit: 99d2c2ac161efb9703a5a934e831bb3f5b43abc4 Parents: e837781 Author: ivasilinets Authored: Wed Jun 24 15:44:01 2015 +0300 Committer: ivasilinets Committed: Wed Jun 24 15:44:01 2015 +0300 ---------------------------------------------------------------------- .../IgniteScriptingCommandHandler.java | 2 +- .../scripting/IgniteScriptProcessor.java | 28 ++++++++++---------- 2 files changed, 15 insertions(+), 15 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-ignite/blob/99d2c2ac/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/scripting/IgniteScriptingCommandHandler.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/scripting/IgniteScriptingCommandHandler.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/scripting/IgniteScriptingCommandHandler.java index edf9826..b48671e 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/scripting/IgniteScriptingCommandHandler.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/scripting/IgniteScriptingCommandHandler.java @@ -191,7 +191,7 @@ public class IgniteScriptingCommandHandler extends GridRestCommandHandlerAdapter data[i] = results.get(i).getData(); } - return new GridRestResponse(ctx.scripting().invokeFunction(reduceFunc, (Object)data)); + return new GridRestResponse(ctx.scripting().invokeFunction(reduceFunc, data)); } catch (IgniteCheckedException e) { return new GridRestResponse(GridRestResponse.STATUS_FAILED, e.getMessage()); http://git-wip-us.apache.org/repos/asf/incubator-ignite/blob/99d2c2ac/modules/core/src/main/java/org/apache/ignite/internal/processors/scripting/IgniteScriptProcessor.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/scripting/IgniteScriptProcessor.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/scripting/IgniteScriptProcessor.java index 5073427..e1eb8b7 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/processors/scripting/IgniteScriptProcessor.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/scripting/IgniteScriptProcessor.java @@ -57,12 +57,9 @@ public class IgniteScriptProcessor extends GridProcessorAdapter { String createJSFunction = "function __createJSFunction(mapFunc) {" + "return eval('(function() { return ' + mapFunc.trim() + '})()'); }"; - String internalCall = "function __internalCall(funcSource) { " + - "var func = __createJSFunction(funcSource); " + - "var arg = Array.prototype.slice.call(arguments, 0);" + - "arg.shift();" + - "return func.apply(null, arg);" + - "}"; + String internalCall = "function __internalCall(funcSource, arg) { " + + "var func = __createJSFunction(funcSource); " + + "return func.apply(null, arg); }"; addEngineFunction(createJSFunction); addEngineFunction(internalCall); @@ -99,18 +96,21 @@ public class IgniteScriptProcessor extends GridProcessorAdapter { /** * @param src Script src. - * @param args Arguments. * @return Result of the function. * @throws IgniteCheckedException If script failed. */ - public Object invokeFunction(String src, Object... args) throws IgniteCheckedException { - Object[] newArgs = new Object[args.length + 1]; - - newArgs[0] = src; - - System.arraycopy(args, 0, newArgs, 1, args.length); + public Object invokeFunction(String src) throws IgniteCheckedException { + return invokeFunctionByName("__internalCall", src); + } - return invokeFunctionByName("__internalCall", newArgs); + /** + * @param src Script src. + * @param arg Argument. + * @return Result of the function. + * @throws IgniteCheckedException If script failed. + */ + public Object invokeFunction(String src, Object arg) throws IgniteCheckedException { + return invokeFunctionByName("__internalCall", src, arg); } /**