Return-Path: X-Original-To: apmail-ignite-commits-archive@minotaur.apache.org Delivered-To: apmail-ignite-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8E8D31742E for ; Wed, 24 Jun 2015 11:06:20 +0000 (UTC) Received: (qmail 90780 invoked by uid 500); 24 Jun 2015 11:06:20 -0000 Delivered-To: apmail-ignite-commits-archive@ignite.apache.org Received: (qmail 90741 invoked by uid 500); 24 Jun 2015 11:06:20 -0000 Mailing-List: contact commits-help@ignite.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.incubator.apache.org Delivered-To: mailing list commits@ignite.incubator.apache.org Received: (qmail 90728 invoked by uid 99); 24 Jun 2015 11:06:20 -0000 Received: from Unknown (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Jun 2015 11:06:20 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id F02461A5FEE for ; Wed, 24 Jun 2015 11:06:14 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.771 X-Spam-Level: * X-Spam-Status: No, score=1.771 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id silzKsGBmRfh for ; Wed, 24 Jun 2015 11:06:13 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with SMTP id D75BF2846E for ; Wed, 24 Jun 2015 11:06:03 +0000 (UTC) Received: (qmail 87386 invoked by uid 99); 24 Jun 2015 11:06:01 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Jun 2015 11:06:01 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 1010FE0544; Wed, 24 Jun 2015 11:06:01 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: anovikov@apache.org To: commits@ignite.incubator.apache.org Date: Wed, 24 Jun 2015 11:06:15 -0000 Message-Id: <5f08823999064b719d34b4ecac94235f@git.apache.org> In-Reply-To: References: X-Mailer: ASF-Git Admin Mailer Subject: [16/50] incubator-ignite git commit: # disco spi usability - doc and warning messages on failure detection speed up # disco spi usability - doc and warning messages on failure detection speed up Project: http://git-wip-us.apache.org/repos/asf/incubator-ignite/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-ignite/commit/fc81bcfd Tree: http://git-wip-us.apache.org/repos/asf/incubator-ignite/tree/fc81bcfd Diff: http://git-wip-us.apache.org/repos/asf/incubator-ignite/diff/fc81bcfd Branch: refs/heads/master Commit: fc81bcfd0a4fd20e4322a060d7745754f14767e1 Parents: 31cf802 Author: Yakov Zhdanov Authored: Thu Jun 18 15:08:33 2015 +0300 Committer: Yakov Zhdanov Committed: Thu Jun 18 15:08:33 2015 +0300 ---------------------------------------------------------------------- .../java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java | 4 ++++ .../org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpi.java | 7 ++++--- 2 files changed, 8 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-ignite/blob/fc81bcfd/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java b/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java index e9a949a..f7b6de9 100644 --- a/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java +++ b/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java @@ -2320,6 +2320,10 @@ class ServerImpl extends TcpDiscoveryImpl { for (TcpDiscoveryNode n : failedNodes) msgWorker.addMessage(new TcpDiscoveryNodeFailedMessage(locNodeId, n.id(), n.internalOrder())); + + LT.warn(log, null, "Local node has detected failed nodes and started cluster-wide procedure. " + + "To speed up failure detection please see 'Failure Detection' section under javadoc" + + "for 'TcpDiscoverySpi'"); } } http://git-wip-us.apache.org/repos/asf/incubator-ignite/blob/fc81bcfd/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpi.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpi.java b/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpi.java index 9a26867..d7c33a5 100644 --- a/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpi.java +++ b/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpi.java @@ -64,9 +64,9 @@ import java.util.concurrent.atomic.*; * {@link TcpDiscoveryIpFinder} about self start (stops when send succeeds) * and then this info goes to coordinator. When coordinator processes join request * and issues node added messages and all other nodes then receive info about new node. - *

Configuration

- *

Important Notice

- * Configuration defaults are chosen to make possible for discovery SPI to reliably work on + *

Failure Detection

+ * Configuration defaults (see Configuration section below for details) + * are chosen to make possible for discovery SPI work reliably on * most of hardware and virtual deployments, but this has made failure detection time worse. *

* For stable low-latency networks the following more aggressive settings are recommended @@ -76,6 +76,7 @@ import java.util.concurrent.atomic.*; *

  • Socket timeout (see {@link #setSocketTimeout(long)}) - 200ms
    • *
  • Message acknowledgement timeout (see {@link #setAckTimeout(long)}) - 50ms
    • * + *

    Configuration

    *

    Mandatory

    * There are no mandatory configuration parameters. *

    Optional