ignite-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sboi...@apache.org
Subject [4/6] incubator-ignite git commit: #ignite-373: Serializable does not require empty constructor.
Date Wed, 13 May 2015 09:46:53 GMT
#ignite-373: Serializable does not require empty constructor.


Project: http://git-wip-us.apache.org/repos/asf/incubator-ignite/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-ignite/commit/a0161d90
Tree: http://git-wip-us.apache.org/repos/asf/incubator-ignite/tree/a0161d90
Diff: http://git-wip-us.apache.org/repos/asf/incubator-ignite/diff/a0161d90

Branch: refs/heads/ignite-373
Commit: a0161d9037a8cedf46df7c55238188b8226e3cdc
Parents: f670f40
Author: ivasilinets <ivasilinets@gridgain.com>
Authored: Wed May 13 12:40:16 2015 +0300
Committer: ivasilinets <ivasilinets@gridgain.com>
Committed: Wed May 13 12:40:16 2015 +0300

----------------------------------------------------------------------
 .../processors/cache/GridCacheAdapter.java      | 62 ++++----------------
 .../GridDistributedCacheAdapter.java            | 22 ++-----
 2 files changed, 14 insertions(+), 70 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-ignite/blob/a0161d90/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheAdapter.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheAdapter.java
b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheAdapter.java
index 76ad7a1..624c528 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheAdapter.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheAdapter.java
@@ -4830,13 +4830,6 @@ public abstract class GridCacheAdapter<K, V> implements IgniteInternalCache<K,
V
         private static final long serialVersionUID = 0L;
 
         /**
-         * Empty constructor for serialization.
-         */
-        public GlobalClearAllJob() {
-            // No-op.
-        }
-
-        /**
          * @param cacheName Cache name.
          * @param topVer Affinity topology version.
          */
@@ -4862,14 +4855,7 @@ public abstract class GridCacheAdapter<K, V> implements IgniteInternalCache<K,
V
         private static final long serialVersionUID = 0L;
 
         /** Keys to remove. */
-        private Set<? extends K> keys;
-
-        /**
-         * Empty constructor for serialization.
-         */
-        public GlobalClearKeySetJob() {
-            // No-op.
-        }
+        private final Set<? extends K> keys;
 
         /**
          * @param cacheName Cache name.
@@ -4900,14 +4886,7 @@ public abstract class GridCacheAdapter<K, V> implements IgniteInternalCache<K,
V
         private static final long serialVersionUID = 0L;
 
         /** Peek modes. */
-        private CachePeekMode[] peekModes;
-
-        /**
-         * Required by {@link Externalizable}.
-         */
-        public SizeJob() {
-            // No-op.
-        }
+        private final CachePeekMode[] peekModes;
 
         /**
          * @param cacheName Cache name.
@@ -5517,17 +5496,10 @@ public abstract class GridCacheAdapter<K, V> implements IgniteInternalCache<K,
V
         protected Ignite ignite;
 
         /** Affinity topology version. */
-        protected AffinityTopologyVersion topVer;
+        protected final AffinityTopologyVersion topVer;
 
         /** Cache name. */
-        protected String cacheName;
-
-        /**
-         * Empty constructor for serialization.
-         */
-        public TopologyVersionAwareJob() {
-            // No-op.
-        }
+        protected final String cacheName;
 
         /**
          * @param cacheName Cache name.
@@ -5587,20 +5559,13 @@ public abstract class GridCacheAdapter<K, V> implements IgniteInternalCache<K,
V
         private static final long serialVersionUID = 0L;
 
         /** Cache name. */
-        private String cacheName;
+        private final String cacheName;
 
         /** Affinity topology version. */
-        private AffinityTopologyVersion topVer;
+        private final AffinityTopologyVersion topVer;
 
         /** Peek modes. */
-        private CachePeekMode[] peekModes;
-
-        /**
-         * Empty constructor for serialization.
-         */
-        public SizeTask() {
-            // No-op.
-        }
+        private final CachePeekMode[] peekModes;
 
         /**
          * @param cacheName Cache name.
@@ -5650,20 +5615,13 @@ public abstract class GridCacheAdapter<K, V> implements IgniteInternalCache<K,
V
         private static final long serialVersionUID = 0L;
 
         /** Cache name. */
-        private String cacheName;
+        private final String cacheName;
 
         /** Affinity topology version. */
-        private AffinityTopologyVersion topVer;
+        private final AffinityTopologyVersion topVer;
 
         /** Keys to clear. */
-        private Set<? extends K> keys;
-
-        /**
-         * Empty constructor for serialization.
-         */
-        public ClearTask() {
-            // No-op.
-        }
+        private final Set<? extends K> keys;
 
         /**
          * @param cacheName Cache name.

http://git-wip-us.apache.org/repos/asf/incubator-ignite/blob/a0161d90/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/GridDistributedCacheAdapter.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/GridDistributedCacheAdapter.java
b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/GridDistributedCacheAdapter.java
index c172a87..385c95e 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/GridDistributedCacheAdapter.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/GridDistributedCacheAdapter.java
@@ -249,20 +249,13 @@ public abstract class GridDistributedCacheAdapter<K, V> extends
GridCacheAdapter
         private static final long serialVersionUID = 0L;
 
         /** Cache name. */
-        private String cacheName;
+        private final String cacheName;
 
         /** Affinity topology version. */
-        private AffinityTopologyVersion topVer;
+        private final AffinityTopologyVersion topVer;
 
         /** Skip store flag. */
-        private boolean skipStore;
-
-        /**
-         * Empty constructor for serialization.
-         */
-        public RemoveAllTask(){
-            // No-op.
-        }
+        private final boolean skipStore;
 
         /**
          * @param cacheName Cache name.
@@ -311,14 +304,7 @@ public abstract class GridDistributedCacheAdapter<K, V> extends
GridCacheAdapter
         private static final long serialVersionUID = 0L;
 
         /** Skip store flag. */
-        private boolean skipStore;
-
-        /**
-         * Empty constructor for serialization.
-         */
-        public GlobalRemoveAllJob() {
-            // No-op.
-        }
+        private final boolean skipStore;
 
         /**
          * @param cacheName Cache name.


Mime
View raw message