ignite-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From voze...@apache.org
Subject [17/50] [abbrv] incubator-ignite git commit: Ignite-107 review
Date Tue, 27 Jan 2015 11:00:57 GMT
Ignite-107 review


Project: http://git-wip-us.apache.org/repos/asf/incubator-ignite/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-ignite/commit/d00486f9
Tree: http://git-wip-us.apache.org/repos/asf/incubator-ignite/tree/d00486f9
Diff: http://git-wip-us.apache.org/repos/asf/incubator-ignite/diff/d00486f9

Branch: refs/heads/ignite-16
Commit: d00486f952951cda119d4ec16f2d46c47c0da817
Parents: 3c38a6f
Author: Yakov Zhdanov <yzhdanov@gridgain.com>
Authored: Mon Jan 26 12:37:11 2015 +0300
Committer: Yakov Zhdanov <yzhdanov@gridgain.com>
Committed: Mon Jan 26 12:37:11 2015 +0300

----------------------------------------------------------------------
 .../internal/processors/closure/GridClosureProcessor.java   | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-ignite/blob/d00486f9/modules/core/src/main/java/org/apache/ignite/internal/processors/closure/GridClosureProcessor.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/closure/GridClosureProcessor.java
b/modules/core/src/main/java/org/apache/ignite/internal/processors/closure/GridClosureProcessor.java
index 94a9b32..168e102 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/closure/GridClosureProcessor.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/closure/GridClosureProcessor.java
@@ -969,13 +969,10 @@ public class GridClosureProcessor extends GridProcessorAdapter {
      * @param arg Optional argument.
      * @return Job.
      */
-    @SuppressWarnings("IfMayBeConditional")
     private <T, R> ComputeJob job(final IgniteClosure<T, R> job, @Nullable final
T arg) {
         A.notNull(job, "job");
 
-        if (job instanceof ComputeJobMasterLeaveAware)
-            return new C1MLA<>(job, arg);
-        else return new C1<>(job, arg);
+        return job instanceof ComputeJobMasterLeaveAware ? new C1MLA<>(job, arg) :
new C1<>(job, arg);
     }
 
     /**
@@ -984,7 +981,6 @@ public class GridClosureProcessor extends GridProcessorAdapter {
      * @param c Closure to convert to grid job.
      * @return Grid job made out of closure.
      */
-    @SuppressWarnings("IfMayBeConditional")
     private <R> ComputeJob job(final Callable<R> c) {
         A.notNull(c, "job");
 
@@ -1001,7 +997,6 @@ public class GridClosureProcessor extends GridProcessorAdapter {
      * @param affKey Affinity key.
      * @return Grid job made out of closure.
      */
-    @SuppressWarnings(value = {"IfMayBeConditional", "UnusedDeclaration"})
     private <R> ComputeJob job(final Callable<R> c, @Nullable final String cacheName,
final Object affKey) {
         A.notNull(c, "job");
 
@@ -1016,7 +1011,6 @@ public class GridClosureProcessor extends GridProcessorAdapter {
      * @param r Closure to convert to grid job.
      * @return Grid job made out of closure.
      */
-    @SuppressWarnings("IfMayBeConditional")
     private static ComputeJob job(final Runnable r) {
         A.notNull(r, "job");
 
@@ -1033,7 +1027,6 @@ public class GridClosureProcessor extends GridProcessorAdapter {
      * @param affKey Affinity key.
      * @return Grid job made out of closure.
      */
-    @SuppressWarnings(value = {"IfMayBeConditional", "UnusedDeclaration"})
     private ComputeJob job(final Runnable r, @Nullable final String cacheName, final Object
affKey) {
         A.notNull(r, "job");
 


Mime
View raw message