Return-Path: Delivered-To: apmail-ibatis-user-java-archive@www.apache.org Received: (qmail 77073 invoked from network); 31 Jan 2008 01:37:07 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 31 Jan 2008 01:37:07 -0000 Received: (qmail 99202 invoked by uid 500); 31 Jan 2008 01:36:51 -0000 Delivered-To: apmail-ibatis-user-java-archive@ibatis.apache.org Received: (qmail 99188 invoked by uid 500); 31 Jan 2008 01:36:51 -0000 Mailing-List: contact user-java-help@ibatis.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: user-java@ibatis.apache.org Delivered-To: mailing list user-java@ibatis.apache.org Received: (qmail 99177 invoked by uid 99); 31 Jan 2008 01:36:51 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Jan 2008 17:36:51 -0800 X-ASF-Spam-Status: No, hits=2.4 required=10.0 tests=DNS_FROM_OPENWHOIS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of clamey@localmatters.com designates 216.241.189.144 as permitted sender) Received: from [216.241.189.144] (HELO mailhost01.ad.corp.localmatters.com) (216.241.189.144) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 31 Jan 2008 01:36:37 +0000 X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----_=_NextPart_001_01C863A9.B318BBAC" Subject: RE: Exit out of rowHandler Date: Wed, 30 Jan 2008 18:31:59 -0700 Message-ID: <7A830B033BF360489B6EE305697CD09D0112A0F4@mailhost01> X-MS-Has-Attach: X-MS-TNEF-Correlator: <7A830B033BF360489B6EE305697CD09D0112A0F4@mailhost01> Thread-Topic: Exit out of rowHandler thread-index: AchjmeE7KmlKhCZJQZqs20quc8xNogAC/eyAAADOZZQ= References: <1201716326.31524.1234151879@webmail.messagingengine.com> <2f55db670801301036l5f890babl37e8ec52aea7559d@mail.gmail.com> <1201719088.8102.1234163847@webmail.messagingengine.com> <47a0cd3e.1f588c0a.217e.ffffb5e1@mx.google.com> <47a12054.17bc720a.27d4.750b@mx.google.com> From: "Chris Lamey" To: X-Virus-Checked: Checked by ClamAV on apache.org This is a multi-part message in MIME format. ------_=_NextPart_001_01C863A9.B318BBAC Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Yes, please keep backwards compatability within minor releases. -----Original Message----- From: Clinton Begin [mailto:clinton.begin@gmail.com] Sent: Wed 1/30/2008 6:11 PM To: user-java@ibatis.apache.org; lmeadors@apache.org Subject: RE: Exit out of rowHandler =20 Hehe... Well, considering how much effort I've always put into iBATIS being = backward compatible, why break tradition now? ;-) We can use an adapter and = create a new RowHandler interface. =20 iBATIS 3.0 can merge them into one...as it won't be fully backward compatible anyway. =20 Clinton -----Original Message----- From: larry.meadors@gmail.com [mailto:larry.meadors@gmail.com] On Behalf = Of Larry Meadors Sent: January-30-08 4:43 PM To: user-java@ibatis.apache.org Subject: Re: Exit out of rowHandler Meh, it'll break compatibility, but it adds a great deal of useful functionality for very little cost. In addition, the 'fix' is to add a "return true;" to existing code. I wouldn't consider that particularly onerous...unless you have like 1000 row handlers, in which case, you probably *deserve* some pain. ;-) I think it's a great idea. Larry On Jan 30, 2008 2:45 PM, Jeff Butler wrote: > I can't think of any other use for the return value, so I like the = idea. > The only drawback is that this will break existing row handlers. This could > be an argument in favor of the two parameter approach - because it = could be > an overloaded method. Of course, any change to the interface is going = to > cause headaches for existing row handlers. Maybe we should provide adapter > classes like AWT? > > Did I just suggest using AWT as a model? > > Jeff Butler > > > > On Jan 30, 2008 1:17 PM, Clinton Begin = wrote: > > > > > Hmmm... would it be horrible if the return value of handleRow() was = a > > boolean for "continue"? > > > > // don't mind the verbosity or any misplaced > > // capital letters...thank you outlook > > public boolean handleRow (Object valueObject) { > > boolean continue =3D true; > > if (someCondition) { > > continue =3D false; > > } > > return continue; > > } > > > > I hate to suggest making use of the return value, because there is = only > > one...but it isn't used right now. Is this the best use of the = return > > value? The alternative is to use a second parameter for controls... > > > > public void handleRow (ResultSetControl control, Object valueObject) = { > > if (someCondition) { > > control.setContinue(false); > > } > > } > > > > Sorry if this has already been discussed, it's more of a dev@ issue, = but > > since we're talking about it here... > > > > Thoughts? > > > > Clinton > > > > > > > > > ------_=_NextPart_001_01C863A9.B318BBAC Content-Type: application/ms-tnef; name="winmail.dat" Content-Transfer-Encoding: base64 eJ8+Ih0BAQaQCAAEAAAAAAABAAEAAQeQBgAIAAAA5AQAAAAAAADoAAEIgAcAGAAAAElQTS5NaWNy b3NvZnQgTWFpbC5Ob3RlADEIAQ2ABAACAAAAAgACAAEEgAEAGwAAAFJFOiBFeGl0IG91dCBvZiBy b3dIYW5kbGVyAC4JAQWAAwAOAAAA2AcBAB4AEgAfADsAAwBtAQEggAMADgAAANgHAQAeABIAJAAc AAMAUwEBCYABACEAAABFRjQ4OTEzNkM5NkFFMTRDOUUyNTNGNzdDOTdDRkE5MwBfBwEDkAYAoA8A ADkAAAADACYAAAAAAAMANgAAAAAAQAA5AJxOfxKpY8gBHgA9AAEAAAAFAAAAUkU6IAAAAAACAUcA AQAAADEAAABjPVVTO2E9IDtwPUxNSTE7bD1NQUlMSE9TVDAxLTA4MDEzMTAxMzYyOFotMTAwMzQA AAAAHgBJAAEAAAAbAAAAUkU6IEV4aXQgb3V0IG9mIHJvd0hhbmRsZXIAAEAATgCAPeA4pmPIAR4A WgABAAAADgAAAENsaW50b24gQmVnaW4AAAACAVsAAQAAAEMAAAAAAAAAgSsfpL6jEBmdbgDdAQ9U AgAAAABDbGludG9uIEJlZ2luAFNNVFAAY2xpbnRvbi5iZWdpbkBnbWFpbC5jb20AAAIBXAABAAAA HQAAAFNNVFA6Q0xJTlRPTi5CRUdJTkBHTUFJTC5DT00AAAAAHgBdAAEAAAAOAAAAQ2xpbnRvbiBC ZWdpbgAAAAIBXgABAAAAQwAAAAAAAACBKx+kvqMQGZ1uAN0BD1QCAAAAAENsaW50b24gQmVnaW4A U01UUABjbGludG9uLmJlZ2luQGdtYWlsLmNvbQAAAgFfAAEAAAAdAAAAU01UUDpDTElOVE9OLkJF R0lOQEdNQUlMLkNPTQAAAAAeAGYAAQAAAAUAAABTTVRQAAAAAB4AZwABAAAAGAAAAGNsaW50b24u YmVnaW5AZ21haWwuY29tAB4AaAABAAAABQAAAFNNVFAAAAAAHgBpAAEAAAAYAAAAY2xpbnRvbi5i ZWdpbkBnbWFpbC5jb20AHgBwAAEAAAAXAAAARXhpdCBvdXQgb2Ygcm93SGFuZGxlcgAAAgFxAAEA AAAgAAAAAchjmeE7KmlKhCZJQZqs20quc8xNogAC/eyAAADOZZQeAHQAAQAAADEAAAB1c2VyLWph dmFAaWJhdGlzLmFwYWNoZS5vcmc7IGxtZWFkb3JzQGFwYWNoZS5vcmcAAAAAHgAaDAEAAAAMAAAA Q2hyaXMgTGFtZXkAHgAdDgEAAAAXAAAARXhpdCBvdXQgb2Ygcm93SGFuZGxlcgAAAgEJEAEAAABX BwAAUwcAAFINAABMWkZ1Q0n+4QMACgByY3BnMTI14jIDQ3RleAVBAQMB9/8KgAKkA+QHEwKAD/MA UARWPwhVB7IRJQ5RAwECAGNo4QrAc2V0MgYABsMRJfYzBEYTtzASLBEzCO8J97Y7GB8OMDURIgxg YwBQMwsJAWQzNhZQC6YgWUkHkCwgC1BlYRQQICJrCeBwIGIA0Gt3dwsRBCAFoG0KsAGRAxBpSHR5 IAPwdGgLgCCebQuABbEYIB1Tcy4KoqsKhAqALSGiTwUQZwuAhwdABdAHkHNhZ2Uho/Ug5EYDYToS IB8wAjACIMggQmUiISBbAMADEEkkQDpjJBQuYiSSQOpnJPIuHqFdIOQGYAIwBSPgVwmAIDEvMzAC LwHQMDggNjoxUDEgUE0g5FQlQCACdRQQci1qYXZhlEBpHgB0BAAuYQqwCRPQZS4FsGc7IGzJB4Bh ZAWwc0AqqCblmHViagWQJ3FSRSPgtEV4H0AgCGAt8WYgQKhvd0gAcGQdUHIg5PMK4wqASGUq4TAw IOonoHxsbB0gBaAAgQSBC4BnnCBoLpAf4BrQaCABEeEXwSBJJ3YdkAdAHkA6eQQgcC4hJCI0MEJB /FRJBfAl4DICHgYg5B6kpyowHVAdIHdoH2BiGCBgYWsgdHIrkB9AaQMkUSAQdz8gIDst/ik4gCeg HpADkSmRM4ADoP8rkCqgDrAFwC7BHpA3UQ6wfSDkYTgwB9MupjQyBJBmnwDQKvA4gCDqNJUzLhZQ nzkiB4ArIB2QH6BlbTQ0XwIgMCIdcDQwBUB3AiAn4wVAJeAgZnUxQDchNX/7NoQ5kXkzsTz9JAUg 7yH/8yMOC2ByckNgK3YmRyTXs0f/JnUgTyRiE+BsLmD0T2ZE1ExKAkZhK5Mm6kpKAHB1CsB5LSgA LeEoUTQ6NDMozynfLD+9LUNlLa8uu0TURnBoHSB9H0AnMUA3NTZGHyMdIGJ/NBIFQCuQHnE7UAnB HuAgfwEARkFTkVAhQSFE1EEgbt8tQDgBB0AfQjLxIDNgTNFNHzF0QuEFoHN0PPBJDzmyN9QdID8x ICdmafx4JzQwBCA0YVeRM4BE1HoiGCB0CHADoDegClA7/iJdcg7ABAAqYDIRBaABAPdbwUCBQTBk QLIxhj8hWDH7CrEqYGNBMArAQVBE1D/RvwNgUCAwMVmwHVAEEXkIYP8yMFCAHZAfMB2wJ9AoQBZQ /y6BZGEu0x0RH8E3AA3gMrDfOSAUEB0gZDFE1HADYB4AOwJgH2AqAQBQMTNgKiD+cwNwHZAKsAuA PPA4oUTav2BwH6I3gFVxV8gxwWEg279Mo0TaRNRLgU4xPkAwHSC1KDMyTyA1T1EdIEoBEbckcFNg PCI8LSABIGdXIbsu8SY4Ph9wA2AOsDpE1P9yEGBwOSFAwWq0U5FDEVNA/z8xBcA5YlqCXLJedVCQ CkF/HSBo8GBhZMNcsmvpchBU11zBAiBBUWQ3sHceAl1D/2HCH6EEIAPwVadfh2VqPPH/eBAEADXm YLFylkDxOaIrIN51B4ACMGYyPLB2BbFTkW1csnRAkGHyYQeAOhNw82fBKsEgLTTxOSA5YlMh73zZ JeBylgORb1rBF7ArkPcnsYARMkBkPPFMIIHCFAH/HSB0IhPRMhA/ETRwdwM8dvldQmdvMgIkQHKW gUQq4L850SrRBCBagnq/e8VNM8D1QPF3HZBzMkBgsR0wA2D+djHBOvU55Ie3C2AEEAeRYWTDQVdU P3KVcpY8zYuAdVegBJA+RDHAYGHGalAgBUBzdWdGwJDBP1AgMgKOgTOAV8IEYmw//Dwvj8aOzW/5 jsyOzW5u2jEokDdvoyQMPCVvcb/jjvqbqCBIbZzwMDFghP9AUkDxMkBKEELDBpB1P1OC+2WkO7Eo OMAeQFfBnEgG4O8G8B1gfqEFsSIxgV/BClDmIo62nCovL1hQQKMf8f8nwFyyWsEG4ACQH1EFsXQi fR/wcwtRPNB9F6RTOSBw/x9ARkEdUAJAe9IwMGGxauHnZDJTURewb2ucSDQAAmDHDeChx6AnIChP LRN15HusdDjAXAAAnFehx6KmIO49XtSt2Z6xKGjyCFAu0N83462dOICvCTywbBQQr/r8XH2t2V51 oqav+bSZnEjfYHBhwYXTkPYAwGsyAjli/38ldYyBJnRyhuN4UpxIP9S/VyUEAECyUCEnwEXxaAVA +zhBPPFJeUJ5Mx2QJeCRQ/+6DZxIdfM4cHgSB0A6EUYw/ypgM2FdVDljaOAFkTphf9j/WoKiogNg s6AwN5wbqtV+4L+QUavJUsCQ8CUgBmB0sTH/xhLF1h0grH+tjrC/sc/F5a4uFBHJwqLiKLODKbPf +7afnDlTnjEfYJ6zXVET4PVXwWw3UWQ3IQnhWFAEAPtiUI3hZFVTBCAEYLwhc/L5WFF2QF1BkPC7 QlNgnEj3kYGG0YtQJ7whqEG5kwGg/1NSUyG8AsZvnJN4EAhgvwH+c6M/nLFEa5wa3s+TXETaAn3i EAAeADUQAQAAADYAAAA8N0E4MzBCMDMzQkYzNjA0ODlCNkVFMzA1Njk3Q0QwOUQwMTEyQTBGNEBt YWlsaG9zdDAxPgAAAB4AORABAAAAtQEAADxDM0M2MDMxRS4zREE3JWNsYW1leUBsb2NhbG1hdHRl cnMuY29tPgkgPDEyMDE3MTYzMjYuMzE1MjQuMTIzNDE1MTg3OUB3ZWJtYWlsLm1lc3NhZ2luZ2Vu Z2luZS5jb20+CSA8MmY1NWRiNjcwODAxMzAxMDM2bDVmODkwYmFibDM3ZThlYzUyYWVhNzU1OWRA bWFpbC5nbWFpbC5jb20+CSA8MTIwMTcxOTA4OC44MTAyLjEyMzQxNjM4NDdAd2VibWFpbC5tZXNz YWdpbmdlbmdpbmUuY29tPgkgPDQ3YTBjZDNlLjFmNTg4YzBhLjIxN2UuZmZmZmI1ZTFAbXguZ29v Z2xlLmNvbT4JIDxjNTkzYjg3NTA4MDEzMDEzNDV2MmYzYjRmYTRrMmFmYTRjZWE2OTdjMjY2OUBt YWlsLmdtYWlsLmNvbT4gPGExMGE4MjNjMDgwMTMwMTU0Mm1hY2YwNjRmdjljOGQ0NjJhYjAyOTY2 MzBAbWFpbC5nbWFpbC5jb20+IDw0N2ExMjA1NC4xN2JjNzIwYS4yN2Q0Ljc1MGJAbXguZ29vZ2xl LmNvbT4AAAAAHgBHEAEAAAAPAAAAbWVzc2FnZS9yZmM4MjIAAAsA8hABAAAAHwDzEAEAAABCAAAA UgBFACUAMwBBACAARQB4AGkAdAAgAG8AdQB0ACAAbwBmACAAcgBvAHcASABhAG4AZABsAGUAcgAu AEUATQBMAAAAAAALAPYQAAAAAEAABzCcTn8SqWPIAUAACDAcRSKzqWPIAQMA3j+vbwAAAwDxPwkE AAAeAPg/AQAAAAwAAABDaHJpcyBMYW1leQACAfk/AQAAAFoAAAAAAAAA3KdAyMBCEBq0uQgAKy/h ggEAAAAAAAAAL089TE1JMS9PVT1GSVJTVCBBRE1JTklTVFJBVElWRSBHUk9VUC9DTj1SRUNJUElF TlRTL0NOPUNMQU1FWQAAAB4A+j8BAAAAFQAAAFN5c3RlbSBBZG1pbmlzdHJhdG9yAAAAAAIB+z8B AAAAHgAAAAAAAADcp0DIwEIQGrS5CAArL+GCAQAAAAAAAAAuAAAAAwD9P+QEAAADABlAAAAAAAMA GkAAAAAAAwAdQAAAAAADAB5AAAAAAB4AMEABAAAABwAAAENMQU1FWQAAHgAxQAEAAAAHAAAAQ0xB TUVZAAAeADJAAQAAABgAAABjbGludG9uLmJlZ2luQGdtYWlsLmNvbQAeADNAAQAAABgAAABjbGlu dG9uLmJlZ2luQGdtYWlsLmNvbQAeADhAAQAAAAcAAABDTEFNRVkAAB4AOUABAAAAAgAAAC4AAAAD AHZA/////wsAKQAAAAAACwAjAAAAAAADAAYQ4qC3rwMABxDhBwAAAwAQEAAAAAADABEQCQAAAB4A CBABAAAAZQAAAFlFUyxQTEVBU0VLRUVQQkFDS1dBUkRTQ09NUEFUQUJJTElUWVdJVEhJTk1JTk9S UkVMRUFTRVMtLS0tLU9SSUdJTkFMTUVTU0FHRS0tLS0tRlJPTTpDTElOVE9OQkVHSU5NQUkAAAAA AgF/AAEAAAA2AAAAPDdBODMwQjAzM0JGMzYwNDg5QjZFRTMwNTY5N0NEMDlEMDExMkEwRjRAbWFp bGhvc3QwMT4AAAAimw== ------_=_NextPart_001_01C863A9.B318BBAC--