Mailing-List: contact user-java-help@ibatis.apache.org; run by ezmlm
Precedence: bulk
Reply-To: user-java@ibatis.apache.org
Received-SPF: pass (nike.apache.org: local policy)
Mime-Version: 1.0 (Apple Message framework v752.2)
In-Reply-To: <c0312f5d0711120927h2a79b398od1d0240d05be43e8@mail.gmail.com>
References: <0E917E26-AC4F-4B89-BB3F-B594899F4389@smartgames.ca>
 <c0312f5d0711120927h2a79b398od1d0240d05be43e8@mail.gmail.com>
Content-Type: text/plain; charset=US-ASCII; format=flowed
Message-Id: <CEFE42FD-992E-4004-80C8-9489C8FBD4A8@smartgames.ca>
Content-Transfer-Encoding: 7bit
From: Toby Thain <toby@smartgames.ca>
Subject: Re: proper use of start/endTransaction()
Date: Mon, 12 Nov 2007 15:56:17 -0200
To: user-java@ibatis.apache.org


On 12-Nov-07, at 3:27 PM, Gwyn Evans wrote:

> No idea if it's possible, but the first case allows for the
> transaction being created then an exception being thrown in the
> 'start' operation, whereas with the second case, that would leave the
> transaction open.

Wouldn't that be a bug?

--Toby

>
> /Gwyn
>
> On 12/11/2007, Toby Thain <toby@smartgames.ca> wrote:
>> Hi,
>>
>> A little thought has been bothering me for a while and I thought I
>> would put it to the experts.
>>
>> The iBATIS manual advises the following logic for transactions:
>>
>> try {
>>         sqlMap.startTransaction ();
>>         // ...queries
>>         sqlMap.commitTransaction ();
>> } finally {
>>         sqlMap.endTransaction ();
>> }
>>
>> I am curious if it would be more strictly correct to:
>>
>> sqlMap.startTransaction ();
>> try {
>>         // ...queries
>>         sqlMap.commitTransaction ();
>> } finally {
>>         sqlMap.endTransaction ();
>> }
>>
>> In the event that startTransaction() itself throws an Exception...
>>
>> Thoughts?
>> --Toby
>>
>
>
> -- 
> Download Wicket 1.3.0-rc1 now! - http://wicketframework.org