Return-Path: Delivered-To: apmail-ibatis-user-java-archive@www.apache.org Received: (qmail 24272 invoked from network); 19 Mar 2007 15:22:42 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 19 Mar 2007 15:22:42 -0000 Received: (qmail 55543 invoked by uid 500); 19 Mar 2007 15:22:45 -0000 Delivered-To: apmail-ibatis-user-java-archive@ibatis.apache.org Received: (qmail 55527 invoked by uid 500); 19 Mar 2007 15:22:45 -0000 Mailing-List: contact user-java-help@ibatis.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: user-java@ibatis.apache.org Delivered-To: mailing list user-java@ibatis.apache.org Received: (qmail 55513 invoked by uid 99); 19 Mar 2007 15:22:45 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Mar 2007 08:22:45 -0700 X-ASF-Spam-Status: No, hits=2.0 required=10.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of nathan.maves@gmail.com designates 64.233.182.189 as permitted sender) Received: from [64.233.182.189] (HELO nf-out-0910.google.com) (64.233.182.189) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Mar 2007 08:22:35 -0700 Received: by nf-out-0910.google.com with SMTP id l24so1061027nfc for ; Mon, 19 Mar 2007 08:22:13 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references; b=BCCF159bl/bx96aArkKPM3EARfhvDHhk/yMyamHgAO5wA8YqfLQKW4hkHuGFfeJrOWAQTNbPUhKmUEeYefV0GIsM4pf7Pep64+DpGubxBazqLqATAyzLyf1ljwPZ+ejcpliFQ24l2I94jJ2J7OEPA63sF/xQXClgjlLspxn4vbA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references; b=nyCBtrIt5HO3RkBzfk8LH9LkWZstz8OfC5jg8mWIt6iPVTBedLNdAhydMy+nnAFFCiaS4AbXdx8Or/aKgcPW9tvXYqGNXVmvUYm6QkRWQ3l7LfqWQ1we1God3Mi8M+48spiXuyCigSTpOnz7u174u4rAPXRScuQ+i6pemxXAO0k= Received: by 10.78.39.16 with SMTP id m16mr2458481hum.1174317733363; Mon, 19 Mar 2007 08:22:13 -0700 (PDT) Received: by 10.78.58.10 with HTTP; Mon, 19 Mar 2007 08:22:13 -0700 (PDT) Message-ID: <2f55db670703190822p465a13f3vbd576f296c193ad6@mail.gmail.com> Date: Mon, 19 Mar 2007 09:22:13 -0600 From: "Nathan Maves" To: user-java@ibatis.apache.org Subject: Re: iBATIS in Action errata In-Reply-To: <295494f50703190811w1c8a7148n9daebf123b01b2d5@mail.gmail.com> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_92679_15029839.1174317733299" References: <295494f50703160628y6562e6aeq33006bd12ac362de@mail.gmail.com> <295494f50703181155s12f2c770r687511c4862465e5@mail.gmail.com> <16178eb10703181520t706695c0tdf70fa3ca162e6e7@mail.gmail.com> <295494f50703190811w1c8a7148n9daebf123b01b2d5@mail.gmail.com> X-Virus-Checked: Checked by ClamAV on apache.org ------=_Part_92679_15029839.1174317733299 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline Check out pg 294-5. In Listing 13.5 we define a method called getValidatedPerson(). But in the test case in Listing 13.6 we call service.isPersonalInformationValid(). Not only is this the wrong method but we do not capture the return value. All in all the test case is just confusing. Nathan On 3/19/07, Ted Schrader wrote: > > I've only made it to page 95 so far. I haven't found anything nearly > as bad/weird as the 149-150 disconnect. > > The worst thing I've found so far is the entry in Table > 4.3 (page 87) telling me that Section 5.5 can be found in Chapter 8. > > I've been marking my findings; I'll submit them to Manning once they > get things situated. > > With that out of the way, I'm finding the text very readable. I also > appreciate the pragmatic advice that only comes with experience, such > as the bit about skinny data models. The following excerpt from > section 2.3.4 "Separation of concerns" really hits home because I > inherited four or five "Model 1" JSP web apps a couple of years ago, > and have just inherited another one: > > "We've all seen the nasty applications with database connections and > statements in JSP pages, results being iterated over, and HTML in > between it all. It's truly nightmarish." > > Indeed. > > Ted > > On 18/03/07, Larry Meadors wrote: > > Heh, I was reading over it this weekend, and saw a good one on pages > > 149-150. It just sort of stops in the middle of a sentence and resumes > > on the next page with the next paragraph. > > > > Larry > > > > > > On 3/18/07, Clinton Begin wrote: > > > Chalk that up to editing! Whooho! > > > > > > Just kidding. Karma will get me for that. ;-) I'll ask Manning about > a > > > section for that and post it back here. > > > > > > Cheers, > > > Clinton > > > > > > > > > On 3/18/07, Ted Schrader wrote: > > > > Yeah, a few things; mostly minor typos in explanations and > references > > > > to wrong section numbers. I haven't found anything wrong with the > > > > code, but I'm only up to chapter 5. > > > > > > > > Ted > > > > > > > > On 16/03/07, Larry Meadors < lmeadors@apache.org> wrote: > > > > > Not that I am aware of...not yet anyway. Did you find something? > > > > > > > > > > Larry > > > > > > > > > > > > > > > On 3/16/07, Ted Schrader < teds.mailing.lists@gmail.com> wrote: > > > > > > Hello, > > > > > > > > > > > > Does the book have an errata listing/submission page? I prodded > > > > > > manning.com a bit but couldn't find much. > > > > > > > > > > > > Thanks, > > > > > > > > > > > > Ted > > > > > > > > > > > > > > > > > > > > > > > > ------=_Part_92679_15029839.1174317733299 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Check out pg 294-5.

In Listing 13.5 we define a method called getValidatedPerson().

But in the test case in Listing 13.6 we call service.isPersonalInformationValid().  Not only is this the wrong method but we do not capture the return value.  All in all the test case is just confusing.

Nathan

On 3/19/07, Ted Schrader <teds.mailing.lists@gmail.com> wrote:
I've only made it to page 95 so far. I haven't found anything nearly
as bad/weird as the 149-150 disconnect.

The worst thing I've found so far is the <procedure> entry in Table
4.3 (page 87) telling me that Section 5.5 can be found in Chapter 8.

I've been marking my findings; I'll submit them to Manning once they
get things situated.

With that out of the way, I'm finding the text very readable.  I also
appreciate the pragmatic advice that only comes with experience, such
as the bit about skinny data models.  The following excerpt from
section 2.3.4 "Separation of concerns" really hits home because I
inherited four or five "Model 1" JSP web apps a couple of years ago,
and have just inherited another one:

"We've all seen the nasty applications with database connections and
statements in JSP pages, results being iterated over, and HTML in
between it all.  It's truly nightmarish."

Indeed.

Ted

On 18/03/07, Larry Meadors <lmeadors@apache.org> wrote:
> Heh, I was reading over it this weekend, and saw a good one on pages
> 149-150. It just sort of stops in the middle of a sentence and resumes
> on the next page with the next paragraph.
>
> Larry
>
>
> On 3/18/07, Clinton Begin <clinton.begin@gmail.com> wrote:
> > Chalk that up to editing!  Whooho!
> >
> > Just kidding. Karma will get me for that.  ;-)  I'll ask Manning about a
> > section for that and post it back here.
> >
> > Cheers,
> > Clinton
> >
> >
> >  On 3/18/07, Ted Schrader <teds.mailing.lists@gmail.com> wrote:
> > > Yeah, a few things;  mostly minor typos in explanations and references
> > > to wrong section numbers.  I haven't found anything wrong with the
> > > code, but I'm only up to chapter 5.
> > >
> > > Ted
> > >
> > > On 16/03/07, Larry Meadors < lmeadors@apache.org> wrote:
> > > > Not that I am aware of...not yet anyway. Did you find something?
> > > >
> > > > Larry
> > > >
> > > >
> > > > On 3/16/07, Ted Schrader < teds.mailing.lists@gmail.com> wrote:
> > > > > Hello,
> > > > >
> > > > > Does the book have an errata listing/submission page?  I prodded
> > > > > manning.com a bit but couldn't find much.
> > > > >
> > > > > Thanks,
> > > > >
> > > > > Ted
> > > > >
> > > >
> > >
> >
> >
>

------=_Part_92679_15029839.1174317733299--