Return-Path: Delivered-To: apmail-ibatis-user-java-archive@www.apache.org Received: (qmail 21871 invoked from network); 16 Feb 2006 19:13:27 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 16 Feb 2006 19:13:27 -0000 Received: (qmail 65010 invoked by uid 500); 16 Feb 2006 19:13:25 -0000 Delivered-To: apmail-ibatis-user-java-archive@ibatis.apache.org Received: (qmail 64997 invoked by uid 500); 16 Feb 2006 19:13:25 -0000 Mailing-List: contact user-java-help@ibatis.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: user-java@ibatis.apache.org Delivered-To: mailing list user-java@ibatis.apache.org Received: (qmail 64986 invoked by uid 99); 16 Feb 2006 19:13:24 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Feb 2006 11:13:24 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of mark.bennett.mail@gmail.com designates 64.233.182.203 as permitted sender) Received: from [64.233.182.203] (HELO nproxy.gmail.com) (64.233.182.203) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Feb 2006 11:13:24 -0800 Received: by nproxy.gmail.com with SMTP id p77so15709nfc for ; Thu, 16 Feb 2006 11:13:02 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references; b=YZvBiH44wDnBxAhG2caoqAdNHhHhbCW8Ud9UhsycVRCydg4CrUfdLq5+VY9gvSIbOgeoEy2eP3CG+4Mbj/vAS4sxs8u5cEbBAE5iL42PZuoJmoIeEmFZz3rRaY/uxCKoTEkZJzgHNpZAwm12gh3nDISWdveFo6Lx9oZ2tfZ/HfE= Received: by 10.48.243.18 with SMTP id q18mr240559nfh; Thu, 16 Feb 2006 11:13:02 -0800 (PST) Received: by 10.48.31.12 with HTTP; Thu, 16 Feb 2006 11:13:02 -0800 (PST) Message-ID: Date: Thu, 16 Feb 2006 14:13:02 -0500 From: Mark Bennett To: user-java@ibatis.apache.org Subject: Re: Found two bugs in Abator In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_9232_10647293.1140117182524" References: <200602161326.AHU75798@persistent.co.in> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N ------=_Part_9232_10647293.1140117182524 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Not really exponentially. Its linear with a factor of 70 lines or so in the DAOImpl. Or by a factor of the 10 or so possible operations. I just didn'= t want people to get overly worried about it. Mark On 2/16/06, Jeff Butler wrote: > > Thanks for reporting these. I'll take a look. > > The more I think about it, the more I dislike the way that I'm generating > the "by example" methods. As you've seen, it creates a tremendous amount = of > code that grows exponentially as the fields in the table increase. I'll > definitiely have to think of a better way. Something else, that doesn't > apply in your case, is that the processor cycles required to do a merge i= n > Eclipse are enormous with these huge methods. > > Jeff Butler > > > On 2/16/06, Rashmi Dave wrote: > > > > Hi Jeff, > > > > 1. I specified the following mapping in Abator config > > > > > > > EOBONE.ADDRESS_SEQ.NEXTVAL FROM DUAL" > > identity=3D"false"/> > >

> > > > Here, I provided the incorrect column name for the generated Key. Abato= r > > > > threw an NPE for this. > > > > > > 2. I have a table with a large number of columns - 150. Now I used > > Abator to > > generate the DAO classes. The DAOImpl class for this refused to compile > > because the following function > > > > private Map getExampleParms(RemitExample example) > > > > threw an error "code too large" > > > > I had to pull out switch statements create a number of other functions > > and > > call these from here, only then did this error go. Can we generate this > > function in another way so that it is made up of calls to smaller > > functions? > > > > (I am using abator0.6.0.zip) > > > > Thanks > > ~Rashmi > > > > > ------=_Part_9232_10647293.1140117182524 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Not really exponentially. Its linear with a factor of 70 lines or so in the= DAOImpl. Or by a factor of the 10 or so possible operations. I= just didn't want people to get overly worried about it.

Mark

On 2/16/06, Jeff = Butler <jeffgbutler@gmail.c= om> wrote:

Thanks for reporting these. I'll take a look.

The more I think about it, the more I dislike the way that I'm generat= ing the "by example" methods. As you've seen, it creates a tremen= dous amount of code that grows exponentially as the fields in the table inc= rease. I'll definitiely have to think of a better way. Somethin= g else, that doesn't apply in your case, is that the processor cycles requi= red to do a merge in Eclipse are enormous with these huge methods.

Jeff Butler

On 2/16/06, = Rashmi Dave <rashmid@per= sistent.co.in > wrote:
Hi Jeff,

1= . I specified the following mapping in Abator config

   &l= t;table schema=3D"ONE" tableName=3D"ADDRESS">
   <generatedKey column=3D"ADDRESS_ID" sqlStatem= ent=3D"SELECT
EOBONE.ADDRESS_SEQ.NEXTVAL FROM DUAL"
&= nbsp;           &nbs= p;     identity=3D"false"/>
  = ;     </table>

Here, I provided the incorr= ect column name for the generated Key. Abator
threw an NPE for this.

2. I have a table with a large number= of columns - 150. Now I used Abator to
generate the DAO classes. The DA= OImpl class for this refused to compile
because the following function

private Map getExampleParms(RemitExample example)

threw an e= rror "code too large"

I had to pull out switch statements = create a number of other functions and
call these from here, only then d= id this error go. Can we generate this
function in another way so that it is made up of calls to smaller funct= ions?

(I am using abator0.6.0.zip)

Thanks
~Rashmi

<= /blockquote>

------=_Part_9232_10647293.1140117182524--