Return-Path: Delivered-To: apmail-ibatis-dev-archive@www.apache.org Received: (qmail 23251 invoked from network); 19 Jul 2006 06:45:39 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 19 Jul 2006 06:45:39 -0000 Received: (qmail 91108 invoked by uid 500); 19 Jul 2006 06:45:39 -0000 Delivered-To: apmail-ibatis-dev-archive@ibatis.apache.org Received: (qmail 91085 invoked by uid 500); 19 Jul 2006 06:45:39 -0000 Mailing-List: contact dev-help@ibatis.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ibatis.apache.org Delivered-To: mailing list dev@ibatis.apache.org Received: (qmail 91074 invoked by uid 99); 19 Jul 2006 06:45:39 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Jul 2006 23:45:39 -0700 X-ASF-Spam-Status: No, hits=0.5 required=10.0 tests=DNS_FROM_RFC_ABUSE,HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of ibatis.net@gmail.com designates 64.233.166.181 as permitted sender) Received: from [64.233.166.181] (HELO py-out-1112.google.com) (64.233.166.181) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Jul 2006 23:45:38 -0700 Received: by py-out-1112.google.com with SMTP id f28so214136pyf for ; Tue, 18 Jul 2006 23:45:18 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references; b=kLpGAYZX2DcYI0t2NvxMmTmzuDRrJJxpgjMz895wmsnWOxHNfaQ5y4jgyI877coGVUksEzoOq3CIhO9e7ejWTRPB1ohq33+c/LqQwpqX+Ka/s9gB8WNFYvhHUCxLlKTk21kOM7XmzrGrmFNskgqxphoV7el3cBROFIDVyS1JEQo= Received: by 10.35.18.18 with SMTP id v18mr604660pyi; Tue, 18 Jul 2006 23:45:18 -0700 (PDT) Received: by 10.35.108.6 with HTTP; Tue, 18 Jul 2006 23:45:18 -0700 (PDT) Message-ID: Date: Wed, 19 Jul 2006 08:45:18 +0200 From: "Gilles Bayon" To: dev@ibatis.apache.org Subject: Re: IBATISNET-167, IBATISNET-170, IBATISNET-172 In-Reply-To: <20060719012204.82030.qmail@web30501.mail.mud.yahoo.com> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_49329_18538780.1153291518204" References: <20060719012204.82030.qmail@web30501.mail.mud.yahoo.com> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N ------=_Part_49329_18538780.1153291518204 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline When you are 'using() block' you can pass the dataReader by ref. To resolve IBATISNET-172 and improve IDataReader memory transformation, I need to pass the dataReader by ref to the result strategy, so I replace the using block by a try catch with indeed is the same. We need it because it there is an exception in the result strategy the IDataReader must be close, this was done by the using block and now by the try/catch/finally. do we need the catch, I don't know be but in doubt. ------=_Part_49329_18538780.1153291518204 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline
When you are 'using() block' you can pass the dataReader by ref.
To resolve IBATISNET-172 and improve IDataReader memory transformation, I need to pass the dataReader by ref to the result strategy, so I replace the using block by a try catch with indeed is the same.
 
We need it because it there is an exception in the result strategy the IDataReader must be close, this was done by the using block and now by the try/catch/finally.
 
do we need the catch, I don't know be but in doubt.
------=_Part_49329_18538780.1153291518204--