Return-Path: Delivered-To: apmail-ibatis-dev-archive@www.apache.org Received: (qmail 83476 invoked from network); 19 Jul 2006 16:30:33 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 19 Jul 2006 16:30:33 -0000 Received: (qmail 95748 invoked by uid 500); 19 Jul 2006 16:30:33 -0000 Delivered-To: apmail-ibatis-dev-archive@ibatis.apache.org Received: (qmail 95732 invoked by uid 500); 19 Jul 2006 16:30:32 -0000 Mailing-List: contact dev-help@ibatis.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ibatis.apache.org Delivered-To: mailing list dev@ibatis.apache.org Received: (qmail 95721 invoked by uid 99); 19 Jul 2006 16:30:32 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Jul 2006 09:30:32 -0700 X-ASF-Spam-Status: No, hits=2.8 required=10.0 tests=DNS_FROM_RFC_ABUSE,DNS_FROM_RFC_POST,DNS_FROM_RFC_WHOIS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [68.142.200.122] (HELO web30509.mail.mud.yahoo.com) (68.142.200.122) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 19 Jul 2006 09:30:31 -0700 Received: (qmail 37968 invoked by uid 60001); 19 Jul 2006 16:30:10 -0000 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=Message-ID:Received:Date:From:Subject:To:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding; b=HBjjpOKqty3t7Z0xHjZLKX/qOdZY2kk03h2+Yf2rfG31DUpCb7o9IEnOYPp4OkxHZKtovGBknE9U8W40RBitEA8U/93fIAzSn9Sn5ZG6E1+4v/BFVyKAsDsYAp/fsIqlUpHmFGxIcU3NiofjncRHcQl0XO7ShWn9x7h8tkp2x1Q= ; Message-ID: <20060719163010.37966.qmail@web30509.mail.mud.yahoo.com> Received: from [65.24.255.41] by web30509.mail.mud.yahoo.com via HTTP; Wed, 19 Jul 2006 09:30:10 PDT Date: Wed, 19 Jul 2006 09:30:10 -0700 (PDT) From: Ron Grabowski Subject: Re: IBATISNET-167, IBATISNET-170, IBATISNET-172 To: dev@ibatis.apache.org In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Was this the actual fix for IBATISNET-172...removing the call to ToUpper()? http://tinyurl.com/qst4e http://svn.apache.org/viewvc/ibatis/trunk/cs/mapper/IBatisNet.DataMapper/MappedStatements/ReaderAutoMapper.cs?p2=%2Fibatis%2Ftrunk%2Fcs%2Fmapper%2FIBatisNet.DataMapper%2FMappedStatements%2FReaderAutoMapper.cs&p1=%2Fibatis%2Ftrunk%2Fcs%2Fmapper%2FIBatisNet.DataMapper%2FMappedStatements%2FReaderAutoMapper.cs&r1=423230&r2=423229&view=diff&pathrev=423230 --- Gilles Bayon wrote: > When you are 'using() block' you can pass the dataReader by ref. > To resolve > IBATISNET-172 > and > improve IDataReader memory transformation, I need to pass the > dataReader by > ref to the result strategy, so I replace the using block by a try > catch with > indeed is the same. > > We need it because it there is an exception in the result strategy > the > IDataReader must be close, this was done by the using block and now > by the > try/catch/finally. > > do we need the catch, I don't know be but in doubt. >