ibatis-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Larry Meadors (JIRA)" <ibatis-...@incubator.apache.org>
Subject [jira] Commented: (IBATIS-143) Remove blanks in SQL
Date Sun, 12 Jun 2005 05:00:48 GMT
    [ http://issues.apache.org/jira/browse/IBATIS-143?page=comments#action_12313383 ] 

Larry Meadors commented on IBATIS-143:

I am not crazy about us doing *anything* the SQL besides the explicity defined dynamic stuff.

The removal of new lines in the SQL was done only because it made the crappy IBM driver blow

That change IMO is acceptable, because without it iBATIS would not work.

This one does not fall into that category, and is just as likely to cause undesired side-effects...for
the sake of prettier logs?

I think we have more important things on the list.

> Remove blanks in SQL
> --------------------
>          Key: IBATIS-143
>          URL: http://issues.apache.org/jira/browse/IBATIS-143
>      Project: iBatis for Java
>         Type: Improvement
>   Components: SQL Maps
>  Environment: all
>     Reporter: Steffen Legler
>     Priority: Minor

> Dynamically built SQL-Statements include a lot of blanks when using conditional
> elements like <isEqual>. The database doesn't care, but for logging it would be
> nice to have a well written sql-statement, e.g. :
> <update id="update" parameterClass="paramClass">
> 	update schema.table1 set 
> 			<isEqual property="listId" compareValue="1">
> 			column1 = #value#						
> 			</isEqual> 	
> 			<isEqual property="listId" compareValue="2">
> 			column2 = #value#						
> 			</isEqual> 			
> 		where id=#instanceId#
> </update>
> The result of a statement looks like this;
> 	update schema.table1 set          column1 = '123'                             where
id = 1000
> For readability it would be nice to have something like this:
> update schema.table1 set column1 = '123' where id = 1000

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
For more information on JIRA, see:

View raw message