hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Commented] (HUDI-2284) Move HoodieDeltaStreamerException to hudi-utilities
Date Sat, 07 Aug 2021 00:30:00 GMT

    [ https://issues.apache.org/jira/browse/HUDI-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17395030#comment-17395030
] 

ASF GitHub Bot commented on HUDI-2284:
--------------------------------------

wangxianghu commented on a change in pull request #3422:
URL: https://github.com/apache/hudi/pull/3422#discussion_r684558355



##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/KafkaOffsetGen.java
##########
@@ -214,7 +213,7 @@ public KafkaOffsetGen(TypedProperties props) {
       }
     }
     if (!found) {
-      throw new HoodieDeltaStreamerException(Config.KAFKA_AUTO_OFFSET_RESET + " config set
to unknown value " + kafkaAutoResetOffsetsStr);
+      throw new HoodieException(Config.KAFKA_AUTO_OFFSET_RESET + " config set to unknown
value " + kafkaAutoResetOffsetsStr);

Review comment:
       we should leave this untouched




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Move HoodieDeltaStreamerException to hudi-utilities
> ---------------------------------------------------
>
>                 Key: HUDI-2284
>                 URL: https://issues.apache.org/jira/browse/HUDI-2284
>             Project: Apache Hudi
>          Issue Type: Improvement
>          Components: DeltaStreamer
>            Reporter: liujinhui
>            Priority: Minor
>              Labels: pull-request-available
>
> HoodieDeltaStreamerException should exist in hudi-utilities



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message