From commits-return-14255-archive-asf-public=cust-asf.ponee.io@hudi.apache.org Thu Mar 26 05:29:52 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 26486180637 for ; Thu, 26 Mar 2020 06:29:52 +0100 (CET) Received: (qmail 61084 invoked by uid 500); 26 Mar 2020 05:29:51 -0000 Mailing-List: contact commits-help@hudi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hudi.apache.org Delivered-To: mailing list commits@hudi.apache.org Received: (qmail 61075 invoked by uid 99); 26 Mar 2020 05:29:51 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Mar 2020 05:29:51 +0000 From: GitBox To: commits@hudi.apache.org Subject: [GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1159: [HUDI-479] Eliminate or Minimize use of Guava if possible Message-ID: <158520059144.18191.10005344991906489297.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Thu, 26 Mar 2020 05:29:51 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit vinothchandar commented on a change in pull request #1159: [HUDI-479] Eliminate or Minimize use of Guava if possible URL: https://github.com/apache/incubator-hudi/pull/1159#discussion_r398318223 ########## File path: hudi-cli/src/test/java/org/apache/hudi/cli/common/HoodieTestCommitMetadataGenerator.java ########## @@ -95,10 +96,9 @@ public static HoodieCommitMetadata generateCommitMetadata(String basePath) throw HoodieTestUtils.createNewDataFile(basePath, DEFAULT_FIRST_PARTITION_PATH, "000"); String file1P1C0 = HoodieTestUtils.createNewDataFile(basePath, DEFAULT_SECOND_PARTITION_PATH, "000"); - return generateCommitMetadata(new ImmutableMap.Builder() - .put(DEFAULT_FIRST_PARTITION_PATH, new ImmutableList.Builder<>().add(file1P0C0).build()) - .put(DEFAULT_SECOND_PARTITION_PATH, new ImmutableList.Builder<>().add(file1P1C0).build()) - .build()); + return generateCommitMetadata(new Maps.MapBuilder>() Review comment: this can just be replaced with a in-place Map construction syntax ? ``` Map doubleBraceMap = new HashMap() {{ put("key1", "value1"); put("key2", "value2"); }}; ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services