From commits-return-14108-archive-asf-public=cust-asf.ponee.io@hudi.apache.org Tue Mar 24 10:10:50 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id F25D118065C for ; Tue, 24 Mar 2020 11:10:49 +0100 (CET) Received: (qmail 67475 invoked by uid 500); 24 Mar 2020 10:10:49 -0000 Mailing-List: contact commits-help@hudi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hudi.apache.org Delivered-To: mailing list commits@hudi.apache.org Received: (qmail 67466 invoked by uid 99); 24 Mar 2020 10:10:49 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Mar 2020 10:10:49 +0000 From: GitBox To: commits@hudi.apache.org Subject: [GitHub] [incubator-hudi] umehrot2 commented on a change in pull request #1427: [HUDI-727]: Copy default values of fields if not present when rewriting incoming record with new schema Message-ID: <158504464932.5240.16358289942635764527.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Tue, 24 Mar 2020 10:10:49 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit umehrot2 commented on a change in pull request #1427: [HUDI-727]: Copy default values of fields if not present when rewriting incoming record with new schema URL: https://github.com/apache/incubator-hudi/pull/1427#discussion_r397037244 ########## File path: hudi-common/src/test/java/org/apache/hudi/common/util/TestHoodieAvroUtils.java ########## @@ -57,4 +60,16 @@ public void testPropsPresent() { } Assert.assertTrue("column pii_col doesn't show up", piiPresent); } + + @Test + public void testDefaultValue() { + GenericRecord rec = new GenericData.Record(new Schema.Parser().parse(EXAMPLE_SCHEMA)); + rec.put("_row_key", "key1"); + rec.put("non_pii_col", "val1"); + rec.put("pii_col", "val2"); + rec.put("timestamp", 3.5); Review comment: Can you help me understand how you are running into this issue with default values ? Based on my understanding, conversion to avro is internal to Hudi and a custom avro schema (with default values) is not something that user can themselves pass. And how `spark-avro` converts `struct schema to avro` there is no special handling there from `default value` perspective. So I guess I am not sure whether this is an issue in the first place. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services