From commits-return-14102-archive-asf-public=cust-asf.ponee.io@hudi.apache.org Tue Mar 24 08:10:45 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id B937C18065C for ; Tue, 24 Mar 2020 09:10:44 +0100 (CET) Received: (qmail 98105 invoked by uid 500); 24 Mar 2020 08:10:44 -0000 Mailing-List: contact commits-help@hudi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hudi.apache.org Delivered-To: mailing list commits@hudi.apache.org Received: (qmail 98096 invoked by uid 99); 24 Mar 2020 08:10:44 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Mar 2020 08:10:44 +0000 From: GitBox To: commits@hudi.apache.org Subject: [GitHub] [incubator-hudi] pratyakshsharma commented on a change in pull request #1427: [HUDI-727]: Copy default values of fields if not present when rewriting incoming record with new schema Message-ID: <158503744397.23252.9613442855678911258.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Tue, 24 Mar 2020 08:10:43 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit pratyakshsharma commented on a change in pull request #1427: [HUDI-727]: Copy default values of fields if not present when rewriting incoming record with new schema URL: https://github.com/apache/incubator-hudi/pull/1427#discussion_r396965661 ########## File path: hudi-common/src/main/java/org/apache/hudi/common/util/HoodieAvroUtils.java ########## @@ -104,15 +103,15 @@ public static Schema addMetadataFields(Schema schema) { List parentFields = new ArrayList<>(); Schema.Field commitTimeField = - new Schema.Field(HoodieRecord.COMMIT_TIME_METADATA_FIELD, METADATA_FIELD_SCHEMA, "", NullNode.getInstance()); + new Schema.Field(HoodieRecord.COMMIT_TIME_METADATA_FIELD, METADATA_FIELD_SCHEMA, "", null); Review comment: yeah. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services