From commits-return-14101-archive-asf-public=cust-asf.ponee.io@hudi.apache.org Tue Mar 24 06:36:23 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3FE6018065C for ; Tue, 24 Mar 2020 07:36:23 +0100 (CET) Received: (qmail 56179 invoked by uid 500); 24 Mar 2020 06:36:22 -0000 Mailing-List: contact commits-help@hudi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hudi.apache.org Delivered-To: mailing list commits@hudi.apache.org Received: (qmail 56170 invoked by uid 99); 24 Mar 2020 06:36:22 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Mar 2020 06:36:22 +0000 From: GitBox To: commits@hudi.apache.org Subject: [GitHub] [incubator-hudi] yanghua commented on issue #1440: [HUDI-731] Add ChainedTransformer Message-ID: <158503178255.2823.11954514934323008263.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Tue, 24 Mar 2020 06:36:22 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit yanghua commented on issue #1440: [HUDI-731] Add ChainedTransformer URL: https://github.com/apache/incubator-hudi/pull/1440#issuecomment-603045516 @xushiyan 's explanation is correct. It's just about trade-off. Both of them can achieve the same function, but the mechanism of collecting `Transformer` is different. Considering that we have limited the functionality of this `Transformer` to: `ChainedTransformer`. Maybe we can hide the "collect/assemble" logic to users? From this perspective, perhaps @vinothchandar 's suggestion is a little better for users. After all, in terms of flexibility, if users want more flexibility, they can even directly inherit the `Transformer` interface and implement everything you currently implement, right? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services