From commits-return-14001-archive-asf-public=cust-asf.ponee.io@hudi.apache.org Sun Mar 22 20:17:10 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id B0C9B18067A for ; Sun, 22 Mar 2020 21:17:09 +0100 (CET) Received: (qmail 27853 invoked by uid 500); 22 Mar 2020 20:17:09 -0000 Mailing-List: contact commits-help@hudi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hudi.apache.org Delivered-To: mailing list commits@hudi.apache.org Received: (qmail 27790 invoked by uid 99); 22 Mar 2020 20:17:09 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 22 Mar 2020 20:17:09 +0000 From: GitBox To: commits@hudi.apache.org Subject: [GitHub] [incubator-hudi] bvaradar commented on a change in pull request #1150: [HUDI-288]: Add support for ingesting multiple kafka streams in a single DeltaStreamer deployment Message-ID: <158490822892.4322.11419278404235746403.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Sun, 22 Mar 2020 20:17:08 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit bvaradar commented on a change in pull request #1150: [HUDI-288]: Add support for ingesting multiple kafka streams in a single DeltaStreamer deployment URL: https://github.com/apache/incubator-hudi/pull/1150#discussion_r396128870 ########## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java ########## @@ -342,6 +361,32 @@ public static void main(String[] args) throws Exception { */ private transient DeltaSync deltaSync; + public DeltaSyncService(Config cfg, JavaSparkContext jssc, FileSystem fs, HiveConf hiveConf, Review comment: minor : Looks like most of the code in this constructor is same as that of existing constructor. Can you have one constructor call other. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services