From commits-return-13981-archive-asf-public=cust-asf.ponee.io@hudi.apache.org Sun Mar 22 16:56:28 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9810C180645 for ; Sun, 22 Mar 2020 17:56:28 +0100 (CET) Received: (qmail 16162 invoked by uid 500); 22 Mar 2020 16:56:28 -0000 Mailing-List: contact commits-help@hudi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hudi.apache.org Delivered-To: mailing list commits@hudi.apache.org Received: (qmail 16153 invoked by uid 99); 22 Mar 2020 16:56:27 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 22 Mar 2020 16:56:27 +0000 From: GitBox To: commits@hudi.apache.org Subject: [GitHub] [incubator-hudi] bvaradar commented on a change in pull request #1432: [HUDI-716] Exception: Not an Avro data file when running HoodieCleanClient.runClean Message-ID: <158489618783.25274.9280922607507479049.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Sun, 22 Mar 2020 16:56:27 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit bvaradar commented on a change in pull request #1432: [HUDI-716] Exception: Not an Avro data file when running HoodieCleanClient.runClean URL: https://github.com/apache/incubator-hudi/pull/1432#discussion_r396116123 ########## File path: hudi-client/src/main/java/org/apache/hudi/client/HoodieCleanClient.java ########## @@ -85,7 +85,11 @@ public HoodieCleanMetadata clean(String startCleanTime) throws HoodieIOException // If there are inflight(failed) or previously requested clean operation, first perform them table.getCleanTimeline().filterInflightsAndRequested().getInstants().forEach(hoodieInstant -> { LOG.info("There were previously unfinished cleaner operations. Finishing Instant=" + hoodieInstant); - runClean(table, hoodieInstant); + try { + runClean(table, hoodieInstant); + } catch (Exception e) { + LOG.warn("Failed to perform previous clean operation, instant: " + hoodieInstant, e); Review comment: @lamber-ken : Can we rollback the corrupted instant seamlessly in this case ? Can you also add a CLI (called timeline upgrade) which would read the timeline and fix upgrade issues. For now, the CLI can just handle only known issue - to deal with corrupted inflight clean instants. We can have users run them before upgrade for now and also see if this can be done seamlessly. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services