From commits-return-13698-archive-asf-public=cust-asf.ponee.io@hudi.apache.org Thu Mar 19 21:57:09 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 77BC6180661 for ; Thu, 19 Mar 2020 22:57:09 +0100 (CET) Received: (qmail 26096 invoked by uid 500); 19 Mar 2020 21:57:08 -0000 Mailing-List: contact commits-help@hudi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hudi.apache.org Delivered-To: mailing list commits@hudi.apache.org Received: (qmail 26083 invoked by uid 99); 19 Mar 2020 21:57:08 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Mar 2020 21:57:08 +0000 From: GitBox To: commits@hudi.apache.org Subject: [GitHub] [incubator-hudi] bvaradar commented on a change in pull request #1416: [HUDI-717] Fixed usage of HiveDriver for DDL statements for Hive 2.x Message-ID: <158465502881.20264.11668938942995667720.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Thu, 19 Mar 2020 21:57:08 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit bvaradar commented on a change in pull request #1416: [HUDI-717] Fixed usage of HiveDriver for DDL statements for Hive 2.x URL: https://github.com/apache/incubator-hudi/pull/1416#discussion_r395337083 ########## File path: hudi-hive-sync/src/main/java/org/apache/hudi/hive/HoodieHiveClient.java ########## @@ -198,7 +198,8 @@ private String getPartitionClause(String partition) { for (String partition : partitions) { String partitionClause = getPartitionClause(partition); Path partitionPath = FSUtils.getPartitionPath(syncConfig.basePath, partition); - String fullPartitionPath = partitionPath.toUri().getScheme().equals(StorageSchemes.HDFS.getScheme()) + String partitionScheme = partitionPath.toUri().getScheme(); + String fullPartitionPath = StorageSchemes.HDFS.getScheme().equals(partitionScheme) Review comment: No, I think it does support cloud stores. This special handling was part of https://jira.apache.org/jira/browse/HUDI-325 to get correct behavior for HDFS for alter partitions. This should be fine. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services