From commits-return-13564-archive-asf-public=cust-asf.ponee.io@hudi.apache.org Wed Mar 18 02:15:35 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id C3BEC18066D for ; Wed, 18 Mar 2020 03:15:34 +0100 (CET) Received: (qmail 59651 invoked by uid 500); 18 Mar 2020 02:15:34 -0000 Mailing-List: contact commits-help@hudi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hudi.apache.org Delivered-To: mailing list commits@hudi.apache.org Received: (qmail 59617 invoked by uid 99); 18 Mar 2020 02:15:34 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Mar 2020 02:15:34 +0000 From: GitBox To: commits@hudi.apache.org Subject: [GitHub] [incubator-hudi] umehrot2 commented on a change in pull request #1406: [HUDI-713] Fix conversion of Spark array of struct type to Avro schema Message-ID: <158449773408.9285.14167925286525183191.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Wed, 18 Mar 2020 02:15:34 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit umehrot2 commented on a change in pull request #1406: [HUDI-713] Fix conversion of Spark array of struct type to Avro schema URL: https://github.com/apache/incubator-hudi/pull/1406#discussion_r394069929 ########## File path: hudi-spark/src/main/scala/org/apache/hudi/AvroConversionHelper.scala ########## @@ -324,7 +323,7 @@ object AvroConversionHelper { avroSchema, valueType, structName, - getNewRecordNamespace(valueType, recordNamespace, structName)) + recordNamespace) Review comment: Might be good to add a test for Map types as well. We can be sure that we have fixed these issues once and for all, for all the major types we support. Also in future if spark-avro changes something we can immediately fix these issues. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services