From commits-return-13346-archive-asf-public=cust-asf.ponee.io@hudi.apache.org Fri Mar 13 19:50:47 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8586318062C for ; Fri, 13 Mar 2020 20:50:47 +0100 (CET) Received: (qmail 62155 invoked by uid 500); 13 Mar 2020 19:50:46 -0000 Mailing-List: contact commits-help@hudi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hudi.apache.org Delivered-To: mailing list commits@hudi.apache.org Received: (qmail 62146 invoked by uid 99); 13 Mar 2020 19:50:46 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Mar 2020 19:50:46 +0000 From: GitBox To: commits@hudi.apache.org Subject: [GitHub] [incubator-hudi] satishkotha commented on a change in pull request #1396: [HUDI-687] Stop incremental reader on RO table before a pending compaction Message-ID: <158412904676.23728.7654765762540990178.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Fri, 13 Mar 2020 19:50:46 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit satishkotha commented on a change in pull request #1396: [HUDI-687] Stop incremental reader on RO table before a pending compaction URL: https://github.com/apache/incubator-hudi/pull/1396#discussion_r392436630 ########## File path: hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTimeline.java ########## @@ -127,6 +127,24 @@ */ HoodieTimeline getCommitsAndCompactionTimeline(); + + /** + * Get all instants (commits, delta commits) that produce new data, in the active timeline. + */ + HoodieTimeline getCommitsTimeline(); + + /** + * Timeline to include all instants before the first 'requested compaction'. + * + * For example, say timeline: commit at t0, deltacommit at t1, compaction requested at t2, deltacommit at t3, + * this method would return t0, t1 + * + * If there is no pending compaction this is equivalent to getting all instants in the timeline. + * + * @return + */ + HoodieTimeline filterInstantsBeforePendingCompaction(); Review comment: Moved it to HoodieParquetInputFormat as suggested ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services