From commits-return-13213-archive-asf-public=cust-asf.ponee.io@hudi.apache.org Thu Mar 12 00:51:38 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8E38618060E for ; Thu, 12 Mar 2020 01:51:38 +0100 (CET) Received: (qmail 74303 invoked by uid 500); 12 Mar 2020 00:51:38 -0000 Mailing-List: contact commits-help@hudi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hudi.apache.org Delivered-To: mailing list commits@hudi.apache.org Received: (qmail 74294 invoked by uid 99); 12 Mar 2020 00:51:37 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Mar 2020 00:51:37 +0000 From: GitBox To: commits@hudi.apache.org Subject: [GitHub] [incubator-hudi] lamber-ken commented on a change in pull request #1377: [HUDI-663] Fix HoodieDeltaStreamer offset not handled correctly Message-ID: <158397429783.15413.8146367719186860633.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Thu, 12 Mar 2020 00:51:37 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit lamber-ken commented on a change in pull request #1377: [HUDI-663] Fix HoodieDeltaStreamer offset not handled correctly URL: https://github.com/apache/incubator-hudi/pull/1377#discussion_r391348916 ########## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/KafkaOffsetGen.java ########## @@ -180,7 +180,7 @@ public KafkaOffsetGen(TypedProperties props) { .map(x -> new TopicPartition(x.topic(), x.partition())).collect(Collectors.toSet()); // Determine the offset ranges to read from - if (lastCheckpointStr.isPresent()) { + if (lastCheckpointStr.isPresent() && !lastCheckpointStr.get().isEmpty()) { Review comment: Prefer to pushdown the control bebavior to datasource(e.g kafka / pulsar) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services