From commits-return-13143-archive-asf-public=cust-asf.ponee.io@hudi.apache.org Wed Mar 11 06:15:19 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0312E18060E for ; Wed, 11 Mar 2020 07:15:18 +0100 (CET) Received: (qmail 38139 invoked by uid 500); 11 Mar 2020 06:15:18 -0000 Mailing-List: contact commits-help@hudi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hudi.apache.org Delivered-To: mailing list commits@hudi.apache.org Received: (qmail 38118 invoked by uid 99); 11 Mar 2020 06:15:18 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Mar 2020 06:15:18 +0000 From: GitBox To: commits@hudi.apache.org Subject: [GitHub] [incubator-hudi] yihua commented on a change in pull request #1165: [HUDI-76] Add CSV Source support for Hudi Delta Streamer Message-ID: <158390731822.8157.282515867740426241.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Wed, 11 Mar 2020 06:15:18 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit yihua commented on a change in pull request #1165: [HUDI-76] Add CSV Source support for Hudi Delta Streamer URL: https://github.com/apache/incubator-hudi/pull/1165#discussion_r390761144 ########## File path: hudi-utilities/src/test/java/org/apache/hudi/utilities/TestHoodieDeltaStreamer.java ########## @@ -653,7 +659,7 @@ private void prepareParquetDFSSource(boolean useSchemaProvider, boolean hasTrans if (useSchemaProvider) { parquetProps.setProperty("hoodie.deltastreamer.schemaprovider.source.schema.file", dfsBasePath + "/source.avsc"); if (hasTransformer) { - parquetProps.setProperty("hoodie.deltastreamer.schemaprovider.source.schema.file", dfsBasePath + "/target.avsc"); + parquetProps.setProperty("hoodie.deltastreamer.schemaprovider.target.schema.file", dfsBasePath + "/target.avsc"); Review comment: I don't remember fixing unit tests. Given that this is optional so it is possible that the data written may be different from the schema designated. However, I think the integration tests should be able to catch any issue due to schema mismatch. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services